From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 000ED360EDB for ; Tue, 12 May 2026 11:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778586245; cv=none; b=h+qETDMkkKnJe8nm3HXqbSwY3wtgSB9FxWEIiWzdzHv7gKthHGzSHOs8pSoZHl0G3OY4+Ul/U4c8C1m+OLAHYJ++L7Sq7X+LNaglGvT5rmljgtvBDHsYR3WzYMnekX5bss1/C/DQRsFaAajIcobvZRqQIVEqMi9UJXPbwhqnsOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778586245; c=relaxed/simple; bh=3UD84u46ReNbEROsTVI8rp5vjKydSNtZDqLl5v5ZGTk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=paG9mhCMBejqQfDSZhUaloAKrgXtXO/DbyJhqpAb43owYv4ccCCIGuoZc0bNuRsXuPA7HKFZGYql0EhCvhE6mmJMukyTlmQgJNJPNE78qwkhlFCE9WphIj66sWIharynhlYhHo7Tvm1oNQ82T0faaiN3yD3tDxQr141rjShzyaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=egVwBkRq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RpO0XsTl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="egVwBkRq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RpO0XsTl" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64CB59jL2187559 for ; Tue, 12 May 2026 11:44:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KXqX0AgmphHDjjun0t9ZwnaKL20p51pBnMk5v/6dln8=; b=egVwBkRq+vGDJD+F K8Ncxrr3jOAI1dv/DTahBBZeJrZs+m0wRBRZA0jNts5P5PeLx3xsHsetJdIaDdM5 eBoe/Vfg7Jr2S8J5gNXssoZTFmMcZNMFTv6RT205yPFjItiupNicTHpEw+SUtjJj jE/GVktkoo/j4fqY5xOCuoknMnu2zwIRnXHZaSWlCTz+Y5xemgACYWb/4+sHg8bq a9lwO32mz13IIdIdj4e7WF4/2zJrGQxasJkkFcVVVitJo8t8tglMrlGbhTXl7uOL JAZdqtB6wogd1slBe3QDbJJyJtVwNY3MWRqaCpF/evZUDTItDOAIKLrEcb6cPZ2d fvF5kQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3nv0tyq2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 12 May 2026 11:44:03 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50fb3403e99so100394151cf.2 for ; Tue, 12 May 2026 04:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778586242; x=1779191042; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KXqX0AgmphHDjjun0t9ZwnaKL20p51pBnMk5v/6dln8=; b=RpO0XsTlRkkxCiW4dgjOV/mcIY9WajeroEwizOQNVuMwzQq2gicUDvcMhJWHFK9hBy AtBCeD2M1WeDM4JpRgtZkYtwaGiPxkwqmpvizVa8hpZwYwbV+sF2YFO0FJ2rhHVFydom GyKSKKpl9B5k09ujrlJpGNvrCWv73Bgxub4dMsKkeoCPfOZgxpejtYcje5+14HKB0Hsu QjzMqKGqASdpAF5p4no76zbSuZMqk3k36yPmqyeJksiQjv3+RwbrcbXZQU293a2dsoWW f0IeP80eCTlKMOHlXhs5JOQCoafrPfMR8msqLEewzUuQAVtVKN8BycP3JXiMN90hLomm pieg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778586242; x=1779191042; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KXqX0AgmphHDjjun0t9ZwnaKL20p51pBnMk5v/6dln8=; b=sbm4Yft3k9tMPbSsk1BegyDVIYcBAzNfOcYD1M9pRONEpQVqmg+wS2y6cYoxb+Uq6b rQTI5KudrScLaDhLJqyXM8kTS0DlubAk46U+8F6C0wTMoox9h/uMQmJfV5emCNZID2Ue 1kwS3neNHJGh0TJ5itYlf9aGMgIwr9XXhposbTeh1T72fMPlJmqRA2Y89ymxwTQvd49U SjdPvLUSxAYVJEe2kpfnWAWchHfIi64Y0d5SMEH8SpuDaeYEgonSDtOc4q/IbxQdkZEi U2To8kFB+tT794+E1cPXsxtWhBDsOuYfd0x3WU4EakGjkENufsN9Uk9ZDNVTosEDed72 f1mw== X-Forwarded-Encrypted: i=1; AFNElJ81FXNw163nMipwMzw0D0SrYpBEMNLSl0TSSJNDYu+l7rDVws0b6Pz/DGrPl8FCDR/pjOGIfWi/D9Xh@vger.kernel.org X-Gm-Message-State: AOJu0YyHImsy5p2IYBd0SfNf8ZjSftT8ac+a4E4/k85CTEihqcX6Vg3o SF9RiF3s/dq21wgu5KvwBi636zf6Yv1cSDXyM371Ir3RkwWWzTHMjR4oBaqbwacPVp4gFnn+iB0 EOSMAwDV70r2X8eEo06YE3G89eb2mHyQoz9bMF7rRfcyrqv6RCLBlVhXZ1uLXm93pziZ6KC54 X-Gm-Gg: Acq92OElogIiZiCbJsn+u+LVHG7Th3rjdJ6eXLJtvWTvY5rfWGqz/Hwx+Da4xKi1C4v KpSJg4bzjTtB6IX3tEN3oCI/WN1s28+GrQZ8bME9j7+nsjlJ0OjHWc4MnO8o+vfG8O+XJOZFH3r X1XlxtEBAB9rVJNjHyYrDRvTDojtcZk+rJBtdz0YpLLaXsD2CbrlrdQ0CFtm5DC94w2BQDTJA9B epVbqkZaL/hvnsUuqGEQ3OQ/WkaJsnwEhOpiQAAH7J9DORvbibNUVyG7/JBpPgX1dW5wbdcdJEm uEiqhVd69VoETF9dRZ6m8lDZ7b7T+SOMhFq1pZbEn506vHkTyTIx7rwYLSKha8WEMquLj+/eR09 CbKXwpZisUW5CZRNuFtFFxmfpHXkBHod2acM98AXLpibc7+zD X-Received: by 2002:ac8:7c44:0:b0:50d:a26e:1e95 with SMTP id d75a77b69052e-514d2237efemr36800111cf.47.1778586242191; Tue, 12 May 2026 04:44:02 -0700 (PDT) X-Received: by 2002:ac8:7c44:0:b0:50d:a26e:1e95 with SMTP id d75a77b69052e-514d2237efemr36799311cf.47.1778586241337; Tue, 12 May 2026 04:44:01 -0700 (PDT) Received: from [192.168.68.112] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-48e9052c9fesm85887155e9.1.2026.05.12.04.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 04:44:00 -0700 (PDT) Message-ID: <0c6c8db9-b54f-4df0-ae1f-306b7feb6d67@oss.qualcomm.com> Date: Tue, 12 May 2026 11:43:59 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 13/13] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP To: Jens Glathe , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com References: <20260402081118.348071-1-srinivas.kandagatla@oss.qualcomm.com> <20260402081118.348071-14-srinivas.kandagatla@oss.qualcomm.com> <7f10abbd-fb78-4c3a-ab90-7ca78239891a@oldschoolsolutions.biz> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <7f10abbd-fb78-4c3a-ab90-7ca78239891a@oldschoolsolutions.biz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEyMDEyMSBTYWx0ZWRfX1fPSUTvuQ8t9 gFSB0K3d+l4M6IqYXdJwlb1NhZyd/GZyCPpNICB0u81wjGx18bDrrUVrvNIHZGYEUirNSLx3OfT 9qBdprG0whteTgxpgu2qC8V18AprP1p+Q/qOypWlhSLpAleqQ9u6KsV9G3QxAPP8O8OAO32TDyL Z2hpDLzbA+dUHEWgWSgwZh5cpticg8L6dAMKyUb1Zx1QdDDT7QG4tIbReIgkn670kOdfKD0knIc 0Y7btU6o/iK2F7KkmzmI8hmmjO31Xzc+gSK60oSzMSa3syBUbvSEM00vPdK9+tLMfC5HCSQP56h PRyGowqLUq2x9UgNaZ3METAE4sOwvT1ptUFxQ+wmJM0WnzVKEzrJTnwUQGsqeqEVgMlJx8nBSLl kBevaGlCeRtpAeQ0p0EUk7w6NTGJRC/m7RdSTzqCFN3raenjKKQztj25JwPd3F8Q6pt7lbygoE5 0S6DjfxUL2ktXZZhDUA== X-Authority-Analysis: v=2.4 cv=bpB8wkai c=1 sm=1 tr=0 ts=6a031283 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=uTuHR2d3_KI6eGJ4HmgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: xq84f3ewwNGqrpkjq9SYMvy9UvNkxi-K X-Proofpoint-ORIG-GUID: xq84f3ewwNGqrpkjq9SYMvy9UvNkxi-K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 impostorscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605120121 On 5/12/26 5:09 AM, Jens Glathe wrote: > On 02.04.26 10:11, Srinivas Kandagatla wrote: >> Buffers are allocated on pcm_new and mapped in the dsp on every >> prepare call, which is inefficient and unnecessary. >> >> Add new functions q6apm_[un]map_memory_fixed_region to map it on >> to dsp only once after allocation. >> >> Signed-off-by: Srinivas Kandagatla >> --- >>   sound/soc/qcom/qdsp6/audioreach.c |  60 ------------ >>   sound/soc/qcom/qdsp6/audioreach.h |   5 +- >>   sound/soc/qcom/qdsp6/q6apm-dai.c  | 107 ++++++++++++++++++--- >>   sound/soc/qcom/qdsp6/q6apm.c      | 151 +++++++++++++++++++----------- >>   sound/soc/qcom/qdsp6/q6apm.h      |  14 +-- >>   5 files changed, 202 insertions(+), 135 deletions(-) > > Hi there, > > I had to revert this patch from the series to get back working sound on > sc8280xp (Blackrock) on 7.1. And hitting the right patch was pure luck, > tbh, since I integrated the series on 6.19 and couldn't apply the last 2 > cleanly. But figured these are cleanup/refactoring and left them out. > > The errors I'm getting on Blackrock are these: > > Mai 11 21:26:32 volterra kernel: q6apm-dai 3000000.remoteproc:glink- > edge:gpr:service@1:dais: Audio Start: Buffer Allocation failed rc = -22 > Mai 11 21:26:32 volterra kernel: q6apm-dai 3000000.remoteproc:glink- > edge:gpr:service@1:dais: ASoC error (-22): at > snd_soc_pcm_component_new() on 3000000.remoteproc:glink- > edge:gpr:service@1:dais Could you please test this change on your setup and let me know if it helps? If so, I’ll send out a proper fix. This is a workaround for a known issue, I will add more details in the patch that I will send once we know if it fixes the issue. ------------------------>cut<---------------------------- diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-dai.c index ede19fdea6e9..8a1a3d8a3398 100644 --- a/sound/soc/qcom/qdsp6/q6apm-dai.c +++ b/sound/soc/qcom/qdsp6/q6apm-dai.c @@ -497,7 +497,7 @@ static int q6apm_dai_pcm_new(struct snd_soc_component *component, struct snd_soc { struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0); struct snd_pcm *pcm = rtd->pcm; - int size = BUFFER_BYTES_MAX; + int size = BUFFER_BYTES_MAX + 4096; int graph_id, ret; struct snd_pcm_substream *substream; ------------------------>cut<---------------------------- --srini > > Since I'm way out of my depth here, I won't cite from the Great > Hallucinator's analysis. Only reporting that this refactoring breaks > sound on sc8280xp. > > with best regards > > Jens >