From: Roger Quadros <rogerq@kernel.org>
To: Karan Sanghavi <karansanghvi98@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] dt-bindings: usb: add missing compatible arraylist
Date: Sat, 28 Sep 2024 10:58:14 +0300 [thread overview]
Message-ID: <0c71ef80-0a4a-490b-be61-bb7641b9ac88@kernel.org> (raw)
In-Reply-To: <CAEDjzLK1juaOCogWgyDudOn9B1EqbE-vMuGYPxnR9B35y+uAOQ@mail.gmail.com>
On 28/09/2024 10:39, Karan Sanghavi wrote:
> On Mon, 23 Sept 2024 at 17:23, Roger Quadros <rogerq@kernel.org> wrote:
>>
>> On 22/09/2024 20:00, Karan Sanghavi wrote:
>>> Added the vice versa order for compatible property in the yaml file so
>>> that the dtb can parse for the order mentioned in the dts file
>>> k3-am642-sk.dts for ti,j721e-usb.yaml
>>
>> k3-am642-sk.dts does not introduce any nodes with the said compatibles.
>>
>> "ti,am64-usb" compatible is introduced by k3-am642-main.dtsi.
>> There is only one compatible introduced so there is nothing to do about
>> order here.
>>
>> i.e.
>> usbss0: cdns-usb@f900000 {
>> compatible = "ti,am64-usb";
>> reg = <0x00 0xf900000 0x00 0x100>;
>>
>> What is the functional problem you are facing? Maybe then someone
>> can point you in the right direction.
>>
>
> Sorry for mentioning the wrong file name; yes,
> the problem is in k3-am64-main.dtsi file as mentioned below
>
> usbss0: cdns-usb@f900000 {
> 766 compatible = "ti,am64-usb", "ti,j721e-usb";
> 767 reg = <0x00 0xf900000 0x00 0x100>;
>
Which tree are you looking at?
https://elixir.bootlin.com/linux/v6.11/source/arch/arm64/boot/dts/ti/k3-am64-main.dtsi#L761
usbss0: cdns-usb@f900000 {
compatible = "ti,am64-usb";
reg = <0x00 0xf900000 0x00 0x100>;
> Due to this, it gives an error as in the YAML file the order is in
> reverse order.
> Also, I cloned the repo yesterday and still found the same error in
> the dtsi file.
> So have I done something wrong? as I see I might be out of sync with
> latest changes
You seem to be looking at some old tree. Please refer to latest kernel
tree when submitting changes upstream.
--
cheers,
-roger
prev parent reply other threads:[~2024-09-28 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 17:00 [PATCH] dt-bindings: usb: add missing compatible arraylist Karan Sanghavi
2024-09-22 18:51 ` Krzysztof Kozlowski
2024-09-23 11:53 ` Roger Quadros
2024-09-28 7:39 ` Karan Sanghavi
2024-09-28 7:58 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c71ef80-0a4a-490b-be61-bb7641b9ac88@kernel.org \
--to=rogerq@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=karansanghvi98@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).