From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3D252222AC for ; Thu, 13 Feb 2025 17:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739467352; cv=none; b=DH3jWDVWAquhWnrEEMIfT04GC0yf39Xztda3VhR7IU01JdBEtfpn+8XuuFut5Z8zJjgE2bWhvDibW+oKZRXltjxLX2RJWHS3t4cXqTwsNJW6vPXIgxAL9RpRmm4pUPK6//KcF0gQIMQK1KRN5sBFZ37d+8GHm5sOjHawDDIQ4pg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739467352; c=relaxed/simple; bh=G7hQBfdHAo9mM29YIVfHNMeDDe5T3j3p8DniWSYRb28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZHU84B2wkDqxzYMjFOILKGh73jt6s0KXlENLOr4hYfyRrtmaVm/boflzEjvsmCGlX9zBEG7odod3Vl6Ay0270fnca2xfr1UscE5E6kbHYcHNNp67UbmCnzoQciwLZRnDpckF0F/Kh3p3eVqbCEhSevGTbGzij258Pq90uKO4JJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D5eq3HP+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D5eq3HP+" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51DGu1Z3008278 for ; Thu, 13 Feb 2025 17:22:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X7/PUjGwCmpWRxWUtK4W2sPA0ZnQnvaVucugb62nb9E=; b=D5eq3HP+tMC8gmJu c8Ku3aXF7snUBfQSsjWuI0RLwtym21RBWvGLwPDc/m1xQu9BqX/Hnw565FBcaU/z fHkOSGnp5BOYKlpdS0EymHWjDcaCWxowMy7Z4K0+lpI74ucKMzY5oRlyVIAzCs6R sEeRNInfaRvqo/V+UDhispc/rtLNNZSYZ8iyRYLkLO4Fy5GCfftvjcwyNt5lIEId n0JCHpDoJhSDE7PICdAvA/G53E6nnTVfJEuAy1LmH9MFNxoqMkSxybzjDdalxtJr kKrUrdUc7KCHht+u5uktdwnj5+McC0Th/QF8M/qdZh1zggPZjXC8VrisMXT+TDPn +0j3+Q== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44qewhbmrn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 13 Feb 2025 17:22:30 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6e4287d04e4so3302646d6.3 for ; Thu, 13 Feb 2025 09:22:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739467349; x=1740072149; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X7/PUjGwCmpWRxWUtK4W2sPA0ZnQnvaVucugb62nb9E=; b=Da65XULcMWEmOXe7GbVKd+NfIXdokWRYufHg5gt7+YOltoq8yn7k6uHuv7TJrYoTwR JJiarQLqrDhL0UevpI8VSHIIukXDSoD5fJLMBMl9BO97vgeAaJ9Ex2JAb96Z4dMZr7BV ToVmsePUzWhUFSraOiBKpyuLXe2nj9P6Yek4v2pvglYXly5QBJSXwkRxV01BiIJ24SxY 8Qorl8XIL0BuvzoH4dTzruUKrYrEuIPa+cdR18kCrteDo2386GYm99yc/lZA10KveMW0 fyIW69L9G2D2SIIP8HRnfRpFayhJi3O2dOjpSTLzvOSpYUZ6VOUkYZyl40p4ZkvUevM+ oqPw== X-Forwarded-Encrypted: i=1; AJvYcCX96YFKbPsJaefgjds5dMwrhpKEGNlLI7nEnVYkTy5gBWYNKDwtuDSxFOt0o8gD1F2hh/S9ie8RD1NC@vger.kernel.org X-Gm-Message-State: AOJu0YxtVLhpnAXWiYK0YzLLe+u1B0nKUmXa9+tFhj46n4tI6gK5hKnS uGMmVW2ALSo5ISljVSEbFHPm5OwhNvi2eBvyemSf85lksA9fgLZrDclopWzGUqk9+t+Zff4LpA5 E9vmAEflxOIDprbhvBT/s4lBGtEcISf9S1Y5qACqXMUkJBs5IeNT47qz+XKxD X-Gm-Gg: ASbGncuhjUOlxSjQ5lP1aomT5IG/CftNtDbUwoPnTBSFk8H+GJGKO14EQ85p/ZtqVhv fTJfnBqyKMf5f/wBiLcXuGJG+tDVvkX6Ulf21AHLfmNypPAlDwvIR72oj3MriAd8hN61Hade0Zc TS3Z5W5MIpGyif8SgOaY5IXJWvVmXn842uGuW+bo5ne8bTugzP60YjlSiQADNrqLjvr/SgkRkLP W23RAum+ohGPnIbiY6Fgle8hoFBr6hCFUZKpTnS1ud7toujOftQCNliZObsQY8IQ5BUNbH2yamt JiXwWMFJ9zO62Ev/28Zqbu7gIJwOQuTdtl8NBltXoaht6nSqtQFB9uVCyd8= X-Received: by 2002:a05:6214:1cc9:b0:6d8:a150:3eee with SMTP id 6a1803df08f44-6e46f8d9580mr36939496d6.9.1739467348688; Thu, 13 Feb 2025 09:22:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmfP2aHbNd1c/gB4XKIkYhnCqiIT8aj9i7HRo2I1/gnzLpGgVGu1VWam9QZaenn/3b5fmEyQ== X-Received: by 2002:a05:6214:1cc9:b0:6d8:a150:3eee with SMTP id 6a1803df08f44-6e46f8d9580mr36939206d6.9.1739467348348; Thu, 13 Feb 2025 09:22:28 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aba532322f1sm170303766b.19.2025.02.13.09.22.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2025 09:22:27 -0800 (PST) Message-ID: <0c753d83-d49d-43b4-b871-301b8a93797e@oss.qualcomm.com> Date: Thu, 13 Feb 2025 18:22:24 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] drm/msm/a6xx: Fix gpucc register block for A621 To: Rob Clark , Konrad Dybcio Cc: Akhil P Oommen , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Caleb Connolly , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jie Zhang , Rob Clark References: <20250213-a623-gpu-support-v1-0-993c65c39fd2@quicinc.com> <20250213-a623-gpu-support-v1-1-993c65c39fd2@quicinc.com> <2bfaa1ce-0233-456d-ba2e-5b14533f3812@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: b_v-uwED3fZ4qQpeEdKdF6v1U0p0WP9d X-Proofpoint-GUID: b_v-uwED3fZ4qQpeEdKdF6v1U0p0WP9d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-13_07,2025-02-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 impostorscore=0 mlxlogscore=929 phishscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502130124 On 13.02.2025 6:19 PM, Rob Clark wrote: > On Thu, Feb 13, 2025 at 8:36 AM Konrad Dybcio > wrote: >> >> On 13.02.2025 5:10 PM, Akhil P Oommen wrote: >>> From: Jie Zhang >>> >>> Adreno 621 has a different memory map for GPUCC block. So update >>> a6xx_gpu_state code to dump the correct set of gpucc registers. >>> >>> Signed-off-by: Jie Zhang >>> Signed-off-by: Akhil P Oommen >>> --- >> >> So GPU_CC is outside what we consider GPU register region upstream.. >> >> And I've heard voices (+Caleb) lately that we should get some clock register >> dumping infrastructure.. >> >> So while I'm not against this patch fixing a bug, perhaps we can get rid of >> dumping GPU_CC here in the near future > > but we'd still want this to end up in the gpu devcoredump... I suppose if the clock dump is implemented as sysfs, we can export that func and call it from gpu dump code Konrad