From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0EFC77B61 for ; Thu, 13 Apr 2023 09:03:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbjDMJDo (ORCPT ); Thu, 13 Apr 2023 05:03:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229977AbjDMJDX (ORCPT ); Thu, 13 Apr 2023 05:03:23 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B970193EF; Thu, 13 Apr 2023 02:03:08 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id A83E48067; Thu, 13 Apr 2023 17:03:00 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 13 Apr 2023 17:03:00 +0800 Received: from [192.168.125.82] (183.27.97.249) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 13 Apr 2023 17:02:59 +0800 Message-ID: <0c94aadf-fac3-d05c-1c54-ae8337526849@starfivetech.com> Date: Thu, 13 Apr 2023 17:02:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx Content-Language: en-US To: Krzysztof Kozlowski , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel CC: Jack Zhu , , , , References: <20230412084540.295411-1-changhuang.liang@starfivetech.com> <20230412084540.295411-2-changhuang.liang@starfivetech.com> <8dd0dc63-e0df-8764-f756-da032d9d671c@linaro.org> From: Changhuang Liang In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.249] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/13 16:41, Krzysztof Kozlowski wrote: > On 13/04/2023 04:34, Changhuang Liang wrote: >>>>>> + lane_maps: >>>>> >>>>> Why did this appear? Underscores are not allowed. It looks like you >>>>> re-implement some standard property. >>>>> >>>> >>>> Will change to lane-maps. >>>> Yes, according to Vinod advice, lane mapping table use device tree >>>> to parse makes sense. >>> >>> Hm, I have a feeling that I saw such property, so you should dig into >>> existing and in-flight bindings. >>> >>> Best regards, >>> Krzysztof >>> >> >> A standard property? Like "clocks" or "resets"? > > Like lane-polarities now submitted to one MIPI. > > Anyway it does not look like a property of a board. You said it is fixed > per SoC, so it should be implied from the compatible. Otherwise please > explain in description and provide some rationale. > > Best regards, > Krzysztof > This property is the only one used for this IP, I have compared this IP with other DPHY rx module, DPHY modules form the other manufacturers not have this configure. And we also have a SoC called JH7100. It DPHY rx module is the same as JH7110. But we don't do the upstream work on it. If it use this lane-maps will be configure as "lane_maps = /bits/ 8 <0 1 2 3 4 5>;". So what do you think? Can this configure be implemented into a property?