From: Krzysztof Kozlowski <krzk@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>,
Chen Wang <unicornxw@gmail.com>,
aou@eecs.berkeley.edu, unicorn_wang@outlook.com,
conor+dt@kernel.org, guoren@kernel.org, inochiama@outlook.com,
krzk+dt@kernel.org, palmer@dabbelt.com, paul.walmsley@sifive.com,
robh@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
chao.wei@sophgo.com, haijiao.liu@sophgo.com,
xiaoguang.xing@sophgo.com, chunzhi.lin@sophgo.com
Subject: Re: [PATCH 1/1] riscv: sophgo: dts: add power key for pioneer box
Date: Tue, 8 Oct 2024 11:28:24 +0200 [thread overview]
Message-ID: <0cad37dd-772e-4dc2-9943-a473bf21d55a@kernel.org> (raw)
In-Reply-To: <aixuis25v56xwnc6zd2ost5yhho5soznpa2pf6fya6orvwwke4@6n3nhzrd7kio>
On 08/10/2024 07:18, Inochi Amaoto wrote:
> On Tue, Oct 08, 2024 at 09:43:52AM +0800, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@outlook.com>
>>
>> There is a power button on the front panel of the pioneer box.
>> Short pressing the button will trigger the onboard MCU to
>> notify SG2042 through GPIO22 to enter the power-off process.
>>
>> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
>> ---
>> .../boot/dts/sophgo/sg2042-milkv-pioneer.dts | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
>> index a3f9d6f22566..be596d01ff8d 100644
>> --- a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
>> +++ b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
>> @@ -5,6 +5,9 @@
>>
>> #include "sg2042.dtsi"
>>
>> +#include <dt-bindings/gpio/gpio.h>
>
> Just move this include into sg204.dtsi. It seems you forgot to
sg204.dtsi does not use this header, so why it should be there?
DTS does not differ here from C. You include only what is being directly
used.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-08 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 1:43 [PATCH 0/1] Add power key for pioneer box Chen Wang
2024-10-08 1:43 ` [PATCH 1/1] riscv: sophgo: dts: add " Chen Wang
2024-10-08 5:18 ` Inochi Amaoto
2024-10-08 9:28 ` Krzysztof Kozlowski [this message]
2024-10-08 9:46 ` Inochi Amaoto
2024-10-08 6:24 ` [PATCH 0/1] Add " Inochi Amaoto
2024-10-22 2:01 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cad37dd-772e-4dc2-9943-a473bf21d55a@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=chunzhi.lin@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=haijiao.liu@sophgo.com \
--cc=inochiama@gmail.com \
--cc=inochiama@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
--cc=unicornxw@gmail.com \
--cc=xiaoguang.xing@sophgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).