Re: [PATCH v1 2/4] arm64: dts: Add msm8939 SoC

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 20/04/2022 11:31, Jun Nie wrote:
>>
>> Why these opps are named with numerical suffix but other with frequency
>> suffix?
> 
> Hi Krzysztof,
> 
> Because the 200MHz in cpr is just used as a parameter to calculate the
> voltage adjustment.
> The frequency in cpr_opp is not directly related to CPU frequency.
> Such as cpr_opp1 is for
> 200MHz on cluster1 while it is for 249MHz on cluster0. Do you still
> suggest to use
> cpr_opp_200 or so in this case?

Thanks for explanation, I would still choose it to have consistent
opp-hz and suffix.

>>
>> Generic node names, no underscores in node names. This applies everywhere.
>>
>>> +                     compatible = "qcom,qfprom";
>>> +                     reg = <0x00058000 0x1000>;
>>> +                     #address-cells = <1>;
>>> +                     #size-cells = <1>;
>>> +                     cpr_efuse_init_voltage1: ivoltage1@dc {
>>
>> s/ivoltageX/voltage/
> 
> How about cpr_efuse_init_voltage_dc? There are 3
> cpr_efuse_init_voltage* node here.

The node names should be generic, so this should be maybe even just
"efuse"? Feel free to add some prefix to it, so "init-voltage-efuse",
but no underscores and no suffixes in such case (but "init-voltage2-efuse").

Was there anything more to discuss? Without trimming the response it's
not possible to find anything among 1000 unrelated lines. :(

Best regards,
Krzysztof