From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0732FC433EF for ; Wed, 6 Jul 2022 14:42:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233393AbiGFOmf (ORCPT ); Wed, 6 Jul 2022 10:42:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232328AbiGFOme (ORCPT ); Wed, 6 Jul 2022 10:42:34 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FEE11BEB1 for ; Wed, 6 Jul 2022 07:42:33 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id y18so7872718ljj.6 for ; Wed, 06 Jul 2022 07:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6Xe30gHq1/bKVOvvpUolv/zq7ZNGoEVUN1+qrlGNB7M=; b=dJUCvaARPZnU/5Wz/bruRjeC5zre5Fkd+rHtbW9xlKXjHpxRqKtrRhJcWNIWfV5fzh pg3javD/nGaSKyy0wWmt2m/46hnr7UXcRv6EDjftRg8+jSKVhzttwvOhs+hJrLXa+Zy4 orylxwG+eTdCwvOUj7V0UGvV6BOw7ZcFnOjIxY7/zGkI8PL7c7S+ZxwymH7w5dKU4m6M x7uiNd6N5FxbDzKlX3m3MY7tJEsOEPZHOvWZeAnPQ8xtWQcRjk83ZCareMtKaVvKAO8f d9LjUF34CJAHo0ejzxdwalSneiYiZVkXttsijm4HUh/lrIGUPSHKgDW3jflNv1PPQO41 hWeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6Xe30gHq1/bKVOvvpUolv/zq7ZNGoEVUN1+qrlGNB7M=; b=GXeKV6IBv76nflC08RYe92mxRF9tm40tafSTBAKClq0SOFNj5BcI1ofc8QyOo6/06R OEVJcA3iGTHNpYj2rE5bEeHKF6Dj1tHqF4sOlXed6zun6QiYO9Siq1QOJ/6wadh4czPY IP6ocJ71OurBhinOSH9Z6dbWJXSRsx7uRwKLQwcmEveTf1lgsynKdVpV+ySE91zoZZvw EK7JznpztK4Ne0uPRSWNE7oXfmIRqyAVKmWKOKOqb+df/AZ/T/u8P/GY1tclLCQbmajV v0riDL2bwJtD4izXvRppFXfId3f6jDIeD92w2G6aFlYbel+QKL1RwqEvt6C0K2KZACwr AmFQ== X-Gm-Message-State: AJIora/ctK0GEDo9Pf1CLngh2sshRxiPWY2IzFMuNloJQ/uNpQ3pL7KR j4DrQlVgB8sSgfvaKTXiPpf/xg== X-Google-Smtp-Source: AGRyM1u9DKYFBoJu0fPNHXOP5UXld700MJ8EcMFqpYaPedDBT5bVOHjcVoKn+YYrzqaUozSqcd4nBg== X-Received: by 2002:a2e:99d0:0:b0:25d:33e7:2b01 with SMTP id l16-20020a2e99d0000000b0025d33e72b01mr5207636ljj.146.1657118551635; Wed, 06 Jul 2022 07:42:31 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id s8-20020a056512202800b0047f750ecd8csm6319194lfs.67.2022.07.06.07.42.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 07:42:31 -0700 (PDT) Message-ID: <0cbf9425-7fa3-56fa-286e-f9d87424a6f3@linaro.org> Date: Wed, 6 Jul 2022 16:42:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 03/13] ARM: dts: qcom: add missing rpm regulators and cells for ipq8064 Content-Language: en-US To: Christian Marangi Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan McDowell References: <20220705133917.8405-1-ansuelsmth@gmail.com> <20220705133917.8405-4-ansuelsmth@gmail.com> <62c56348.1c69fb81.d2cad.2584@mx.google.com> From: Krzysztof Kozlowski In-Reply-To: <62c56348.1c69fb81.d2cad.2584@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/07/2022 12:09, Christian Marangi wrote: > On Wed, Jul 06, 2022 at 10:34:16AM +0200, Krzysztof Kozlowski wrote: >> On 05/07/2022 15:39, Christian Marangi wrote: >>> Add cells definition for rpm node and add missing regulators for the 4 >>> regulator present on ipq8064. There regulators are controlled by rpm and >>> to correctly works gsbi4_i2c require to be NEVER disabled or rpm will >>> reject any regulator change request. >>> >>> Signed-off-by: Christian Marangi >>> Tested-by: Jonathan McDowell >>> --- >>> arch/arm/boot/dts/qcom-ipq8064.dtsi | 36 +++++++++++++++++++++++++++++ >>> 1 file changed, 36 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi >>> index 1b4b72723ead..c0b05d2a2d6d 100644 >>> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi >>> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi >>> @@ -844,10 +844,46 @@ rpm: rpm@108000 { >>> clocks = <&gcc RPM_MSG_RAM_H_CLK>; >>> clock-names = "ram"; >>> >>> + #address-cells = <1>; >>> + #size-cells = <0>; >> >> Why adding these? >> > > Fix dt warning, will split and put it in a separate commit. > >>> + >>> rpmcc: clock-controller { >>> compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; >>> #clock-cells = <1>; >>> }; >>> + >>> + smb208_regulators: regulators { >>> + compatible = "qcom,rpm-smb208-regulators"; >>> + status = "okay"; >> >> Was the node disabled? >> > > smb208 is the normal and advised way to handle regulators on this > platform. Some device may want to not follow that and implement their > own regulator bypassing rpm so we add a status and on the current device > present upstream we set it disabled as it does use different regulators > implementation. You just added a new node and say we set it as disabled... so the code is not correct, because you enabled it. So again my question is valid - was the node already existing and was it disabled? > Best regards, Krzysztof