From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Oliveira Subject: Re: [V2, 2/5] Documentation: dt-bindings: Document the Synopsys MIPI DPHY Rx bindings Date: Thu, 20 Sep 2018 15:26:02 +0100 Message-ID: <0cc27ea0-7c05-4c07-6c14-2146b0c2b370@synopsys.com> References: <20180920111648.27000-1-lolivei@synopsys.com> <20180920111648.27000-3-lolivei@synopsys.com> <1754496.WQhu2lOnZY@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1754496.WQhu2lOnZY@avalon> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Laurent Pinchart , Luis Oliveira Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Joao.Pinto@synopsys.com, festevam@gmail.com, Rob Herring , Mark Rutland , Mauro Carvalho Chehab , Hans Verkuil , Geert Uytterhoeven , Laurent Pinchart , Arnd Bergmann , Jacob Chen , Neil Armstrong , Keiichi Watanabe , Kate Stewart , Philipp Zabel , Todor Tomov , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 20-Sep-18 14:11, Laurent Pinchart wrote: > Hi Louis, > > Thank you for the patch. > Hi Laurent, thank you for your review, my answers are inline. > On Thursday, 20 September 2018 14:16:40 EEST Luis Oliveira wrote: >> Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in >> RX mode. >> >> Signed-off-by: Luis Oliveira >> --- >> Changelog >> v2: >> - no changes >> >> .../devicetree/bindings/phy/snps,dphy-rx.txt | 36 +++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt new file mode >> 100644 >> index 0000000..9079f4a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> @@ -0,0 +1,36 @@ >> +Synopsys DesignWare MIPI Rx D-PHY block details >> + >> +Description >> +----------- >> + >> +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode. >> +Please refer to phy-bindings.txt for more information. >> + >> +Required properties: >> +- compatible : Shall be "snps,dphy-rx". >> +- #phy-cells : Must be 1. >> +- snps,dphy-frequency : Output frequency of the D-PHY. > > If that's the frequency of the clock on the output side of the RX PHY, doesn't > it depend on the frequency on the CSI-2 (or other) bus ? Can't it vary ? Why > do you need to have it in DT ? > But you are right, I will move it to the CSI-2 block. The reason for it to be on the DT is that my use case have a camera with fixed frequency connected, but of course I can change it after. >> +- snps,dphy-te-len : Size of the communication interface (8 bits->8 or >> 12bits->12). > > We have similar properties in various bindings, such as bus-width in video- > interfaces.txt. Couldn't we use a more standard name ? I have read the bus-width property but I don't this is the same. This is not a video quite a video interface. Our D-PHY is configured using an control interface, which is called "test interface" and can have 8-bit or 12-bit. > >> +- reg : Physical base address and size of the device memory mapped >> + registers; > > The example below shows three ranges. Could you document the ranges that are > expected ? > The three ranges is optional, it can be only two. - The first is the interface from which we communicate with the d-phy. A small window the for the referenced above "test interface". - The second and third reg are regions for configuration for the d-phy before the d-phy bring up: a few examples: - 4+4 data lanes max, 1 clk - 8 data lanes max, 1clk - 4+4 data lanes, 2 clk >> +Optional properties: >> +- snps,compat-mode : Compatibility mode control > > What is this ? This toggles a mode for a specific d-phy that we can't auto-detect. So when we use it we activate the compatibility mode for it. I can remove it if you think it's best. > >> +The per-board settings: >> +- gpios : Synopsys testchip used as reference uses this to change > setup >> + configurations. > > Here too, what is this for ? Most of our d-phys have a wrapper around that can be controlled by a gpio-driver that can halt the d-phy. > >> +Example: >> + >> + mipi_dphy_rx1: dphy@3040 { >> + compatible = "snps,dphy-rx"; >> + #phy-cells = <1>; >> + snps,dphy-frequency = <300000>; >> + snps,dphy-te-len = <12>; >> + snps,compat-mode = <1>; >> + reg = < 0x03040 0x20 >> + 0x08000 0x100 >> + 0x09000 0x100>; > > The base addresses are pretty low, what kind of bus does this sit on ? > It sits on top of a bus like this for my configuration. dx_mb { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges = <0x00000000 0x0 0xD0000000 0x10000000>; interrupt-parent = <&he_intc>; ... >> + }; >> + >