devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] arm64: dts: exynos2200: introduce serial busses, except spi
Date: Sat, 16 Aug 2025 20:35:41 +0300	[thread overview]
Message-ID: <0cd105e7-505d-40da-a0d3-1f8ada8f2ca7@gmail.com> (raw)
In-Reply-To: <CAPLW+4mjOmi4BM2zOPcR6GH=4ngA3FisotqFXXGAbHOghQ4x8g@mail.gmail.com>

On 8/16/25 20:29, Sam Protsenko wrote:
> On Fri, Aug 15, 2025 at 2:05 AM Ivaylo Ivanov
> <ivo.ivanov.ivanov1@gmail.com> wrote:
>> Hey, folks!
>>
>> This patchset adds serial busses, implemented in usi, for exynos2200.
>> It's missing spi, due to me having troubles with reads when testing.
>> Serial_0/1 have not been included in the patchset, as it seems like
>> they're encapsulated in usi blocks, but are the only implemented
>> protocol and/or do not have a dedicated register for setting other
>> protocols in a sysreg. That'd at least require patches in the usi
>> driver and bindings to add support for.
>>
>> About the naming convention for usi nodes, I've chosen to keep the
>> downstream one instead of relabelling all to avoid confusion when
>> cross-referencing the vendor DT and to keep consistency with clock
>> names. They're labelled the same in the bootloader too.
>>
>> Best regards,
>> Ivaylo
>>
>> Changes in v3:
>> - drop the serial_0/1 patch
> Why did you decide to drop it? As I understand, having a serial
> console enabled can be quite valuable for this platform bring up.

On the only board that is supported (g0s), serial can either be accessed
via a special usb-c cable, whose way of working only Samsung knows,
or soldering to uart pads on a tiny masked jtag (?) connector on the motherboard.
The latter I'm not sure exists, as I haven't checked on g0s. (it does on dreamlte).
Using uart is not really viable for debugging, framebuffer/usb work too :)

> If you don't know how to add the related USI node -- it's ok, can be done
> later, as soon as the serial works without it.

I can't test that. On dreamlte a similar scenario exists, however usiv1
does not require the clock gating code, so not encapsulating it in
a USI node is fine. Not sure about g0s, however.

Best regards,
Ivaylo

>
>> - add r-b tags from Sam
>> - increase the size of all syscon to 0x10000 and not 0x3000
>> - change description of last patch to be more meaningful regarding the
>> usiN and usiN_i2c mess
>> - s/usi6_i2c_cmgp/usi_i2c_cmgp6, following the TRM naming convention
>>
>> Changes in v2:
>> - add a patch that switches address and size cells to 1 in /soc
>> - adjust all new nodes to define reg props with 2 cells in total instead of 4
>>
>> Ivaylo Ivanov (4):
>>   arm64: dts: exynos2200: fix typo in hsi2c23 bus pins label
>>   arm64: dts: exynos2200: use 32-bit address space for /soc
>>   arm64: dts: exynos2200: increase the size of all syscons
>>   arm64: dts: exynos2200: define all usi nodes
>>
>>  .../boot/dts/exynos/exynos2200-pinctrl.dtsi   |    2 +-
>>  arch/arm64/boot/dts/exynos/exynos2200.dtsi    | 1433 ++++++++++++++++-
>>  2 files changed, 1398 insertions(+), 37 deletions(-)
>>
>> --
>> 2.43.0
>>
>>


  reply	other threads:[~2025-08-16 17:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15  7:04 [PATCH v3 0/4] arm64: dts: exynos2200: introduce serial busses, except spi Ivaylo Ivanov
2025-08-15  7:04 ` [PATCH v3 1/4] arm64: dts: exynos2200: fix typo in hsi2c23 bus pins label Ivaylo Ivanov
2025-08-15  7:04 ` [PATCH v3 2/4] arm64: dts: exynos2200: use 32-bit address space for /soc Ivaylo Ivanov
2025-08-15  7:04 ` [PATCH v3 3/4] arm64: dts: exynos2200: increase the size of all syscons Ivaylo Ivanov
2025-08-16 17:26   ` Sam Protsenko
2025-08-15  7:05 ` [PATCH v3 4/4] arm64: dts: exynos2200: define all usi nodes Ivaylo Ivanov
2025-08-16 18:00   ` Sam Protsenko
2025-08-16 20:25     ` Ivaylo Ivanov
2025-08-16 17:29 ` [PATCH v3 0/4] arm64: dts: exynos2200: introduce serial busses, except spi Sam Protsenko
2025-08-16 17:35   ` Ivaylo Ivanov [this message]
2025-08-29 10:40 ` Ivaylo Ivanov
2025-08-29 10:55   ` Krzysztof Kozlowski
2025-08-29 11:04     ` Ivaylo Ivanov
2025-08-30  9:19 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cd105e7-505d-40da-a0d3-1f8ada8f2ca7@gmail.com \
    --to=ivo.ivanov.ivanov1@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=semen.protsenko@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).