From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: qcom: sdm630: move DSI opp-table into DSI node
Date: Sat, 25 Mar 2023 13:10:13 +0100 [thread overview]
Message-ID: <0cd34c19-d24f-04b1-6e93-b6131ca1612e@linaro.org> (raw)
In-Reply-To: <5cf37779-49fe-ad06-d357-582129995771@linaro.org>
On 25/03/2023 13:04, Konrad Dybcio wrote:
>
>
> On 24.03.2023 21:22, Krzysztof Kozlowski wrote:
>> The soc node is supposed to have only device nodes with MMIO addresses,
>> so move the DSI OPP into the DSI controller node to fix:
>>
>> sda660-inforce-ifc6560.dtb: soc: opp-table-dsi: {'compatible': ['operating-points-v2'], ... should not be valid under {'type': 'object'}
>> From schema: dtschema/schemas/simple-bus.yaml
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> Nit: you also changed its node name and didn't mention that, but I
> don't see that as anything major so it's gtg as-is
Because the binding expect a child named "opp-table", so I assumed it is
obvious when you move the table into the device's node.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-25 12:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 20:22 [PATCH 1/5] arm64: dts: qcom: msm8916-thwc-ufi001c: add function to pin config Krzysztof Kozlowski
2023-03-24 20:22 ` [PATCH 2/5] arm64: dts: qcom: apq8096-db820c: drop simple-bus from clocks Krzysztof Kozlowski
2023-03-25 12:03 ` Konrad Dybcio
2023-08-31 9:04 ` Dmitry Baryshkov
2023-09-01 8:04 ` Krzysztof Kozlowski
2023-09-01 14:24 ` Dmitry Baryshkov
2023-03-24 20:22 ` [PATCH 3/5] arm64: dts: qcom: msm8994-msft-lumia: " Krzysztof Kozlowski
2023-03-25 12:03 ` Konrad Dybcio
2023-03-24 20:22 ` [PATCH 4/5] arm64: dts: qcom: msm8996-xiaomi: " Krzysztof Kozlowski
2023-03-25 12:03 ` Konrad Dybcio
2023-03-24 20:22 ` [PATCH 5/5] arm64: dts: qcom: sdm630: move DSI opp-table into DSI node Krzysztof Kozlowski
2023-03-25 12:04 ` Konrad Dybcio
2023-03-25 12:10 ` Krzysztof Kozlowski [this message]
2023-03-25 12:02 ` [PATCH 1/5] arm64: dts: qcom: msm8916-thwc-ufi001c: add function to pin config Konrad Dybcio
2023-03-26 3:04 ` (subset) " Bjorn Andersson
2023-04-07 19:26 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cd34c19-d24f-04b1-6e93-b6131ca1612e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).