From: "André Draszik" <andre.draszik@linaro.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: peter.griffin@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
tudor.ambarus@linaro.org, willmcvicker@google.com,
alim.akhtar@samsung.com, s.nawrocki@samsung.com,
tomasz.figa@gmail.com, cw00.choi@samsung.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 6/9] arm64: dts: exynos: gs101: enable i2c bus 12 on gs101-oriole
Date: Mon, 29 Jan 2024 10:40:02 +0000 [thread overview]
Message-ID: <0d3236e90604e82a609d205c6fbb56fd882ecfbb.camel@linaro.org> (raw)
In-Reply-To: <CAPLW+4m4G+-zFLGr6Bp-73-mERCofxDiD7F=2fd_Wq+18iTs9g@mail.gmail.com>
Hi Sam,
On Fri, 2024-01-26 at 20:58 -0600, Sam Protsenko wrote:
> On Fri, Jan 26, 2024 at 6:19 PM André Draszik <andre.draszik@linaro.org> wrote:
> >
> > This bus has various USB-related devices attached to it.
> >
> > [...]
> >
> > +&hsi2c_12 {
> > + status = "okay";
>
> But there are no bus clients declared here? A bit of explanation about
> how this bus is being currently used would be nice to have (in commit
> message); e.g. maybe it's used in user space somehow, etc. Because
> otherwise it doesn't have much sense to enable the bus with no users.
As per the commit message, there are devices, but:
* most or all don't have an upstream driver at this stage
* it does make sense to enable the bus, as enabling it allows working on
the drivers for the devices that are attached to this bus
Cheers,
Andre'
next prev parent reply other threads:[~2024-01-29 10:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 0:19 gs101 oriole: peripheral block 1 (peric1) and i2c12 support André Draszik
2024-01-27 0:19 ` [PATCH 1/9] clk: samsung: gs-101: drop extra empty line André Draszik
2024-01-27 2:42 ` Sam Protsenko
2024-01-29 9:14 ` Peter Griffin
2024-01-29 12:44 ` Tudor Ambarus
2024-01-27 0:19 ` [PATCH 2/9] dt-bindings: clock: google,gs101-clock: add PERIC1 clock management unit André Draszik
2024-01-27 2:48 ` Sam Protsenko
2024-01-29 9:18 ` Peter Griffin
2024-01-29 16:46 ` Tudor Ambarus
2024-01-27 0:19 ` [PATCH 3/9] clk: samsung: gs101: add support for cmu_peric1 André Draszik
2024-01-27 1:40 ` André Draszik
2024-01-27 3:48 ` Sam Protsenko
2024-01-29 12:53 ` Peter Griffin
2024-01-29 17:12 ` Tudor Ambarus
2024-01-27 0:19 ` [PATCH 4/9] arm64: dts: exynos: gs101: enable cmu-peric1 clock controller André Draszik
2024-01-27 2:49 ` Sam Protsenko
2024-01-29 9:20 ` Peter Griffin
2024-01-27 0:19 ` [PATCH 5/9] arm64: dts: exynos: gs101: define USI12 with I2C configuration André Draszik
2024-01-27 2:55 ` Sam Protsenko
2024-01-29 10:26 ` André Draszik
2024-01-27 0:19 ` [PATCH 6/9] arm64: dts: exynos: gs101: enable i2c bus 12 on gs101-oriole André Draszik
2024-01-27 2:58 ` Sam Protsenko
2024-01-29 10:40 ` André Draszik [this message]
2024-01-29 16:34 ` Sam Protsenko
2024-01-29 17:35 ` André Draszik
2024-01-29 9:28 ` Peter Griffin
2024-01-29 17:35 ` André Draszik
2024-01-27 0:19 ` [PATCH 7/9] dt-bindings: samsung: exynos-sysreg: gs101-peric1 requires a clock André Draszik
2024-01-27 2:59 ` Sam Protsenko
2024-01-29 9:33 ` Peter Griffin
2024-01-27 0:19 ` [PATCH 8/9] arm64: dts: exynos: gs101: sysreg_peric1 needs " André Draszik
2024-01-27 3:00 ` Sam Protsenko
2024-01-29 10:45 ` André Draszik
2024-01-29 11:01 ` Krzysztof Kozlowski
2024-01-27 0:19 ` [PATCH 9/9] clk: samsung: gs101: don't CLK_IGNORE_UNUSED peric1_sysreg clock André Draszik
2024-01-27 3:01 ` Sam Protsenko
2024-01-29 9:33 ` Peter Griffin
2024-01-29 11:03 ` Krzysztof Kozlowski
2024-01-29 13:47 ` André Draszik
2024-01-29 14:08 ` Krzysztof Kozlowski
2024-01-29 15:21 ` André Draszik
2024-01-29 15:39 ` Krzysztof Kozlowski
2024-01-27 2:43 ` gs101 oriole: peripheral block 1 (peric1) and i2c12 support Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3236e90604e82a609d205c6fbb56fd882ecfbb.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).