From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lRqLwsP8" Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4F2710D8; Fri, 1 Dec 2023 00:47:54 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40859dee28cso16685475e9.0; Fri, 01 Dec 2023 00:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701420473; x=1702025273; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=um+WQAjtb46WWAxOPIIxKEpMZp6pmTWg/qcTtD7pJEU=; b=lRqLwsP8RptJr79W225a6IsOA/QRM8UV13WqR5pR8mpDZk0IkMo7An9GVMyM1JoBXi fTFYDTj1V5ccd67shlHhW8aFWp8RFWzrnib6u8181T38iFlq8nqyhbOSBakWnEmZ3y7o C8ls5W950SvWQ8NyCTX4SGk9oaSuE7vLFbBBiSI2XkorOER9VmY+GHRUjk+xo91c36wt GkFu2sEBz40T+zMWPYAqIncju6T6eV2tXKZ8W9cyjjxfeL9q0QdJswphHl2935Zdc+Yf XGMtu0uZYvyyGkkx5RD97Ft6qOAx3zI66EB+KgWL1gwZAV4ZuK06pRZ6Xgr4eVciswW2 CUfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701420473; x=1702025273; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=um+WQAjtb46WWAxOPIIxKEpMZp6pmTWg/qcTtD7pJEU=; b=gyn3a4rNr+vrfZn4wA7rebm/Pz+SAAeaT7m0LOaj8Q8U4/rcrbPfCrRw2I0XhBFoHL 0NTCuoqLNtS/ZB/FPuCAgKAJ2q9gBrjqY20G4H5OTf2GiZ0pE5+5VeVSYr2uOIqYvxWD P33/rhQzLjDyurR7oHHb7Vp3Uq+tDBLkOfxiXNHM3aF0LewF7alJN9yvFzEKiajKUzoD 56MKgH0Gtib5bJBDlCchZb63PmxNjOalch2fn+luA2KManolr7Ei2m3dAR1H85w8JOWc FSIjNw+dZOs6phcNmvkIEYre621xM5BepHCA1tYEfIK1leOGL+9mENYMuJJ8LxuZRwV2 P56g== X-Gm-Message-State: AOJu0Yx1MOlXbtKxni5/PG6IH8Lygk3RG7ymuL5cAE0mu32ysX9jpKZl 7dtEFEoIQTlgnn1bkpP4dpY= X-Google-Smtp-Source: AGHT+IHz+XL20XZN/MJL8ZWBytWAn3PW2/Uc6A3bRW3vV5o1xscB/pPpcUpEmPpf6nMKSOzPWEztZA== X-Received: by 2002:a05:600c:20b:b0:40b:5e22:976 with SMTP id 11-20020a05600c020b00b0040b5e220976mr358765wmi.101.1701420472791; Fri, 01 Dec 2023 00:47:52 -0800 (PST) Received: from ?IPv6:2001:a61:3456:4e01:6ae:b55a:bd1d:57fc? ([2001:a61:3456:4e01:6ae:b55a:bd1d:57fc]) by smtp.gmail.com with ESMTPSA id bd22-20020a05600c1f1600b004090798d29csm4737778wmb.15.2023.12.01.00.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 00:47:52 -0800 (PST) Message-ID: <0d3b2bce9b2f139e3338bd5dfc41a7923617b716.camel@gmail.com> Subject: Re: [PATCH 05/12] iio: adc: ad9467: don't ignore error codes From: Nuno =?ISO-8859-1?Q?S=E1?= To: David Lechner , nuno.sa@analog.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Olivier MOYSAN , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Frank Rowand , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich Date: Fri, 01 Dec 2023 09:47:51 +0100 In-Reply-To: References: <20231121-dev-iio-backend-v1-0-6a3d542eba35@analog.com> <20231121-dev-iio-backend-v1-5-6a3d542eba35@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2023-11-30 at 15:44 -0600, David Lechner wrote: > On Tue, Nov 21, 2023 at 4:17=E2=80=AFAM Nuno Sa via B4 Relay > wrote: > >=20 > > From: Nuno Sa > >=20 > > Make sure functions that return errors are not ignored. > >=20 > > Fixes: ad6797120238 ("iio: adc: ad9467: add support AD9467 ADC") > > Signed-off-by: Nuno Sa > > --- > > =C2=A0drivers/iio/adc/ad9467.c | 25 ++++++++++++++++--------- > > =C2=A01 file changed, 16 insertions(+), 9 deletions(-) > >=20 > > diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c > > index 368ea57be117..04474dbfa631 100644 > > --- a/drivers/iio/adc/ad9467.c > > +++ b/drivers/iio/adc/ad9467.c > > @@ -6,6 +6,7 @@ > > =C2=A0 */ > >=20 > > =C2=A0#include > > +#include >=20 > This looks like an unrelated change (should probably be in a separate com= mit). Indeed it is...=20 >=20 > > =C2=A0#include > > =C2=A0#include > > =C2=A0#include