From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B112C7EE2D for ; Mon, 22 May 2023 09:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232685AbjEVJGJ (ORCPT ); Mon, 22 May 2023 05:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232758AbjEVJFt (ORCPT ); Mon, 22 May 2023 05:05:49 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AE91FD for ; Mon, 22 May 2023 02:05:42 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-30a8dc89c33so712861f8f.0 for ; Mon, 22 May 2023 02:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684746341; x=1687338341; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=axoW3FpSjS6ZdEPcY+HsNe61u2mtrDh5mhZbIxumcWE=; b=Aa5M+EKHb5j+UJQn3aj9tK3Alpc/AIqPMGexoe5BK/lhljSgMfIgHMRCJmFIIlHvhG 6UcwiFu6WHyQiVeMVyMd2HffRIw++HbWroTBu+AatTVdZaTwLOPv3CRSt/my/n9nq9yj FjH6HWRSdD5/GkplLizB+LjLhwAOXffdrEYIo7XNoTr/iPHyPa0N4+1OiStHss5YoLKj u9p4qNgDFm1GxM7F3mEwzD8NB69gx9dVtkxTLb4KX+ueFZrT38wf8p1hH2gtqARdVkNw Gz4eaPmoGAbukv9EqR31rFsCcFEWEHQqH6wekxJQNXbMYgt7wYVX/0VvBsEInVaUvvEt ZYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684746341; x=1687338341; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=axoW3FpSjS6ZdEPcY+HsNe61u2mtrDh5mhZbIxumcWE=; b=k++CCuK88mji3WwdlStNn9B4hozew06o4KqLs5815beSwYC7niUdZvMIYzO/BnTt2B cQBuBj038PCc6vN59/wx0A1COO3ltXVXeqpntnT9x0yAz1RjfZdhf7wlMgc3t2ygL+CN z9bRNKtnfXMXlCN5ToypB8+7/bMRbub393w5CwMVUKGtQgxYXJop2ciZqRpQlOplCXYq TFdTxaydffwCOwxwwaXuk54ueeP9iHdigizn01WNzNITf0gyJ5jcDc97mqBQW5pHRrNz ROunJ+4MCA27qc+rNszL/AnVv8qggNi8hgGFoISgwPvMhA+4OOJGoxC3/sGXeR88Z3J7 wfww== X-Gm-Message-State: AC+VfDxzKa8geXX0JM7+mdBtlk5g98I8I7G+QQ/OUNbttg5bX4/YgQER P7JvV51MwqpCU2lUhENJzWWXDA== X-Google-Smtp-Source: ACHHUZ7UsuzR+CzfhVbTqtR5TnpcQ0AzmPHrl2RfFgGOiVn3yRs3swvssuJeQF9Ixb2dS0cImOvshQ== X-Received: by 2002:a5d:570d:0:b0:307:93ec:b323 with SMTP id a13-20020a5d570d000000b0030793ecb323mr6462958wrv.69.1684746340844; Mon, 22 May 2023 02:05:40 -0700 (PDT) Received: from [192.168.27.65] (home.beaume.starnux.net. [82.66.176.246]) by smtp.gmail.com with ESMTPSA id 15-20020a05600c028f00b003f435652aaesm7665993wmk.11.2023.05.22.02.05.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 02:05:40 -0700 (PDT) Message-ID: <0d436948-b0b7-0727-0852-51f64aefa43f@linaro.org> Date: Mon, 22 May 2023 11:05:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Visionox R66451 AMOLED DSI panel bindings Content-Language: en-US To: Marijn Suijten , Jessica Zhang Cc: Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230516-b4-r66451-panel-driver-v1-0-4210bcbb1649@quicinc.com> <20230516-b4-r66451-panel-driver-v1-1-4210bcbb1649@quicinc.com> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/05/2023 12:30, Marijn Suijten wrote: > On 2023-05-16 13:20:30, Jessica Zhang wrote: >> Document the 1080x2340 Visionox R66451 AMOLED DSI panel bindings >> >> Signed-off-by: Jessica Zhang >> --- >> .../bindings/display/panel/visionox,r66451.yaml | 59 ++++++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml b/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml >> new file mode 100644 >> index 000000000000..6ba323683921 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml >> @@ -0,0 +1,59 @@ >> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/panel/visionox,r66451.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Visionox R66451 AMOLED DSI Panel >> + >> +maintainers: >> + - Jessica Zhang >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: visionox,r66451 >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + vddio-supply: true >> + vdd-supply: true >> + port: true >> + reset-gpios: true > > Normally for cmd-mode panels there is also a `disp-te` pin which is > optionally registered in dsi_host.c as GPIOD_IN, but on **ALL** my Sony > phones this breaks vsync (as in: mdp5 stops receiving the interrupt, but > we can see disp-te in /proc/interrupts then). Describing it as a gpio is wrong, it should be described as a pinctrl state instead. Neil > > - Marijn > >> +additionalProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - vddio-supply >> + - vdd-supply >> + - reset-gpios >> + - port >> + >> +examples: >> + - | >> + #include >> + dsi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + panel@0 { >> + compatible = "visionox,r66451"; >> + reg = <0>; >> + vddio-supply = <&vreg_l12c_1p8>; >> + vdd-supply = <&vreg_l13c_3p0>; >> + >> + reset-gpios = <&tlmm 24 GPIO_ACTIVE_LOW>; >> + >> + port { >> + panel0_in: endpoint { >> + remote-endpoint = <&dsi0_out>; >> + }; >> + }; >> + }; >> + }; >> +... >> >> -- >> 2.40.1 >>