From: Neil Armstrong <narmstrong@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Artem Lapkin <art@khadas.com>
Subject: Re: [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2
Date: Mon, 30 Nov 2020 14:25:45 +0100 [thread overview]
Message-ID: <0d4e54a3-9eb1-db9e-7d17-985262ed251f@baylibre.com> (raw)
In-Reply-To: <20201125024001.19036-1-christianshewitt@gmail.com>
On 25/11/2020 03:40, Christian Hewitt wrote:
> From: Artem Lapkin <art@khadas.com>
>
> The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
> chip should be 104Mhz not 30MHz.
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> This change was previously submitted as [0] which has style issues and
> remains unmerged. It is also part of a two patch series where the other
> patch needs further work to convert to newer LED bindings.
>
> [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20200928092613.273998-3-art@khadas.com/
>
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 39e6047056b2..079500ed5066 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -391,7 +391,7 @@
> #size-cells = <1>;
> compatible = "winbond,w25q16", "jedec,spi-nor";
> reg = <0>;
> - spi-max-frequency = <3000000>;
> + spi-max-frequency = <104000000>;
> };
> };
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2020-11-30 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 2:40 [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2 Christian Hewitt
2020-11-30 13:25 ` Neil Armstrong [this message]
2020-11-30 13:25 ` Neil Armstrong
2020-12-05 12:02 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d4e54a3-9eb1-db9e-7d17-985262ed251f@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=art@khadas.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).