From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: neil.armstrong@linaro.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
Johan Hovold <johan+linaro@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: phy: qcom,msm8996-qmp-usb3-phy: drop legacy bindings
Date: Wed, 12 Apr 2023 23:27:21 +0300 [thread overview]
Message-ID: <0d56d963-a9dc-f6c5-60c0-421da030e1b3@linaro.org> (raw)
In-Reply-To: <656c6ae6-41c5-9b7e-8602-02d8b3b4149e@linaro.org>
On 27/03/2023 11:00, Neil Armstrong wrote:
> On 24/03/2023 22:55, Dmitry Baryshkov wrote:
>> The qcom,msm8996-qmp-usb3-phy.yaml defines bindings for several PHYs
>> which predate USB -> USB+DP migration. Now as sm8150 has been migrated,
>> drop the legacy bindings completely. No device trees use them anymore.
>> Newer USB+DP bindings should use combo bindings from the beginning.
>
> Shouldn't we mark then as deprecated first ?
Not sure. What would be the reason to do that? There are no users for
them anymore. They do not describe properties (which can be deprecated),
instead they describe devices which are no longer present in DT.
>
> Neil
>
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> .../phy/qcom,msm8996-qmp-usb3-phy.yaml | 80 -------------------
>> 1 file changed, 80 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
>> b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
>> index e81a38281f8c..5684eaf170e4 100644
>> ---
>> a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
>> +++
>> b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
>> @@ -24,26 +24,17 @@ properties:
>> - qcom,msm8996-qmp-usb3-phy
>> - qcom,msm8998-qmp-usb3-phy
>> - qcom,qcm2290-qmp-usb3-phy
>> - - qcom,sc7180-qmp-usb3-phy
>> - - qcom,sc8180x-qmp-usb3-phy
>> - - qcom,sdm845-qmp-usb3-phy
>> - qcom,sdm845-qmp-usb3-uni-phy
>> - qcom,sdx55-qmp-usb3-uni-phy
>> - qcom,sdx65-qmp-usb3-uni-phy
>> - qcom,sm6115-qmp-usb3-phy
>> - - qcom,sm8150-qmp-usb3-phy
>> - qcom,sm8150-qmp-usb3-uni-phy
>> - - qcom,sm8250-qmp-usb3-phy
>> - qcom,sm8250-qmp-usb3-uni-phy
>> - - qcom,sm8350-qmp-usb3-phy
>> - qcom,sm8350-qmp-usb3-uni-phy
>> - - qcom,sm8450-qmp-usb3-phy
>> reg:
>> - minItems: 1
>> items:
>> - description: serdes
>> - - description: DP_COM
>> "#address-cells":
>> enum: [ 1, 2 ]
>> @@ -128,28 +119,6 @@ required:
>> additionalProperties: false
>> allOf:
>> - - if:
>> - properties:
>> - compatible:
>> - contains:
>> - enum:
>> - - qcom,sc7180-qmp-usb3-phy
>> - then:
>> - properties:
>> - clocks:
>> - maxItems: 4
>> - clock-names:
>> - items:
>> - - const: aux
>> - - const: cfg_ahb
>> - - const: ref
>> - - const: com_aux
>> - resets:
>> - maxItems: 1
>> - reset-names:
>> - items:
>> - - const: phy
>> -
>> - if:
>> properties:
>> compatible:
>> @@ -204,7 +173,6 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> - - qcom,sm8150-qmp-usb3-phy
>> - qcom,sm8150-qmp-usb3-uni-phy
>> - qcom,sm8250-qmp-usb3-uni-phy
>> - qcom,sm8350-qmp-usb3-uni-phy
>> @@ -225,29 +193,6 @@ allOf:
>> - const: phy
>> - const: common
>> - - if:
>> - properties:
>> - compatible:
>> - contains:
>> - enum:
>> - - qcom,sm8250-qmp-usb3-phy
>> - - qcom,sm8350-qmp-usb3-phy
>> - then:
>> - properties:
>> - clocks:
>> - maxItems: 3
>> - clock-names:
>> - items:
>> - - const: aux
>> - - const: ref_clk_src
>> - - const: com_aux
>> - resets:
>> - maxItems: 2
>> - reset-names:
>> - items:
>> - - const: phy
>> - - const: common
>> -
>> - if:
>> properties:
>> compatible:
>> @@ -271,28 +216,6 @@ allOf:
>> - const: phy_phy
>> - const: phy
>> - - if:
>> - properties:
>> - compatible:
>> - contains:
>> - enum:
>> - - qcom,sdm845-qmp-usb3-phy
>> - - qcom,sm8150-qmp-usb3-phy
>> - - qcom,sm8350-qmp-usb3-phy
>> - - qcom,sm8450-qmp-usb3-phy
>> - then:
>> - patternProperties:
>> - "^phy@[0-9a-f]+$":
>> - properties:
>> - reg:
>> - items:
>> - - description: TX lane 1
>> - - description: RX lane 1
>> - - description: PCS
>> - - description: TX lane 2
>> - - description: RX lane 2
>> - - description: PCS_MISC
>> -
>> - if:
>> properties:
>> compatible:
>> @@ -319,13 +242,10 @@ allOf:
>> - qcom,ipq6018-qmp-usb3-phy
>> - qcom,ipq8074-qmp-usb3-phy
>> - qcom,qcm2290-qmp-usb3-phy
>> - - qcom,sc7180-qmp-usb3-phy
>> - - qcom,sc8180x-qmp-usb3-phy
>> - qcom,sdx55-qmp-usb3-uni-phy
>> - qcom,sdx65-qmp-usb3-uni-phy
>> - qcom,sm6115-qmp-usb3-phy
>> - qcom,sm8150-qmp-usb3-uni-phy
>> - - qcom,sm8250-qmp-usb3-phy
>> then:
>> patternProperties:
>> "^phy@[0-9a-f]+$":
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-04-12 20:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 21:55 [PATCH 0/5] phy: qcom-qmp-usb: split away legacy USB+DP code Dmitry Baryshkov
2023-03-24 21:55 ` [PATCH 1/5] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: add sm8150 USB+DP PHY Dmitry Baryshkov
2023-03-31 18:56 ` Rob Herring
2023-03-24 21:55 ` [PATCH 2/5] phy: qcom-qmp-combo: add support for the USB+DP PHY on SM8150 platform Dmitry Baryshkov
2023-03-24 21:55 ` [PATCH 3/5] arm64: dts: qcom: sm8150: turn first USB PHY into USB+DP PHY Dmitry Baryshkov
2023-03-27 7:59 ` Neil Armstrong
2023-03-27 8:05 ` Neil Armstrong
2023-03-27 10:14 ` Dmitry Baryshkov
2023-03-27 10:52 ` Konrad Dybcio
2023-04-12 20:26 ` Dmitry Baryshkov
2023-03-24 21:55 ` [PATCH 4/5] dt-bindings: phy: qcom,msm8996-qmp-usb3-phy: drop legacy bindings Dmitry Baryshkov
2023-03-27 8:00 ` Neil Armstrong
2023-04-12 20:27 ` Dmitry Baryshkov [this message]
2023-03-24 21:55 ` [PATCH 5/5] phy: qcom-qmp-usb: split off the legacy USB+dp_com support Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d56d963-a9dc-f6c5-60c0-421da030e1b3@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).