From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C5AC54EED for ; Wed, 25 Jan 2023 21:51:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236599AbjAYVvS (ORCPT ); Wed, 25 Jan 2023 16:51:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235818AbjAYVvC (ORCPT ); Wed, 25 Jan 2023 16:51:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9113266F9F; Wed, 25 Jan 2023 13:49:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 66D56B81BF8; Wed, 25 Jan 2023 21:49:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02744C433D2; Wed, 25 Jan 2023 21:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674683369; bh=G1xaFTWnJevju+PHlhL6UWktezQ4yPt3jpkEt7RY4s0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=qJ5Ydh6DpkSb5kPPQ24EUns+/5aW9FqsK4c+C4wcWF2Eik68IQUEIUpOH8afaqdfL TLASAqAEMqQylSRgaYT2FYrGcXaHacdROWeMY88F8nb/sR/dQ7J81LbJPqxpZ2ABi6 0AOxIkYKdOMrTEpaTa/CxkOTVs2knjRjRUBLQ7RnTmabc8COXzfL8hYWJXg/gzCqW8 37+fIEtxYtFvD3IPbz/7D7NgxCv7hqlgQq1hJBh/PXxsOtfzm1ukvUtq3bm3/eLP2D cZmzTvTqKuO8k0ChrwqhlxTbnA/btTq4S/Dphy0/TH5jRhDgfIi7N9U9pZxlWHxokr fANkhDK56s2bw== Message-ID: <0d7a6821e1825c18db4f6a2efd5bdfde.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230111060402.1168726-7-dmitry.baryshkov@linaro.org> References: <20230111060402.1168726-1-dmitry.baryshkov@linaro.org> <20230111060402.1168726-7-dmitry.baryshkov@linaro.org> Subject: Re: [PATCH v3 06/12] clk: qcom: gcc-apq8084: use parent_hws/_data instead of parent_names From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org To: Andy Gross , Bjorn Andersson , Dmitry Baryshkov , Konrad Dybcio , Krzysztof Kozlowski , Michael Turquette , Rob Herring , Taniya Das Date: Wed, 25 Jan 2023 13:49:26 -0800 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Dmitry Baryshkov (2023-01-10 22:03:56) > Convert the clock driver to specify parent data rather than parent > names, to actually bind using 'clock-names' specified in the DTS rather > than global clock names. Use parent_hws where possible to refer parent > clocks directly, skipping the lookup. >=20 > Note, the system names for xo clocks were changed from "xo" to > "xo_board" to follow the example of other platforms. This switches the > clocks to use DT-provided "xo_board" clock instead of manually > registered "xo" clock and allows us to drop qcom_cc_register_board_clk() > call from the driver at some point. Should probably also mention that using the firmware path will mean the RPM control of XO could be involved and so suspend may no longer achieve XO shutdown or it will stop working. In case bisect lands here we'll know from the commit text that this likely broke power management. >=20 > In the same way change the looked up system "sleep_clk_src" clock to > "sleep_clk", which is registered from DT. >=20 > Reviewed-by: Konrad Dybcio > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd