From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D783413C9C7 for ; Fri, 23 Aug 2024 07:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724399653; cv=none; b=R3Uzjsy5N8NlRl2xXWxauDMW+7gwOIn0Bos4gZFr+Tt7uNjSywiZ7NcfMAC29IpvEu6aLZhneYZy2T4JQOPzLf2pN6o1XGs12BUIAmL4Nl6pwB6Io1uGRIOWZSrwMS27g2Kos2jFfNpEpfJQA6N79JnFdKj2T1h4sHrimOH3MLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724399653; c=relaxed/simple; bh=o/OpwKFjjA1yEkgqJPpN5d/tMG8m+GDhUM0qxhUcYY8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KDQDT3WW2CdxKsTXUNgDh6pt1KN3ZWmistqiqP2Uk92yjYJa8Nxxdho013hP/E/fzpoC6E/6qGfnMk4G05LaoeHJi5u//4ijujlOommavCgjo4en4gDbPdjP76Y8AEv2Adm4TQSvDHfAAgoWECeXBbVeA7iEEexbCLhDHWz2DA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=g9r4KbF8; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="g9r4KbF8" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5bf068aebe5so2441613a12.0 for ; Fri, 23 Aug 2024 00:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724399650; x=1725004450; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K9F6H3c2NVmBHPEentW34dAviw4YhqEZNXwnJa/lgq4=; b=g9r4KbF8boXqlaHvOateW8bGYMOhm34jwDwKIzmDuP1vp+uaDAMhXYzuv8uRWqW6NU MjQpU5jSy34jCJgQsLy3OfHRHE2J8AD5feeCkPjYbiZym6eyDruMe4iG7rnPOYfD/o+H BLtzTTlheSsMNwT4cNUiRze65dOg2tFpv3MV+MnBt0LfwwoF6nSucA0oQRk0EY9dVBMi qG4Ut+4xYurOL3y2yUSb1yaubM0eSpK7enfDo5saLzwG1C+R5wyWSq4YghqlUp9IuouO LPm25Wnfdv6AGWlXbWDSmlMPCUVTWHdZlxblshHuKgCvMap2fmCwSzJtCo5MW1XzPcCE BriA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724399650; x=1725004450; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K9F6H3c2NVmBHPEentW34dAviw4YhqEZNXwnJa/lgq4=; b=HQZN4bSiy2e7WZzv6dYoaKLT8v6js8n1JUPk4p2TBBpCJFZKJVCgrNJrxJe46dz9q1 eoy2FAduZa61Hd20j/P5RKUIeN85lu7EQnkQ24MTUcIOxQ+xOXWATXqOPgwxU3X2ltrP Bt+3Na83MKRKl5EOvoFW0f8KYCIuMcq+BlGhD1TraRqJ7ui9SqHaZfOb3Pk8kumIfYi+ AiJNAufkL+ZDo1LAbVvlKFkJghrAxCuQsyTe11Vm6pcBXzww6FSDwUwOCkpSQE1HD3dX +edFmZiUbt2hnEN/PcUtOAce4qedXccf2lES7F3VfyfC4mUQxurkuIeNtraFOB+4MXqC wZaA== X-Forwarded-Encrypted: i=1; AJvYcCVXQ2RMASoU53FZdcwHQOXYl8au36YvWlw9ACD2Zbjo2TGfQiJbJa6UKIgQs5pp+GkXfsvV4ISOoD+v@vger.kernel.org X-Gm-Message-State: AOJu0YzvhGdPPNz0G37Nq+umz8SJSxp3U15KYJOViZtUoZ2BwqlnoX0n KRwEdylxc1RK5kzoLnAs7YciaaP+9mHMbVDVuQ9U/9KDNU5QyAxUgQ6k8UDRtHo= X-Google-Smtp-Source: AGHT+IEoQJnrG7rJ9f2StMomCkVPrYJqe5+JdS66nZak9PuSepkUhwJhO+/TtFtd6qLUxl+/AblgVw== X-Received: by 2002:a05:6402:4303:b0:5be:e999:18ab with SMTP id 4fb4d7f45d1cf-5c0891a1ccemr803908a12.23.1724399649843; Fri, 23 Aug 2024 00:54:09 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3eabe1sm1754112a12.52.2024.08.23.00.54.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 00:54:09 -0700 (PDT) Message-ID: <0d8b1322-cf15-4ed9-b958-06516bbb64c7@tuxon.dev> Date: Fri, 23 Aug 2024 10:54:06 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/16] dt-bindings: soc: renesas: renesas,rzg2l-sysc: Add #reset-cells for RZ/G3S Content-Language: en-US To: Conor Dooley Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com, ulf.hansson@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-3-claudiu.beznea.uj@bp.renesas.com> <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> From: claudiu beznea In-Reply-To: <20240822-vanilla-enigmatic-f0b05ecca4b6@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Conor, On 22.08.2024 19:42, Conor Dooley wrote: > On Thu, Aug 22, 2024 at 06:27:47PM +0300, Claudiu wrote: >> From: Claudiu Beznea >> >> The RZ/G3S System controller has registers to control signals that need >> to be de-asserted/asserted before/after different SoC areas are power >> on/off. This signals are implemented as reset signals. For this document >> the #reset-cells property. >> >> Signed-off-by: Claudiu Beznea >> --- >> .../bindings/soc/renesas/renesas,rzg2l-sysc.yaml | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >> index 4386b2c3fa4d..6b0bb34485d9 100644 >> --- a/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,rzg2l-sysc.yaml >> @@ -42,12 +42,28 @@ properties: >> - const: cm33stbyr_int >> - const: ca55_deny >> >> + "#reset-cells": >> + const: 1 >> + >> required: >> - compatible >> - reg >> >> additionalProperties: false >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: renesas,r9a08g045-sysc >> + then: >> + required: >> + - "#reset-cells" > > Given this is new required property on an existing platform, I'd expect > some mention of why it used to be okay to not have this but is now > required. Did firmware or a bootloader stage take things out of reset? On previous SoCs the SYS controller has no support for controlling the signals going to different peripherals (USB, PCIE in case of RZ/G3S). I'll add a note about this on next version. Thank you, Claudiu Beznea > >> + else: >> + properties: >> + "#reset-cells": false >> + >> examples: >> - | >> #include >> -- >> 2.39.2 >>