Re: [PATCH v2 1/2] dt-bindings: mmc: cdns,sdhci: Add CQE support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 06/05/2026 11:04, Rohan Joshi via B4 Relay wrote:
> From: Rohan Joshi <rohan1sj@cadence.com>
> 
> Cadence host controller can support CQE. Add optional CQE
> register space and reg-names property to cdns sdhci binding
> 
> Signed-off-by: Rohan Joshi <rohan1sj@cadence.com>
> ---
>  .../devicetree/bindings/mmc/cdns,sdhci.yaml        | 41 +++++++---------------
>  1 file changed, 12 insertions(+), 29 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> index 8902e7925eab..79064282fabc 100644
> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> @@ -26,7 +26,9 @@ properties:
>  
>    reg-names:

There are no reg-names in this file.

>      minItems: 1
> -    maxItems: 2
> +    items:
> +      - const: hc
> +      - const: cqhci
>  
>    interrupts:
>      maxItems: 1
> @@ -138,22 +140,16 @@ allOf:
>            items:
>              - description: Host controller registers
>              - description: Elba byte-lane enable register for writes
> +        reg-names: false

Why?

> +      required:
> +        - resets

Why?

>      else:
>        properties:
>          reg:
> -          oneOf:
> -            - items:
> -                - description: Host controller registers
> -            - items:
> -                - description: Host controller registers
> -                - description: CQE (Command Queue Engine) registers
> -        reg-names:
> -          oneOf:
> -            - items:
> -                - const: sdhci
> -            - items:
> -                - const: sdhci
> -                - const: cqhci
> +          minItems: 1
> +          items:
> +            - description: Host Controller registers
> +            - description: CQE (Command Queuing Engine) registers

Why each device has CQE? If each, then why not Pensando?



>  
>  unevaluatedProperties: false
>  
> @@ -161,7 +157,8 @@ examples:
>    - |
>      emmc: mmc@5a000000 {
>          compatible = "socionext,uniphier-sd4hc", "cdns,sd4hc";
> -        reg = <0x5a000000 0x400>;
> +        reg = <0x5a000000 0x400>, <0x5a000400 0x060>;
> +        reg-names = "hc", "cqhci";
>          interrupts = <0 78 4>;
>          clocks = <&clk 4>;
>          bus-width = <8>;
> @@ -170,17 +167,3 @@ examples:
>          mmc-hs400-1_8v;
>          cdns,phy-dll-delay-sdclk = <0>;
>      };
> -
> -  - |

What are you doing here?


Best regards,
Krzysztof