devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Marek Vasut <marex@denx.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
	<kernel@dh-electronics.com>,
	<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] ARM: dts: stm32: Move ethernet MAC EEPROM from SoM to carrier boards
Date: Tue, 16 May 2023 16:21:12 +0200	[thread overview]
Message-ID: <0dc56bcc-1873-1f79-197d-8a1fd5a99cb4@foss.st.com> (raw)
In-Reply-To: <20230505213729.119789-1-marex@denx.de>

Hi

On 5/5/23 23:37, Marek Vasut wrote:
> The ethernet MAC EEPROM is not populated on the SoM itself, it has to be
> populated on each carrier board. Move the EEPROM into the correct place
> in DTs, i.e. the carrier board DTs. Add label to the EEPROM too.
> 
> Fixes: 7e76f82acd9e1 ("ARM: dts: stm32: Split Avenger96 into DHCOR SoM and Avenger96 board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---

Applied on stm32-next.

Thanks.
Alex



> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> ---
>   arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi   | 6 ++++++
>   arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi | 6 ++++++
>   arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi         | 6 ------
>   arch/arm/boot/dts/stm32mp15xx-dhcor-testbench.dtsi   | 8 ++++++++
>   4 files changed, 20 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> index 8232bbbae379c..302efac5d26f0 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> @@ -321,6 +321,12 @@ adv7513_i2s0: endpoint {
>   			};
>   		};
>   	};
> +
> +	dh_mac_eeprom: eeprom@53 {
> +		compatible = "atmel,24c02";
> +		reg = <0x53>;
> +		pagesize = <16>;
> +	};
>   };
>   
>   &ltdc {
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> index c32c160f97f20..39af79dc654cc 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> @@ -192,6 +192,12 @@ eeprom@50 {
>   		reg = <0x50>;
>   		pagesize = <16>;
>   	};
> +
> +	dh_mac_eeprom: eeprom@53 {
> +		compatible = "atmel,24c02";
> +		reg = <0x53>;
> +		pagesize = <16>;
> +	};
>   };
>   
>   &sdmmc1 {	/* MicroSD */
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi
> index 948054382136b..864960387e634 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi
> @@ -213,12 +213,6 @@ watchdog {
>   			status = "disabled";
>   		};
>   	};
> -
> -	eeprom@53 {
> -		compatible = "atmel,24c02";
> -		reg = <0x53>;
> -		pagesize = <16>;
> -	};
>   };
>   
>   &ipcc {
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-testbench.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-testbench.dtsi
> index 5fdb74b652aca..faed31b6d84a1 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-testbench.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-testbench.dtsi
> @@ -90,6 +90,14 @@ phy0: ethernet-phy@7 {
>   	};
>   };
>   
> +&i2c4 {
> +	dh_mac_eeprom: eeprom@53 {
> +		compatible = "atmel,24c02";
> +		reg = <0x53>;
> +		pagesize = <16>;
> +	};
> +};
> +
>   &sdmmc1 {
>   	pinctrl-names = "default", "opendrain", "sleep";
>   	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>;


      reply	other threads:[~2023-05-16 14:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 21:37 [PATCH] ARM: dts: stm32: Move ethernet MAC EEPROM from SoM to carrier boards Marek Vasut
2023-05-16 14:21 ` Alexandre TORGUE [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dc56bcc-1873-1f79-197d-8a1fd5a99cb4@foss.st.com \
    --to=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@dh-electronics.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marex@denx.de \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).