From: Krzysztof Kozlowski <krzk@kernel.org>
To: wangweidong.a@awinic.com
Cc: broonie@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, ivprusov@salutedevices.com,
jack.yu@realtek.com, krzk+dt@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
nuno.sa@analog.com, paulha@opensource.cirrus.com, perex@perex.cz,
quic_pkumpatl@quicinc.com, rf@opensource.cirrus.com,
robh@kernel.org, tiwai@suse.com, yijiangtao@awinic.com,
zhoubinbin@loongson.cn
Subject: Re: [PATCH V1 2/2] ASoC: codecs: Add aw88166 amplifier driver
Date: Tue, 25 Feb 2025 09:17:27 +0100 [thread overview]
Message-ID: <0dd44da7-b3e3-4639-9acb-a296cba03b68@kernel.org> (raw)
In-Reply-To: <20250225074214.29902-1-wangweidong.a@awinic.com>
On 25/02/2025 08:42, wangweidong.a@awinic.com wrote:
> Thank you very much for your review
>
> On Fri, Feb 23, 2025 at 12:46:14 +0100, krzk@kernel.org wrote:
>> On Fri, Feb 21, 2025 at 06:26:23PM +0800, wangweidong.a@awinic.com wrote:
>>> +
>>> +static void aw88166_hw_reset(struct aw88166 *aw88166)
>>> +{
>>> + if (aw88166->reset_gpio) {
>>> + gpiod_set_value_cansleep(aw88166->reset_gpio, 1);
>>> + usleep_range(AW88166_1000_US, AW88166_1000_US + 10);
>>> + gpiod_set_value_cansleep(aw88166->reset_gpio, 0);
>>> + usleep_range(AW88166_1000_US, AW88166_1000_US + 10);
>>> + gpiod_set_value_cansleep(aw88166->reset_gpio, 1);
>
>> Why do you keep reset as active after reset? How is it suppose to work?
>
> The gpio port of the AW88166 is reset when it is low.
The value here is not value on the pin, but logical value for Linux. 1
means make it active.
> So it's working now, I will modify it as follows:
Really? Your DTS example has ACTIVE_LOW, so with combination of above it
cannot work. Unless this is wrong or your DTS is wrong or this is not
reset but "enable" pin etc.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-25 8:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 10:26 [PATCH V1 0/2] ASoC: codecs: Add aw88166 amplifier driver wangweidong.a
2025-02-21 10:26 ` [PATCH V1 1/2] ASoC: dt-bindings: Add schema for "awinic,aw88166" wangweidong.a
2025-02-23 11:46 ` Krzysztof Kozlowski
2025-02-21 10:26 ` [PATCH V1 2/2] ASoC: codecs: Add aw88166 amplifier driver wangweidong.a
2025-02-23 11:46 ` Krzysztof Kozlowski
2025-02-25 7:42 ` wangweidong.a
2025-02-25 8:17 ` Krzysztof Kozlowski [this message]
2025-02-25 13:09 ` [PATCH " Markus Elfring
2025-02-25 13:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dd44da7-b3e3-4639-9acb-a296cba03b68@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivprusov@salutedevices.com \
--cc=jack.yu@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=paulha@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=quic_pkumpatl@quicinc.com \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=yijiangtao@awinic.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox