From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E5A925EF82; Tue, 25 Feb 2025 08:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740471454; cv=none; b=stM9vcgWw2ih2hSTXRK4P000ERqcHe3J/rMubwKs9ZOYvygmOcnwp6aqGYV8hCrvuUYgVFdDyB77Ai7chIJEoTrrQvMpnXPKcyy1jIRILE/Oj0nkhmBWwmLXJRNEQH7LpMfukAxgVipQOFEPfA+p4IbvDl9KXi9YDjvfUPGhug4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740471454; c=relaxed/simple; bh=HZO2f8Ky8dbSMzYbONAVILHhqJE44ad//F2VLMyxgfA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sUp7DcjZtQQWOAasgYWFgrKR7I9yMrjQQbE+zOgpOD1OiJ0cn5wZIDl4buRlGK4FY3VCZO5wttbnHzv7jIKTlWV2t5NzfmVms+AiYcd5m6Qa/IhTcuWvylARJvpAOsWPbwOFKzqQRTfOD4iG7IQkWacdr6fNTZIW9JP9+8fWpI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nolsGwql; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nolsGwql" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4813CC4CEDD; Tue, 25 Feb 2025 08:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740471453; bh=HZO2f8Ky8dbSMzYbONAVILHhqJE44ad//F2VLMyxgfA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nolsGwqlaPU7Jwuy92yZhxfiJt/GY3cD0xehdjOIPGGeBVA1LsKP87FdQue+dMu+Q gf7O/PXOKDXrT3YVpIs6GyE0iYDXkEWZq+9VAqlttpsRf/6k6dmq4BqaoiDPLmrPwL rmfnzvjrcDfQXRhYRN9Hdzhi42UBsmj4ITEKEV/Y8iLVKZGAokNXnZYuY5jNOGsEeq SgkT7rS+ei5h1lTJMnhwv1SUt9B/nwyl0MZnZXdnHFBIZqAj3xG0ppetreHwVEl6Xg reggk7DCDYJKUzjBcNZ9SfZUFoxbA6dBDyH1HkLgiRTPpLGNB/gmkKPpFu02IeFiwy GK4/WUHEsuSNQ== Message-ID: <0dd44da7-b3e3-4639-9acb-a296cba03b68@kernel.org> Date: Tue, 25 Feb 2025 09:17:27 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 2/2] ASoC: codecs: Add aw88166 amplifier driver To: wangweidong.a@awinic.com Cc: broonie@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, ivprusov@salutedevices.com, jack.yu@realtek.com, krzk+dt@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, nuno.sa@analog.com, paulha@opensource.cirrus.com, perex@perex.cz, quic_pkumpatl@quicinc.com, rf@opensource.cirrus.com, robh@kernel.org, tiwai@suse.com, yijiangtao@awinic.com, zhoubinbin@loongson.cn References: <20250223-vigilant-cooperative-snake-2d810b@krzk-bin> <20250225074214.29902-1-wangweidong.a@awinic.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20250225074214.29902-1-wangweidong.a@awinic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/02/2025 08:42, wangweidong.a@awinic.com wrote: > Thank you very much for your review > > On Fri, Feb 23, 2025 at 12:46:14 +0100, krzk@kernel.org wrote: >> On Fri, Feb 21, 2025 at 06:26:23PM +0800, wangweidong.a@awinic.com wrote: >>> + >>> +static void aw88166_hw_reset(struct aw88166 *aw88166) >>> +{ >>> + if (aw88166->reset_gpio) { >>> + gpiod_set_value_cansleep(aw88166->reset_gpio, 1); >>> + usleep_range(AW88166_1000_US, AW88166_1000_US + 10); >>> + gpiod_set_value_cansleep(aw88166->reset_gpio, 0); >>> + usleep_range(AW88166_1000_US, AW88166_1000_US + 10); >>> + gpiod_set_value_cansleep(aw88166->reset_gpio, 1); > >> Why do you keep reset as active after reset? How is it suppose to work? > > The gpio port of the AW88166 is reset when it is low. The value here is not value on the pin, but logical value for Linux. 1 means make it active. > So it's working now, I will modify it as follows: Really? Your DTS example has ACTIVE_LOW, so with combination of above it cannot work. Unless this is wrong or your DTS is wrong or this is not reset but "enable" pin etc. Best regards, Krzysztof