From: Florian Fainelli <f.fainelli@gmail.com>
To: Jaedon Shin <jaedon.shin@gmail.com>, Ralf Baechle <ralf@linux-mips.org>
Cc: Kevin Cernekee <cernekee@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mips@linux-mips.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: BMIPS: Add support SPI device nodes
Date: Tue, 27 Dec 2016 14:12:12 -0800 [thread overview]
Message-ID: <0dffeca2-68bf-bacd-7eff-8b966c721dde@gmail.com> (raw)
In-Reply-To: <20161227015923.882-3-jaedon.shin@gmail.com>
On 12/26/2016 05:59 PM, Jaedon Shin wrote:
> Adds SPI device nodes to BCM7xxx MIPS based SoCs.
>
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
> ---
> arch/mips/boot/dts/brcm/bcm7125.dtsi | 55 +++++++++++++++++++++++++++++--
> arch/mips/boot/dts/brcm/bcm7346.dtsi | 49 +++++++++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm7358.dtsi | 49 +++++++++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm7360.dtsi | 49 +++++++++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm7362.dtsi | 49 +++++++++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm7420.dtsi | 55 +++++++++++++++++++++++++++++--
> arch/mips/boot/dts/brcm/bcm7425.dtsi | 49 +++++++++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm7435.dtsi | 49 +++++++++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm97125cbmb.dts | 4 +++
> arch/mips/boot/dts/brcm/bcm97346dbsmb.dts | 4 +++
> arch/mips/boot/dts/brcm/bcm97358svmb.dts | 36 ++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm97360svmb.dts | 36 ++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm97362svmb.dts | 4 +++
> arch/mips/boot/dts/brcm/bcm97420c.dts | 4 +++
> arch/mips/boot/dts/brcm/bcm97425svmb.dts | 36 ++++++++++++++++++++
> arch/mips/boot/dts/brcm/bcm97435svmb.dts | 4 +++
> 16 files changed, 526 insertions(+), 6 deletions(-)
>
> diff --git a/arch/mips/boot/dts/brcm/bcm7125.dtsi b/arch/mips/boot/dts/brcm/bcm7125.dtsi
> index bbd00f65ce39..c1e19e57f64a 100644
> --- a/arch/mips/boot/dts/brcm/bcm7125.dtsi
> +++ b/arch/mips/boot/dts/brcm/bcm7125.dtsi
> @@ -46,6 +46,12 @@
> #clock-cells = <0>;
> clock-frequency = <27000000>;
> };
> +
> + spi_clk: spi_clk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <27000000>;
> + };
Nit, this should actually be upg_clk, since this is the clock that the
SPI controller uses, and it is a fixed-clock with a 27Mhz frequency.
Other than that, the rest looks good to me, thanks!
--
Florian
next prev parent reply other threads:[~2016-12-27 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 1:59 [PATCH 0/2] Add Broadcom STB SPI support Jaedon Shin
[not found] ` <20161227015923.882-1-jaedon.shin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-27 1:59 ` [PATCH 1/2] spi: bcm-qspi: Enable the driver on BMIPS_GENERIC Jaedon Shin
2016-12-28 1:15 ` Florian Fainelli
2016-12-27 1:59 ` [PATCH 2/2] MIPS: BMIPS: Add support SPI device nodes Jaedon Shin
2016-12-27 22:12 ` Florian Fainelli [this message]
[not found] ` <0dffeca2-68bf-bacd-7eff-8b966c721dde-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-28 7:39 ` Jaedon Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dffeca2-68bf-bacd-7eff-8b966c721dde@gmail.com \
--to=f.fainelli@gmail.com \
--cc=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jaedon.shin@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).