devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Jonker <jbx6244@gmail.com>
To: Jagan Teki <jagan@amarulasolutions.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	Suniel Mahesh <sunil@amarulasolutions.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 6/7] arm64: dts: rockchip: px30: Add Engicam C.TOUCH 2.0
Date: Mon, 31 Aug 2020 12:08:32 +0200	[thread overview]
Message-ID: <0e286dbd-36e7-54cf-b901-4718d5f7ee6d@gmail.com> (raw)
In-Reply-To: <20200831082917.17117-7-jagan@amarulasolutions.com>

Hi Jagan,

A dtsi file with only an include and no changes isn't useful.
Are you planning to add something to it?
Else combine in single dts file for now.
Same for px30-engicam-edimm2.2.dtsi

On 8/31/20 10:29 AM, Jagan Teki wrote:
> Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose
> carrier board with capacitive touch interface.
> 
> Genaral features:
> - TFT 10.1" industrial, 1280x800 LVDS display
> - Ethernet 10/100
> - Wifi/BT
> - USB Type A/OTG
> - Audio Out
> - CAN
> - LVDS panel connector
> 
> SOM's like PX30.Core needs to mount on top of this Carrier board
> for creating complete PX30.Core C.TOUCH 2.0 board.
> 
> Add support for it.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> Changes for v3:
> - add Amarula Solutions copyright
> Changes for v2:
> - none
> 
>  arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi
> 
> diff --git a/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi b/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi
> new file mode 100644
> index 000000000000..58425b1e559f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi
> @@ -0,0 +1,8 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +#include "px30-engicam-common.dtsi"
> 


  reply	other threads:[~2020-08-31 10:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  8:29 [PATCH v3 0/7] arm64: dts: rockchip: Add Engicam PX30.Core Jagan Teki
2020-08-31  8:29 ` [PATCH v3 1/7] dt-bindings: arm: rockchip: Add Engicam PX30.Core EDIMM2.2 Starter Kit Jagan Teki
2020-08-31  8:29 ` [PATCH v3 2/7] arm64: dts: rockchip: px30: Add Engicam " Jagan Teki
2020-08-31  8:29 ` [PATCH v3 3/7] arm64: dts: rockchip: Add Engicam PX30.Core SOM Jagan Teki
2020-08-31  8:29 ` [PATCH v3 4/7] arm64: dts: rockchip: Add Engicam PX30.Core EDIMM2.2 Starter Kit Jagan Teki
2020-08-31  8:29 ` [PATCH v3 5/7] dt-bindings: arm: rockchip: Add Engicam PX30.Core C.TOUCH 2.0 Jagan Teki
2020-09-03 16:25   ` Rob Herring
2020-09-03 16:47     ` Jagan Teki
2020-09-04 14:50       ` Rob Herring
2020-08-31  8:29 ` [PATCH v3 6/7] arm64: dts: rockchip: px30: Add Engicam " Jagan Teki
2020-08-31 10:08   ` Johan Jonker [this message]
2020-09-01 10:25     ` Jagan Teki
2020-08-31  8:29 ` [PATCH v3 7/7] arm64: dts: rockchip: Add Engicam PX30.Core " Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e286dbd-36e7-54cf-b901-4718d5f7ee6d@gmail.com \
    --to=jbx6244@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael@amarulasolutions.com \
    --cc=robh+dt@kernel.org \
    --cc=sunil@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).