From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD812C4727C for ; Wed, 30 Sep 2020 16:21:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 764292072E for ; Wed, 30 Sep 2020 16:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731099AbgI3QVF (ORCPT ); Wed, 30 Sep 2020 12:21:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731092AbgI3QVF (ORCPT ); Wed, 30 Sep 2020 12:21:05 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 082FAC0613D0 for ; Wed, 30 Sep 2020 09:21:05 -0700 (PDT) Received: from [2a0a:edc0:0:900:6245:cbff:fea0:1793] (helo=kresse.office.stw.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kNeqi-0003P4-5S; Wed, 30 Sep 2020 18:21:00 +0200 Message-ID: <0e2c63f7f7c983d0ce392fa58d911fa64679b9d1.camel@pengutronix.de> From: Lucas Stach To: Marek Vasut , Shawn Guo , Rob Herring Cc: devicetree@vger.kernel.org, Frieder Schrempf , patchwork-lst@pengutronix.de, NXP Linux Team , kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Date: Wed, 30 Sep 2020 18:20:58 +0200 In-Reply-To: <857201e9-01bc-c2cd-e3e3-244544fc9e0e@denx.de> References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-6-l.stach@pengutronix.de> <857201e9-01bc-c2cd-e3e3-244544fc9e0e@denx.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:6245:cbff:fea0:1793 X-SA-Exim-Mail-From: l.stach@pengutronix.de Subject: Re: [PATCH 05/11] soc: imx: gpcv2: add runtime PM support for power-domains X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mi, 2020-09-30 at 18:14 +0200, Marek Vasut wrote: > On 9/30/20 5:50 PM, Lucas Stach wrote: > [...] > > @@ -143,11 +144,17 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) > > u32 reg_val; > > int i, ret; > > > > + ret = pm_runtime_get_sync(domain->dev); > > + if (ret) { > > + pm_runtime_put_noidle(domain->dev); > > + return ret; > > + } > > + > > if (!IS_ERR(domain->regulator)) { > > ret = regulator_enable(domain->regulator); > > if (ret) { > > dev_err(domain->dev, "failed to enable regulator\n"); > > - return ret; > > + goto out_put_pm; > > } > > } > > > > @@ -205,6 +212,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) > > clk_disable_unprepare(domain->clk[i]); > > if (!IS_ERR(domain->regulator)) > > regulator_disable(domain->regulator); > > +out_put_pm: > > + pm_runtime_put(domain->dev); > > > > return ret; > > } > Shouldn't this be pm_runtime_put_sync() ? We don't really care when the parent domains powers down, we just care about it happening sometime, so I guess the code is fine as is, no? Regards, Lucas