From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 158DDC7EE45 for ; Fri, 9 Jun 2023 18:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230299AbjFISft (ORCPT ); Fri, 9 Jun 2023 14:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbjFISfr (ORCPT ); Fri, 9 Jun 2023 14:35:47 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 784CA1730 for ; Fri, 9 Jun 2023 11:35:45 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f60a27c4a2so2590095e87.2 for ; Fri, 09 Jun 2023 11:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686335744; x=1688927744; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mzHdn1DaLzWURRN7ZYzg7ldO/12Vf7Ax/qC+Hs/RMDw=; b=IfM+S68ZeejULF2odiSYoidoZk7h1LBUvvkgGxfC2bGAqKqnCVVRt4v6li4ay+SSW1 2Zs+NN9SzoX0viWeHrv3EizqXNW1cHwhvj7fVlUWXytkRh5vW8e/y+pI1MvSj0HdVBMa aU8RLu/rEExpLKJVsdj4OgAxJYE5fdDWywHheVOnNCFm/Syvzz21JoQdW7YQX8++gCGp J7tWp2eQ6F+vqU7kZTkIH4jcT0thLc+Gtvad6p6MDR1tbtww/tLqxlYymlbrkspki5eT amd+Bcbu5vyAv8z6H11bJzZiquCXsRhCQ1QqgeRt+meBW1EXwJuRbMT7M33ZRIGwqS+I 7w6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686335744; x=1688927744; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mzHdn1DaLzWURRN7ZYzg7ldO/12Vf7Ax/qC+Hs/RMDw=; b=DRzuDi9QhBuaKkbCWk/SIec5dphjNaPObc/ma8boD2z3SrLOBtreGPe8urP7l7nYFr EYClr0WGKp8bEcABLf+PkjRk9Zl+zx1s8+BRrTu/1rMOUG6TEReOzjKi/i/vxJo+0YFP p/upEzVS1CJasTuKc692uOuhpkxZSh9PBY2w+7bHwxEwlGF6Ecr3ynWWWUQQWwHXxmSt OSMnCQRDfNyMYi/13K3ecWkKUCEBsH49xRdQsL5jqM0JS7X6pcP5TplGYmkqTIJRGQpR uDoEvPg9yPmHZDQvatQzBsXW6UYuKY7iyU5aPC28N4DCkyOEmR92d1VdG/yKsvGPzKX/ /qFw== X-Gm-Message-State: AC+VfDyBD99LAIreGb6aPSIam0R77cPBqFuW3FqE0BZczEHjLYZSlYew rb8Z6zjykbD6g07JZYJXpBtZJb92gbSlwBrQ1f8= X-Google-Smtp-Source: ACHHUZ66uv0L+a3FfUxOdzki0YRk+LVgedzWgi8j8TZxEFYFEkg+/7G9u8TzuQykdO23vnBMk3HWaA== X-Received: by 2002:a19:5049:0:b0:4f4:4cd4:2586 with SMTP id z9-20020a195049000000b004f44cd42586mr1231188lfj.20.1686335743642; Fri, 09 Jun 2023 11:35:43 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id o1-20020a056512050100b004f38267a2f9sm622720lfb.161.2023.06.09.11.35.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 11:35:43 -0700 (PDT) Message-ID: <0e3b5d21-24dc-6c44-0984-98d4a33fbe6e@linaro.org> Date: Fri, 9 Jun 2023 20:35:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v8 08/18] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init To: Akhil P Oommen Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Conor Dooley , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , Marijn Suijten References: <20230223-topic-gmuwrapper-v8-0-69c68206609e@linaro.org> <20230223-topic-gmuwrapper-v8-8-69c68206609e@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9.06.2023 20:25, Akhil P Oommen wrote: > On Mon, May 29, 2023 at 03:52:27PM +0200, Konrad Dybcio wrote: >> >> Currently we're only deasserting REG_A6XX_RBBM_GBIF_HALT, but we also >> need REG_A6XX_GBIF_HALT to be set to 0. >> >> This is typically done automatically on successful GX collapse, but in >> case that fails, we should take care of it. >> >> Also, add a memory barrier to ensure it's gone through before jumping >> to further initialization. >> >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Konrad Dybcio >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> index 083ccb5bcb4e..dfde5fb65eed 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> @@ -1003,8 +1003,12 @@ static int hw_init(struct msm_gpu *gpu) >> a6xx_gmu_set_oob(&a6xx_gpu->gmu, GMU_OOB_GPU_SET); >> >> /* Clear GBIF halt in case GX domain was not collapsed */ >> - if (a6xx_has_gbif(adreno_gpu)) >> + if (a6xx_has_gbif(adreno_gpu)) { >> + gpu_write(gpu, REG_A6XX_GBIF_HALT, 0); >> gpu_write(gpu, REG_A6XX_RBBM_GBIF_HALT, 0); >> + /* Let's make extra sure that the GPU can access the memory.. */ >> + mb(); > This barrier is unnecessary because writel transactions are ordered and > we don't expect a traffic from GPU immediately after this. > > -Akhil Right, let's remove it! Konrad >> + } >> >> gpu_write(gpu, REG_A6XX_RBBM_SECVID_TSB_CNTL, 0); >> >> >> -- >> 2.40.1 >>