From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Henry Chen <henryc.chen@mediatek.com>,
Georgi Djakov <djakov@kernel.org>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 12/13] interconnect: mediatek: Don't hijack parent device
Date: Mon, 17 Nov 2025 13:39:44 +0100 [thread overview]
Message-ID: <0e3c692f-a6ef-4d1a-a412-a57b0a0ee8ee@collabora.com> (raw)
In-Reply-To: <20251114-mt8196-dvfsrc-v1-12-b956d4631468@collabora.com>
Il 14/11/25 17:54, Nicolas Frattaroli ha scritto:
> If the intention is that users of the interconnect declare their
> relationship to the child icc_emi node of the dvfsrc controller, then
> this code never worked. That's because it uses the parent dvfsrc device
> as the device it passes to the interconnect core framework, which means
> all the OF parsing is broken.
>
> Use the actual device instead, and pass the dvfsrc parent into the
> dvfsrc calls.
>
> Fixes: b45293799f75 ("interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver")
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2025-11-17 12:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 16:53 [PATCH 00/13] MediaTek Interconnect Cleanup and MT8196 Enablement Nicolas Frattaroli
2025-11-14 16:53 ` [PATCH 01/13] dt-bindings: soc: mediatek: dvfsrc: Add support for MT8196 Nicolas Frattaroli
2025-11-19 7:41 ` Krzysztof Kozlowski
2025-11-19 8:32 ` AngeloGioacchino Del Regno
2025-11-19 8:33 ` AngeloGioacchino Del Regno
2025-11-19 12:29 ` Nicolas Frattaroli
2025-11-19 12:32 ` Krzysztof Kozlowski
2025-11-14 16:53 ` [PATCH 02/13] dt-bindings: soc: mediatek: dvfsrc: Document clock Nicolas Frattaroli
2025-11-17 12:48 ` AngeloGioacchino Del Regno
2025-11-20 0:11 ` Rob Herring (Arm)
2025-11-14 16:53 ` [PATCH 03/13] dt-bindings: interconnect: mt8183-emi: Add support for MT8196 EMI Nicolas Frattaroli
2025-11-20 0:11 ` Rob Herring (Arm)
2025-11-14 16:53 ` [PATCH 04/13] soc: mediatek: mtk-dvfsrc: Change error check for DVFSRCv4 START cmd Nicolas Frattaroli
2025-11-14 16:53 ` [PATCH 05/13] soc: mediatek: mtk-dvfsrc: Add and propagate DVFSRC bandwidth type Nicolas Frattaroli
2025-11-14 16:54 ` [PATCH 06/13] soc: mediatek: mtk-dvfsrc: Add a new callback for calc_dram_bw Nicolas Frattaroli
2025-11-14 16:54 ` [PATCH 07/13] soc: mediatek: mtk-dvfsrc: Write bandwidth to EMI DDR if present Nicolas Frattaroli
2025-11-14 16:54 ` [PATCH 08/13] soc: mediatek: mtk-dvfsrc: Add support for DVFSRCv4 and MT8196 Nicolas Frattaroli
2025-11-14 16:54 ` [PATCH 09/13] soc: mediatek: mtk-dvfsrc: Get and Enable DVFSRC clock Nicolas Frattaroli
2025-11-17 12:38 ` AngeloGioacchino Del Regno
2025-11-14 16:54 ` [PATCH 10/13] soc: mediatek: mtk-dvfsrc: Rework bandwidth calculations Nicolas Frattaroli
2025-11-17 12:39 ` AngeloGioacchino Del Regno
2025-11-14 16:54 ` [PATCH 11/13] interconnect: mediatek: Add support for MediaTek MT8196 EMI ICC Nicolas Frattaroli
2025-11-14 16:54 ` [PATCH 12/13] interconnect: mediatek: Don't hijack parent device Nicolas Frattaroli
2025-11-17 12:39 ` AngeloGioacchino Del Regno [this message]
2025-11-14 16:54 ` [PATCH 13/13] interconnect: mediatek: Aggregate bandwidth with saturating add Nicolas Frattaroli
2025-11-17 12:39 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e3c692f-a6ef-4d1a-a412-a57b0a0ee8ee@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=henryc.chen@mediatek.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox