devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sibi Sankar <quic_sibis@quicinc.com>,
	Abel Vesa <abel.vesa@linaro.org>,
	Rajendra Nayak <quic_rjendra@quicinc.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: qcom: x1e80100-crd: fix missing PCIe4 gpios
Date: Fri, 19 Jul 2024 20:36:33 +0200	[thread overview]
Message-ID: <0e3e6925-f7ee-47ff-b555-6f35a5766d56@linaro.org> (raw)
In-Reply-To: <20240719131722.8343-6-johan+linaro@kernel.org>

On 19.07.2024 3:17 PM, Johan Hovold wrote:
> Add the missing PCIe4 perst, wake and clkreq GPIOs.
> 
> Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
> Cc: stable@vger.kernel.org	# 6.9
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 29 +++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> index 7406f1ad9c55..72d9feec907b 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> @@ -784,6 +784,12 @@ &mdss_dp3_phy {
>  };
>  
>  &pcie4 {
> +	perst-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>;
> +	wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>;
> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pcie4_default>;

property-n
property-names

please

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

  reply	other threads:[~2024-07-19 18:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 13:17 [PATCH 0/7] arm64: dts: qcom: x1e80100: PCIe fixes and CRD modem support Johan Hovold
2024-07-19 13:17 ` [PATCH 1/7] arm64: dts: qcom: x1e80100-crd: fix PCIe4 PHY supply Johan Hovold
2024-07-19 18:34   ` Konrad Dybcio
2024-07-22  7:34     ` Johan Hovold
2024-07-19 13:17 ` [PATCH 2/7] arm64: dts: qcom: x1e80100: fix PCIe domain numbers Johan Hovold
2024-07-19 18:42   ` Konrad Dybcio
2024-07-19 13:17 ` [PATCH 3/7] arm64: dts: qcom: x1e80100-crd: fix up PCIe6a pinctrl node Johan Hovold
2024-07-19 18:35   ` Konrad Dybcio
2024-07-19 13:17 ` [PATCH 4/7] arm64: dts: qcom: x1e80100-crd: disable PCIe6a perst pull down Johan Hovold
2024-07-19 18:42   ` Konrad Dybcio
2024-07-19 13:17 ` [PATCH 5/7] arm64: dts: qcom: x1e80100-crd: fix missing PCIe4 gpios Johan Hovold
2024-07-19 18:36   ` Konrad Dybcio [this message]
2024-07-22  7:38     ` Johan Hovold
2024-07-19 13:17 ` [PATCH 6/7] arm64: dts: qcom: x1e80100: add PCIe5 nodes Johan Hovold
2024-07-19 18:39   ` Konrad Dybcio
2024-07-22  7:40     ` Johan Hovold
2024-07-19 13:17 ` [PATCH 7/7] arm64: dts: qcom: x1e80100-crd: enable SDX65 modem Johan Hovold
2024-07-19 18:43   ` Konrad Dybcio
2024-07-23  2:57 ` [PATCH 0/7] arm64: dts: qcom: x1e80100: PCIe fixes and CRD modem support Rob Herring (Arm)
2024-07-23 15:24   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e3e6925-f7ee-47ff-b555-6f35a5766d56@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).