From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>,
Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2 11/12] ARM: dts: qcom: Add rpm-proc node for SMD platforms
Date: Fri, 9 Jun 2023 17:26:50 +0200 [thread overview]
Message-ID: <0e4b8889-7440-f011-ade2-bc5b415e7b79@linaro.org> (raw)
In-Reply-To: <20230531-rpm-rproc-v2-11-56a4a00c8260@gerhold.net>
On 8.06.2023 09:10, Stephan Gerhold wrote:
> Rather than having the RPM SMD channels as the only child of a dummy
> SMD node, switch to representing the RPM as remoteproc like all the
> other remoteprocs (WCNSS, modem DSP).
>
> This allows assigning additional subdevices to it like the MPM
> interrupt-controller or rpm-master-stats.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-apq8084.dtsi | 6 ++---
> arch/arm/boot/dts/qcom-msm8226.dtsi | 38 ++++++++++++++++----------------
> arch/arm/boot/dts/qcom-msm8974.dtsi | 44 ++++++++++++++++++-------------------
> 3 files changed, 44 insertions(+), 44 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
> index 8f178bc87e1d..2b1f9d0fb510 100644
> --- a/arch/arm/boot/dts/qcom-apq8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
> @@ -784,10 +784,10 @@ spmi_bus: spmi@fc4cf000 {
> };
> };
>
> - smd {
> - compatible = "qcom,smd";
> + rpm: remoteproc {
> + compatible = "qcom,apq8084-rpm-proc", "qcom,rpm-proc";
>
> - rpm {
> + smd-edge {
> interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> qcom,ipc = <&apcs 8 0>;
> qcom,smd-edge = <15>;
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> index a3a9162e9c28..a3e8d023d0e6 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -53,26 +53,10 @@ pmu {
> IRQ_TYPE_LEVEL_HIGH)>;
> };
>
> - reserved-memory {
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges;
> -
> - smem_region: smem@3000000 {
> - reg = <0x3000000 0x100000>;
> - no-map;
> - };
> -
> - adsp_region: adsp@dc00000 {
> - reg = <0x0dc00000 0x1900000>;
> - no-map;
> - };
> - };
> -
> - smd {
> - compatible = "qcom,smd";
> + rpm: remoteproc {
> + compatible = "qcom,msm8226-rpm-proc", "qcom,rpm-proc";
>
> - rpm {
> + smd-edge {
> interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> qcom,ipc = <&apcs 8 0>;
> qcom,smd-edge = <15>;
> @@ -120,6 +104,22 @@ rpmpd_opp_super_turbo: opp6 {
> };
> };
>
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + smem_region: smem@3000000 {
> + reg = <0x3000000 0x100000>;
> + no-map;
> + };
> +
> + adsp_region: adsp@dc00000 {
> + reg = <0x0dc00000 0x1900000>;
> + no-map;
> + };
> + };
> +
> smem {
> compatible = "qcom,smem";
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 58e144957c5d..0a5b5ecb5dfa 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -113,6 +113,28 @@ pmu {
> interrupts = <GIC_PPI 7 0xf04>;
> };
>
> + rpm: remoteproc {
> + compatible = "qcom,msm8974-rpm-proc", "qcom,rpm-proc";
> +
> + smd-edge {
> + interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> + qcom,ipc = <&apcs 8 0>;
> + qcom,smd-edge = <15>;
> +
> + rpm_requests: rpm-requests {
> + compatible = "qcom,rpm-msm8974";
> + qcom,smd-channels = "rpm_requests";
> +
> + rpmcc: clock-controller {
> + compatible = "qcom,rpmcc-msm8974", "qcom,rpmcc";
> + #clock-cells = <1>;
> + clocks = <&xo_board>;
> + clock-names = "xo";
> + };
> + };
> + };
> + };
> +
> reserved-memory {
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -293,28 +315,6 @@ wcnss_smsm: wcnss@7 {
> };
> };
>
> - smd {
> - compatible = "qcom,smd";
> -
> - rpm {
> - interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> - qcom,ipc = <&apcs 8 0>;
> - qcom,smd-edge = <15>;
> -
> - rpm_requests: rpm-requests {
> - compatible = "qcom,rpm-msm8974";
> - qcom,smd-channels = "rpm_requests";
> -
> - rpmcc: clock-controller {
> - compatible = "qcom,rpmcc-msm8974", "qcom,rpmcc";
> - #clock-cells = <1>;
> - clocks = <&xo_board>;
> - clock-names = "xo";
> - };
> - };
> - };
> - };
> -
> soc: soc {
> #address-cells = <1>;
> #size-cells = <1>;
>
next prev parent reply other threads:[~2023-06-09 15:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:10 [PATCH v2 00/12] Add dedicated device tree node for RPM processor/subsystem Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 01/12] dt-bindings soc: qcom: smd-rpm: Fix sort order Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 02/12] dt-bindings: soc: qcom: smd-rpm: Add MSM8909 to qcom,smd-channels Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 03/12] dt-bindings: soc: qcom: smd-rpm: Add some more compatibles Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 04/12] soc: qcom: smd-rpm: Match rpmsg channel instead of compatible Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 05/12] dt-bindings: remoteproc: Add Qualcomm RPM processor/subsystem Stephan Gerhold
2023-06-08 8:27 ` Rob Herring
2023-06-10 16:43 ` Krzysztof Kozlowski
2023-06-10 16:52 ` Stephan Gerhold
2023-06-12 18:19 ` Krzysztof Kozlowski
2023-06-08 7:10 ` [PATCH v2 06/12] soc: qcom: smem: Add qcom_smem_is_available() Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 07/12] rpmsg: qcom_smd: Use qcom_smem_is_available() Stephan Gerhold
2023-06-09 15:07 ` Konrad Dybcio
2023-06-08 7:10 ` [PATCH v2 08/12] soc: qcom: Add RPM processor/subsystem driver Stephan Gerhold
2023-06-09 15:24 ` Konrad Dybcio
2023-06-08 7:10 ` [PATCH v2 09/12] arm64: dts: qcom: Add rpm-proc node for SMD platforms Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 10/12] arm64: dts: qcom: Add rpm-proc node for GLINK gplatforms Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 11/12] ARM: dts: qcom: Add rpm-proc node for SMD platforms Stephan Gerhold
2023-06-09 15:26 ` Konrad Dybcio [this message]
2023-06-08 7:10 ` [PATCH v2 12/12] ARM: dts: qcom: apq8064: Drop redundant /smd node Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4b8889-7440-f011-ade2-bc5b415e7b79@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).