From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D4AD34253C for ; Wed, 12 Nov 2025 16:59:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762966803; cv=none; b=tWWkA9IWQPT3EDJbPGha3UqCcQX8Xe2txZMsjjC2BXYtxubBvUSrip184YsDADKiThqKH5dYFtKSFFT0N8tDjSGnEN/00sOSwetel9logXQPr/0L6AL0umyc+bdJ5GfLMKHH+XNbhTd8nL7+EOKY8zGdwuzazGerX3ytl+uRZc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762966803; c=relaxed/simple; bh=8wx44lorjmXobYAPjgirMKLJlUNzSsr5s3gulPDv6j0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PTLOpriVoGoB0O7bVG3aDQF4C8RpSk0GB3zraoQe6ZTOkNW+xDn18WTh4QKIojGGCsv1tnyzmTLSN/gGKm5e/uV45R5xJdb90lED3KAjcpOD/+HROQaWytEw6yF3wRdlkveh1DO2wmIQ5aUWMYf0aDRS5QOp8S3Pnk01SVHnqjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dwz9Ugmd; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dwz9Ugmd" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-4491510f005so270853b6e.2 for ; Wed, 12 Nov 2025 08:59:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1762966798; x=1763571598; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9UBroaIpNSaiJuWFrz+qWW2HM0uYdQr3mWyR9bfJIIM=; b=dwz9Ugmdt4tA8qi6929B5cM2xqwjHCY2sziOHziktlu15hr+e6pR0ZO6X9I4LWCo6i mI8gpfA9IzRCnS7rfun2r6dZtrZdkBwT4g6ro1VOCO10ky1BJ2DqXicY2taSkHWzhEYc tXYftMocbYP7EN2QB+FBfdNziCXNimUIUI8zYIX/9TL5pvjN4FkcNxCQgnlGz6FCMv66 D2BibSGCafSfGj4yYb0tODuc3lWYsiZjfj7RLcNm4VGVLWYaLgRcTTCxh5pr6S4FL+4m TbUZZuDqUralxivWZydq+2Knhoj/520cHrH63BIAkwdunauvfFOtlaDM3nKPFycaS+TE jtgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762966798; x=1763571598; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9UBroaIpNSaiJuWFrz+qWW2HM0uYdQr3mWyR9bfJIIM=; b=rPxwanPSU/x4e1TLllVd6nnC8S7f4EsAukN0mOxb0XF+RIvSuCHS2UJBCZGHdZHhcT J5f7nQgx+7G/Ua5cUnhAOUnAWKwcPPEX+PevcCWZviOEWCst/kgF3RSVU91mogoRnlut rsxIx733kv7HplVzmZDbKYmNr3bJWB+IHsI2ny3cgEsxXMLRXgmOAck2c7/8QtnSdquu FEtnEePnutlwVkBzW+gDDUqsFKKsUulbb8U5qEU8hH801s0Z5UBzra6GqZuKpJddlAeF rfWS4FCm35hhOUh0VWkD6W10ZWTiZuWdww/+C0zStAsItKtSvtyBr59EnMBSFuSlLtbI JQzQ== X-Forwarded-Encrypted: i=1; AJvYcCWhr61+FRWDe0byNpWbBMqPgEfJFCpYK3dIuQLVArfoiHcAC4yDQ+jMrW7ztXuST6WXMDpTC5h2Sgha@vger.kernel.org X-Gm-Message-State: AOJu0Ywp9eWx5A2/XenVhUuU8kaGRrq+RNAnfFJFRbnnNLt9gwXabCP7 EBvgkR6HvcwbHB6k0ht1yzjfvexk/ZG3fHY1pnllCptiCd07MfVl6QV2i+QOWULxIGo= X-Gm-Gg: ASbGncskxLcCRYPgEvsxAs/A613TMRkoicv9GhcY/Q5Fr6I2yWbagLvFf3BhKgKDft1 XtFEZmazyyPYDvWzLXF2Gg8BT17X1+b2yq18emOrXHeWwRWierjDZlbb6rfxbwprn3E7P0T1BTz PHfZEtEyIjfVw0e0cwwGYew4bil39j4U9FMv7f+xehnnQLe5K0GWWwU1XRt2EmrCWsYnDPbubbO bwvzTzOAZbADI0YekQAnRySkXS0y0FGLmLArIpvSCmMAzbiksZCW1h+w3DXfoEM2RXEyv6HX/Wj dYt0t5IQ4JG/INub9cj6kgxdUS/pbgmVBjgQ+zuVcrxIqYqA40XLRKab6MY2MtBIlRTtllW4LAv vwlV4TQtc5KS+1581iNTV8mReLi/21Q1Zv/2BSN0t6gUUVmwNGE4YxM5nh53Q+7LisnmGmtvM14 RDtSJvj00KdXeyp29HHaoGnes7Dl0yveKCFcD5KUkFLg7qouRvqg== X-Google-Smtp-Source: AGHT+IGjGiA68SQxE2DOheehH23MBaQy65p8WqlrKArkfS9SuLVcwJ48eTHV9RHhY2eyZHq3Z4deyQ== X-Received: by 2002:a05:6808:3198:b0:442:2ce:46cf with SMTP id 5614622812f47-4507456e715mr1828413b6e.34.1762966797983; Wed, 12 Nov 2025 08:59:57 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:d404:301b:b985:c499? ([2600:8803:e7e4:500:d404:301b:b985:c499]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3e41f2583casm10124611fac.23.2025.11.12.08.59.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Nov 2025 08:59:57 -0800 (PST) Message-ID: <0e59d92f-7b3c-4ff6-b3ad-7fae2ded9b77@baylibre.com> Date: Wed, 12 Nov 2025 10:59:56 -0600 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] spi: axi-spi-engine: support SPI_MULTI_BUS_MODE_STRIPE To: Marcelo Schmitt Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcelo Schmitt , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Jonathan Cameron , Andy Shevchenko , Sean Anderson , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org References: <20251107-spi-add-multi-bus-support-v2-0-8a92693314d9@baylibre.com> <20251107-spi-add-multi-bus-support-v2-4-8a92693314d9@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/11/25 9:12 AM, Marcelo Schmitt wrote: > Hi David, > > The updates to spi-engine driver look good. > Only one comment about what happens if we have conflicting bus modes for the > offload case. Just to check I'm getting how this is working. > ... >> @@ -284,6 +316,24 @@ static int spi_engine_precompile_message(struct spi_message *msg) >> min_bits_per_word = min(min_bits_per_word, xfer->bits_per_word); >> max_bits_per_word = max(max_bits_per_word, xfer->bits_per_word); >> } >> + >> + if (xfer->rx_buf || xfer->offload_flags & SPI_OFFLOAD_XFER_RX_STREAM || >> + xfer->tx_buf || xfer->offload_flags & SPI_OFFLOAD_XFER_TX_STREAM) { >> + switch (xfer->multi_bus_mode) { >> + case SPI_MULTI_BUS_MODE_SINGLE: >> + case SPI_MULTI_BUS_MODE_STRIPE: >> + break; >> + default: >> + /* Other modes, like mirror not supported */ >> + return -EINVAL; >> + } >> + >> + /* If all xfers have the same multi-bus mode, we can optimize. */ >> + if (multi_bus_mode == SPI_ENGINE_MULTI_BUS_MODE_UNKNOWN) >> + multi_bus_mode = xfer->multi_bus_mode; >> + else if (multi_bus_mode != xfer->multi_bus_mode) >> + multi_bus_mode = SPI_ENGINE_MULTI_BUS_MODE_CONFLICTING; > > Here we check all xfers have the same multi-bus mode and keep the mode that has > been set. Otherwise, we set this conflicting mode and the intent is to generate > SDI and SDO mask commands on demand on spi_engine_precompile_message(). OTOH, s/spi_engine_precompile_message/spi_engine_compile_message/ Probably just a typo, but just to be clear, the "on demand" bit happens in the compile function rather than precompile. > if all xfers have the same multi-bus mode, we can add just one pair of SDI/SDO > mask commands in spi_engine_trigger_enable() and one pair latter in > spi_engine_trigger_disable(). I guess this is the optimization mentioned in the > comment. > Your understanding is correct.