[PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties
@ 2023-04-16 15:13 Krzysztof Kozlowski
  2023-04-16 15:13 ` [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-16 15:13 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Drop incorrect and unused serial properties - address/size-cells and
reg-names:

  sa8155p-adp.dtb: geniqup@ac0000: serial@a84000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'reg-names' were unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 27dcda0d4288..3846f5e0f656 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1362,14 +1362,11 @@ spi9: spi@a84000 {
 			uart9: serial@a84000 {
 				compatible = "qcom,geni-uart";
 				reg = <0x0 0x00a84000 0x0 0x4000>;
-				reg-names = "se";
 				clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>;
 				clock-names = "se";
 				pinctrl-0 = <&qup_uart9_default>;
 				pinctrl-names = "default";
 				interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
-				#address-cells = <1>;
-				#size-cells = <0>;
 				status = "disabled";
 			};
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback
  2023-04-16 15:13 [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties Krzysztof Kozlowski
@ 2023-04-16 15:13 ` Krzysztof Kozlowski
  2023-04-17  7:16   ` Konrad Dybcio
  2023-04-16 15:13 ` [PATCH 3/4] arm64: dts: qcom: sm8150: drop snps,dw-pcie fallback compatible Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-16 15:13 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Since commit 6c84bbd103d8 ("dt-bindings: arm-smmu: Add generic
qcom,smmu-500 bindings") the SMMU is supposed to use qcom,smmu-500
compatible fallback:

  ['qcom,sm8150-smmu-500', 'qcom,adreno-smmu', 'qcom,smmu-500', 'arm,mmu-500'] is too long

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 3846f5e0f656..024b3c79ea11 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -3983,7 +3983,7 @@ spmi_bus: spmi@c440000 {
 		};
 
 		apps_smmu: iommu@15000000 {
-			compatible = "qcom,sm8150-smmu-500", "arm,mmu-500";
+			compatible = "qcom,sm8150-smmu-500", "qcom,adreno-smmu", "arm,mmu-500";
 			reg = <0 0x15000000 0 0x100000>;
 			#iommu-cells = <2>;
 			#global-interrupts = <1>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback
  2023-04-16 15:13 ` [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback Krzysztof Kozlowski
@ 2023-04-17  7:16   ` Konrad Dybcio
  2023-04-17  7:57     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2023-04-17  7:16 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel



On 16.04.2023 17:13, Krzysztof Kozlowski wrote:
> Since commit 6c84bbd103d8 ("dt-bindings: arm-smmu: Add generic
> qcom,smmu-500 bindings") the SMMU is supposed to use qcom,smmu-500
> compatible fallback:
> 
>   ['qcom,sm8150-smmu-500', 'qcom,adreno-smmu', 'qcom,smmu-500', 'arm,mmu-500'] is too long
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 3846f5e0f656..024b3c79ea11 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3983,7 +3983,7 @@ spmi_bus: spmi@c440000 {
>  		};
>  
>  		apps_smmu: iommu@15000000 {
Are you..

> -			compatible = "qcom,sm8150-smmu-500", "arm,mmu-500";
> +			compatible = "qcom,sm8150-smmu-500",

"qcom,adreno-smmu", "arm,mmu-500";
..sure about that?

Konrad
>  			reg = <0 0x15000000 0 0x100000>;
>  			#iommu-cells = <2>;
>  			#global-interrupts = <1>;

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback
  2023-04-17  7:16   ` Konrad Dybcio
@ 2023-04-17  7:57     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-17  7:57 UTC (permalink / raw)
  To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel

On 17/04/2023 09:16, Konrad Dybcio wrote:
> 
> 
> On 16.04.2023 17:13, Krzysztof Kozlowski wrote:
>> Since commit 6c84bbd103d8 ("dt-bindings: arm-smmu: Add generic
>> qcom,smmu-500 bindings") the SMMU is supposed to use qcom,smmu-500
>> compatible fallback:
>>
>>   ['qcom,sm8150-smmu-500', 'qcom,adreno-smmu', 'qcom,smmu-500', 'arm,mmu-500'] is too long
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> index 3846f5e0f656..024b3c79ea11 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> @@ -3983,7 +3983,7 @@ spmi_bus: spmi@c440000 {
>>  		};
>>  
>>  		apps_smmu: iommu@15000000 {
> Are you..
> 
>> -			compatible = "qcom,sm8150-smmu-500", "arm,mmu-500";
>> +			compatible = "qcom,sm8150-smmu-500",
> 
> "qcom,adreno-smmu", "arm,mmu-500";
> ..sure about that?

I supposed to paste here different one... thanks for spotting it.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 3/4] arm64: dts: qcom: sm8150: drop snps,dw-pcie fallback compatible
  2023-04-16 15:13 [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties Krzysztof Kozlowski
  2023-04-16 15:13 ` [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback Krzysztof Kozlowski
@ 2023-04-16 15:13 ` Krzysztof Kozlowski
  2023-04-17  7:16   ` Konrad Dybcio
  2023-04-16 15:13 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: correct GIC child node name Krzysztof Kozlowski
  2023-04-17  7:15 ` [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties Konrad Dybcio
  3 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-16 15:13 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Qualcomm PCI express root complex does not use snps,dw-pcie fallback:

  ['qcom,pcie-sm8150', 'snps,dw-pcie'] is too long

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 024b3c79ea11..1d22eca9cbde 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1823,7 +1823,7 @@ dma@10a2000 {
 		};
 
 		pcie0: pci@1c00000 {
-			compatible = "qcom,pcie-sm8150", "snps,dw-pcie";
+			compatible = "qcom,pcie-sm8150";
 			reg = <0 0x01c00000 0 0x3000>,
 			      <0 0x60000000 0 0xf1d>,
 			      <0 0x60000f20 0 0xa8>,
@@ -1918,7 +1918,7 @@ pcie0_lane: phy@1c06200 {
 		};
 
 		pcie1: pci@1c08000 {
-			compatible = "qcom,pcie-sm8150", "snps,dw-pcie";
+			compatible = "qcom,pcie-sm8150";
 			reg = <0 0x01c08000 0 0x3000>,
 			      <0 0x40000000 0 0xf1d>,
 			      <0 0x40000f20 0 0xa8>,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/4] arm64: dts: qcom: sm8150: drop snps,dw-pcie fallback compatible
  2023-04-16 15:13 ` [PATCH 3/4] arm64: dts: qcom: sm8150: drop snps,dw-pcie fallback compatible Krzysztof Kozlowski
@ 2023-04-17  7:16   ` Konrad Dybcio
  0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2023-04-17  7:16 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel



On 16.04.2023 17:13, Krzysztof Kozlowski wrote:
> Qualcomm PCI express root complex does not use snps,dw-pcie fallback:
> 
>   ['qcom,pcie-sm8150', 'snps,dw-pcie'] is too long
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 024b3c79ea11..1d22eca9cbde 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -1823,7 +1823,7 @@ dma@10a2000 {
>  		};
>  
>  		pcie0: pci@1c00000 {
> -			compatible = "qcom,pcie-sm8150", "snps,dw-pcie";
> +			compatible = "qcom,pcie-sm8150";
>  			reg = <0 0x01c00000 0 0x3000>,
>  			      <0 0x60000000 0 0xf1d>,
>  			      <0 0x60000f20 0 0xa8>,
> @@ -1918,7 +1918,7 @@ pcie0_lane: phy@1c06200 {
>  		};
>  
>  		pcie1: pci@1c08000 {
> -			compatible = "qcom,pcie-sm8150", "snps,dw-pcie";
> +			compatible = "qcom,pcie-sm8150";
>  			reg = <0 0x01c08000 0 0x3000>,
>  			      <0 0x40000000 0 0xf1d>,
>  			      <0 0x40000f20 0 0xa8>,

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 4/4] arm64: dts: qcom: sc8280xp: correct GIC child node name
  2023-04-16 15:13 [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties Krzysztof Kozlowski
  2023-04-16 15:13 ` [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback Krzysztof Kozlowski
  2023-04-16 15:13 ` [PATCH 3/4] arm64: dts: qcom: sm8150: drop snps,dw-pcie fallback compatible Krzysztof Kozlowski
@ 2023-04-16 15:13 ` Krzysztof Kozlowski
  2023-04-17  7:17   ` Konrad Dybcio
  2023-04-17  7:15 ` [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties Konrad Dybcio
  3 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-16 15:13 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

GIC child node is supposed to be named msi-controller:

  sa8295p-adp.dtb: interrupt-controller@17a00000: gic-its@17a40000: False schema does not allow

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 6d3780a75024..5532bf8af211 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -3907,7 +3907,7 @@ intc: interrupt-controller@17a00000 {
 			#size-cells = <2>;
 			ranges;
 
-			gic-its@17a40000 {
+			msi-controller@17a40000 {
 				compatible = "arm,gic-v3-its";
 				reg = <0 0x17a40000 0 0x20000>;
 				msi-controller;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp: correct GIC child node name
  2023-04-16 15:13 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: correct GIC child node name Krzysztof Kozlowski
@ 2023-04-17  7:17   ` Konrad Dybcio
  0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2023-04-17  7:17 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel



On 16.04.2023 17:13, Krzysztof Kozlowski wrote:
> GIC child node is supposed to be named msi-controller:
> 
>   sa8295p-adp.dtb: interrupt-controller@17a00000: gic-its@17a40000: False schema does not allow
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 6d3780a75024..5532bf8af211 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -3907,7 +3907,7 @@ intc: interrupt-controller@17a00000 {
>  			#size-cells = <2>;
>  			ranges;
>  
> -			gic-its@17a40000 {
> +			msi-controller@17a40000 {
>  				compatible = "arm,gic-v3-its";
>  				reg = <0 0x17a40000 0 0x20000>;
>  				msi-controller;

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties
  2023-04-16 15:13 [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2023-04-16 15:13 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: correct GIC child node name Krzysztof Kozlowski
@ 2023-04-17  7:15 ` Konrad Dybcio
  3 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2023-04-17  7:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel



On 16.04.2023 17:13, Krzysztof Kozlowski wrote:
> Drop incorrect and unused serial properties - address/size-cells and
> reg-names:
> 
>   sa8155p-adp.dtb: geniqup@ac0000: serial@a84000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'reg-names' were unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 27dcda0d4288..3846f5e0f656 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -1362,14 +1362,11 @@ spi9: spi@a84000 {
>  			uart9: serial@a84000 {
>  				compatible = "qcom,geni-uart";
>  				reg = <0x0 0x00a84000 0x0 0x4000>;
> -				reg-names = "se";
>  				clocks = <&gcc GCC_QUPV3_WRAP1_S1_CLK>;
>  				clock-names = "se";
>  				pinctrl-0 = <&qup_uart9_default>;
>  				pinctrl-names = "default";
>  				interrupts = <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>;
> -				#address-cells = <1>;
> -				#size-cells = <0>;
>  				status = "disabled";
>  			};
>  

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-04-17  7:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-16 15:13 [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties Krzysztof Kozlowski
2023-04-16 15:13 ` [PATCH 2/4] arm64: dts: qcom: sm8150: add missing qcom,smmu-500 fallback Krzysztof Kozlowski
2023-04-17  7:16   ` Konrad Dybcio
2023-04-17  7:57     ` Krzysztof Kozlowski
2023-04-16 15:13 ` [PATCH 3/4] arm64: dts: qcom: sm8150: drop snps,dw-pcie fallback compatible Krzysztof Kozlowski
2023-04-17  7:16   ` Konrad Dybcio
2023-04-16 15:13 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: correct GIC child node name Krzysztof Kozlowski
2023-04-17  7:17   ` Konrad Dybcio
2023-04-17  7:15 ` [PATCH 1/4] arm64: dts: qcom: sm8150: drop incorrect serial properties Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).