* [PATCH 0/3] ARM: dts: st: dts fixes in stih418-b2264.dts
@ 2023-07-02 16:19 Alain Volmat
2023-07-02 16:19 ` [PATCH 1/3] ARM: dts: st: correct serial alias " Alain Volmat
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Alain Volmat @ 2023-07-02 16:19 UTC (permalink / raw)
To: Patrice Chotard, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: avolmat, linux-arm-kernel, devicetree, linux-kernel
Correction of two dts warnings and led state in stih418-b2264.dts
Alain Volmat (3):
ARM: dts: st: correct serial alias in stih418-b2264.dts
ARM: dts: st: move leds out of soc in stih418-b2264.dts
ARM: dts: st: correct led level in stih418-b2264.dts
arch/arm/boot/dts/st/stih418-b2264.dts | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/3] ARM: dts: st: correct serial alias in stih418-b2264.dts
2023-07-02 16:19 [PATCH 0/3] ARM: dts: st: dts fixes in stih418-b2264.dts Alain Volmat
@ 2023-07-02 16:19 ` Alain Volmat
2023-08-16 7:07 ` Patrice CHOTARD
2023-08-16 7:16 ` Patrice CHOTARD
2023-07-02 16:19 ` [PATCH 2/3] ARM: dts: st: move leds out of soc " Alain Volmat
2023-07-02 16:19 ` [PATCH 3/3] ARM: dts: st: correct led level " Alain Volmat
2 siblings, 2 replies; 10+ messages in thread
From: Alain Volmat @ 2023-07-02 16:19 UTC (permalink / raw)
To: Patrice Chotard, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: avolmat, linux-arm-kernel, devicetree, linux-kernel
Aliases should only contain lowercase, digits or - hence
correct the alias for the serial from ttyAS0 into serial0
as already done for the other boards.
Signed-off-by: Alain Volmat <avolmat@me.com>
---
arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
index fc32a03073b6..f496ca28850d 100644
--- a/arch/arm/boot/dts/st/stih418-b2264.dts
+++ b/arch/arm/boot/dts/st/stih418-b2264.dts
@@ -69,7 +69,7 @@ opp04 {
};
aliases {
- ttyAS0 = &sbc_serial0;
+ serial0 = &sbc_serial0;
ethernet0 = ðernet0;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/3] ARM: dts: st: correct serial alias in stih418-b2264.dts
2023-07-02 16:19 ` [PATCH 1/3] ARM: dts: st: correct serial alias " Alain Volmat
@ 2023-08-16 7:07 ` Patrice CHOTARD
2023-08-16 7:16 ` Patrice CHOTARD
1 sibling, 0 replies; 10+ messages in thread
From: Patrice CHOTARD @ 2023-08-16 7:07 UTC (permalink / raw)
To: Alain Volmat, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel
On 7/2/23 18:19, Alain Volmat wrote:
> Aliases should only contain lowercase, digits or - hence
> correct the alias for the serial from ttyAS0 into serial0
> as already done for the other boards.
>
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
> arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
> index fc32a03073b6..f496ca28850d 100644
> --- a/arch/arm/boot/dts/st/stih418-b2264.dts
> +++ b/arch/arm/boot/dts/st/stih418-b2264.dts
> @@ -69,7 +69,7 @@ opp04 {
> };
>
> aliases {
> - ttyAS0 = &sbc_serial0;
> + serial0 = &sbc_serial0;
> ethernet0 = ðernet0;
> };
>
Acked-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/3] ARM: dts: st: correct serial alias in stih418-b2264.dts
2023-07-02 16:19 ` [PATCH 1/3] ARM: dts: st: correct serial alias " Alain Volmat
2023-08-16 7:07 ` Patrice CHOTARD
@ 2023-08-16 7:16 ` Patrice CHOTARD
1 sibling, 0 replies; 10+ messages in thread
From: Patrice CHOTARD @ 2023-08-16 7:16 UTC (permalink / raw)
To: Alain Volmat, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel
On 7/2/23 18:19, Alain Volmat wrote:
> Aliases should only contain lowercase, digits or - hence
> correct the alias for the serial from ttyAS0 into serial0
> as already done for the other boards.
>
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
> arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
> index fc32a03073b6..f496ca28850d 100644
> --- a/arch/arm/boot/dts/st/stih418-b2264.dts
> +++ b/arch/arm/boot/dts/st/stih418-b2264.dts
> @@ -69,7 +69,7 @@ opp04 {
> };
>
> aliases {
> - ttyAS0 = &sbc_serial0;
> + serial0 = &sbc_serial0;
> ethernet0 = ðernet0;
> };
>
Applied on sti-next
Thanks
Patrice
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] ARM: dts: st: move leds out of soc in stih418-b2264.dts
2023-07-02 16:19 [PATCH 0/3] ARM: dts: st: dts fixes in stih418-b2264.dts Alain Volmat
2023-07-02 16:19 ` [PATCH 1/3] ARM: dts: st: correct serial alias " Alain Volmat
@ 2023-07-02 16:19 ` Alain Volmat
2023-08-16 7:08 ` Patrice CHOTARD
2023-08-16 7:16 ` Patrice CHOTARD
2023-07-02 16:19 ` [PATCH 3/3] ARM: dts: st: correct led level " Alain Volmat
2 siblings, 2 replies; 10+ messages in thread
From: Alain Volmat @ 2023-07-02 16:19 UTC (permalink / raw)
To: Patrice Chotard, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: avolmat, linux-arm-kernel, devicetree, linux-kernel
Move the leds node out of the soc section
and correct the following warning:
Warning (simple_bus_reg): /soc/leds: missing or empty reg/ranges property
Signed-off-by: Alain Volmat <avolmat@me.com>
---
arch/arm/boot/dts/st/stih418-b2264.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
index f496ca28850d..d4874282cfba 100644
--- a/arch/arm/boot/dts/st/stih418-b2264.dts
+++ b/arch/arm/boot/dts/st/stih418-b2264.dts
@@ -73,15 +73,15 @@ aliases {
ethernet0 = ðernet0;
};
- soc {
- leds {
- compatible = "gpio-leds";
- led-green {
- gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
- default-state = "off";
- };
+ leds {
+ compatible = "gpio-leds";
+ led-green {
+ gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
};
+ };
+ soc {
pin-controller-sbc@961f080 {
gmac1 {
rgmii1-0 {
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] ARM: dts: st: move leds out of soc in stih418-b2264.dts
2023-07-02 16:19 ` [PATCH 2/3] ARM: dts: st: move leds out of soc " Alain Volmat
@ 2023-08-16 7:08 ` Patrice CHOTARD
2023-08-16 7:16 ` Patrice CHOTARD
1 sibling, 0 replies; 10+ messages in thread
From: Patrice CHOTARD @ 2023-08-16 7:08 UTC (permalink / raw)
To: Alain Volmat, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel
On 7/2/23 18:19, Alain Volmat wrote:
> Move the leds node out of the soc section
> and correct the following warning:
> Warning (simple_bus_reg): /soc/leds: missing or empty reg/ranges property
>
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
> arch/arm/boot/dts/st/stih418-b2264.dts | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
> index f496ca28850d..d4874282cfba 100644
> --- a/arch/arm/boot/dts/st/stih418-b2264.dts
> +++ b/arch/arm/boot/dts/st/stih418-b2264.dts
> @@ -73,15 +73,15 @@ aliases {
> ethernet0 = ðernet0;
> };
>
> - soc {
> - leds {
> - compatible = "gpio-leds";
> - led-green {
> - gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
> - default-state = "off";
> - };
> + leds {
> + compatible = "gpio-leds";
> + led-green {
> + gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> };
> + };
>
> + soc {
> pin-controller-sbc@961f080 {
> gmac1 {
> rgmii1-0 {
Acked-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
PAtrice
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] ARM: dts: st: move leds out of soc in stih418-b2264.dts
2023-07-02 16:19 ` [PATCH 2/3] ARM: dts: st: move leds out of soc " Alain Volmat
2023-08-16 7:08 ` Patrice CHOTARD
@ 2023-08-16 7:16 ` Patrice CHOTARD
2023-08-16 7:16 ` Patrice CHOTARD
1 sibling, 1 reply; 10+ messages in thread
From: Patrice CHOTARD @ 2023-08-16 7:16 UTC (permalink / raw)
To: Alain Volmat, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel
On 7/2/23 18:19, Alain Volmat wrote:
> Move the leds node out of the soc section
> and correct the following warning:
> Warning (simple_bus_reg): /soc/leds: missing or empty reg/ranges property
>
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
> arch/arm/boot/dts/st/stih418-b2264.dts | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
> index f496ca28850d..d4874282cfba 100644
> --- a/arch/arm/boot/dts/st/stih418-b2264.dts
> +++ b/arch/arm/boot/dts/st/stih418-b2264.dts
> @@ -73,15 +73,15 @@ aliases {
> ethernet0 = ðernet0;
> };
>
> - soc {
> - leds {
> - compatible = "gpio-leds";
> - led-green {
> - gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
> - default-state = "off";
> - };
> + leds {
> + compatible = "gpio-leds";
> + led-green {
> + gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> };
> + };
>
> + soc {
> pin-controller-sbc@961f080 {
> gmac1 {
> rgmii1-0 {
Applied on sti-next
Thanks
Patrice
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] ARM: dts: st: move leds out of soc in stih418-b2264.dts
2023-08-16 7:16 ` Patrice CHOTARD
@ 2023-08-16 7:16 ` Patrice CHOTARD
0 siblings, 0 replies; 10+ messages in thread
From: Patrice CHOTARD @ 2023-08-16 7:16 UTC (permalink / raw)
To: Alain Volmat, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel
On 8/16/23 09:16, Patrice CHOTARD wrote:
>
>
> On 7/2/23 18:19, Alain Volmat wrote:
>> Move the leds node out of the soc section
>> and correct the following warning:
>> Warning (simple_bus_reg): /soc/leds: missing or empty reg/ranges property
>>
>> Signed-off-by: Alain Volmat <avolmat@me.com>
>> ---
>> arch/arm/boot/dts/st/stih418-b2264.dts | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
>> index f496ca28850d..d4874282cfba 100644
>> --- a/arch/arm/boot/dts/st/stih418-b2264.dts
>> +++ b/arch/arm/boot/dts/st/stih418-b2264.dts
>> @@ -73,15 +73,15 @@ aliases {
>> ethernet0 = ðernet0;
>> };
>>
>> - soc {
>> - leds {
>> - compatible = "gpio-leds";
>> - led-green {
>> - gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
>> - default-state = "off";
>> - };
>> + leds {
>> + compatible = "gpio-leds";
>> + led-green {
>> + gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
>> + default-state = "off";
>> };
>> + };
>>
>> + soc {
>> pin-controller-sbc@961f080 {
>> gmac1 {
>> rgmii1-0 {
> Applied on sti-next
>
> Thanks
> Patrice
Applied on sti-next
Thanks
Patrice
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] ARM: dts: st: correct led level in stih418-b2264.dts
2023-07-02 16:19 [PATCH 0/3] ARM: dts: st: dts fixes in stih418-b2264.dts Alain Volmat
2023-07-02 16:19 ` [PATCH 1/3] ARM: dts: st: correct serial alias " Alain Volmat
2023-07-02 16:19 ` [PATCH 2/3] ARM: dts: st: move leds out of soc " Alain Volmat
@ 2023-07-02 16:19 ` Alain Volmat
2023-08-16 7:08 ` Patrice CHOTARD
2 siblings, 1 reply; 10+ messages in thread
From: Alain Volmat @ 2023-07-02 16:19 UTC (permalink / raw)
To: Patrice Chotard, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: avolmat, linux-arm-kernel, devicetree, linux-kernel
The state of the green led on the stih418-b2264 is currently
inverted. Correct this by fixing the GPIO active state.
Signed-off-by: Alain Volmat <avolmat@me.com>
---
arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
index d4874282cfba..fdc16e9f5822 100644
--- a/arch/arm/boot/dts/st/stih418-b2264.dts
+++ b/arch/arm/boot/dts/st/stih418-b2264.dts
@@ -76,7 +76,7 @@ aliases {
leds {
compatible = "gpio-leds";
led-green {
- gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
+ gpios = <&pio1 3 GPIO_ACTIVE_LOW>;
default-state = "off";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] ARM: dts: st: correct led level in stih418-b2264.dts
2023-07-02 16:19 ` [PATCH 3/3] ARM: dts: st: correct led level " Alain Volmat
@ 2023-08-16 7:08 ` Patrice CHOTARD
0 siblings, 0 replies; 10+ messages in thread
From: Patrice CHOTARD @ 2023-08-16 7:08 UTC (permalink / raw)
To: Alain Volmat, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel
On 7/2/23 18:19, Alain Volmat wrote:
> The state of the green led on the stih418-b2264 is currently
> inverted. Correct this by fixing the GPIO active state.
>
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
> arch/arm/boot/dts/st/stih418-b2264.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/st/stih418-b2264.dts b/arch/arm/boot/dts/st/stih418-b2264.dts
> index d4874282cfba..fdc16e9f5822 100644
> --- a/arch/arm/boot/dts/st/stih418-b2264.dts
> +++ b/arch/arm/boot/dts/st/stih418-b2264.dts
> @@ -76,7 +76,7 @@ aliases {
> leds {
> compatible = "gpio-leds";
> led-green {
> - gpios = <&pio1 3 GPIO_ACTIVE_HIGH>;
> + gpios = <&pio1 3 GPIO_ACTIVE_LOW>;
> default-state = "off";
> };
> };
Acked-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-08-16 7:17 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-02 16:19 [PATCH 0/3] ARM: dts: st: dts fixes in stih418-b2264.dts Alain Volmat
2023-07-02 16:19 ` [PATCH 1/3] ARM: dts: st: correct serial alias " Alain Volmat
2023-08-16 7:07 ` Patrice CHOTARD
2023-08-16 7:16 ` Patrice CHOTARD
2023-07-02 16:19 ` [PATCH 2/3] ARM: dts: st: move leds out of soc " Alain Volmat
2023-08-16 7:08 ` Patrice CHOTARD
2023-08-16 7:16 ` Patrice CHOTARD
2023-08-16 7:16 ` Patrice CHOTARD
2023-07-02 16:19 ` [PATCH 3/3] ARM: dts: st: correct led level " Alain Volmat
2023-08-16 7:08 ` Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).