From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
"nathan@kernel.org" <nathan@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"CK Hu (胡俊光)" <ck.hu@mediatek.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>,
"ndesaulniers@google.com" <ndesaulniers@google.com>
Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195
Date: Thu, 16 Mar 2023 12:36:57 +0100 [thread overview]
Message-ID: <0ebf187d-972e-4228-d8a0-8c0ce02f642d@linaro.org> (raw)
In-Reply-To: <e5ceec9e-d51b-2aeb-1db7-b79b151bd44c@collabora.com>
On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:
> Hello Krzysztof, Nancy,
>
> Since this series has reached v29, can we please reach an agreement on the bindings
> to use here, so that we can get this finally upstreamed?
>
> I will put some examples to try to get this issue resolved.
>
> ### Example 1: Constrain the number of GCE entries to *seven* array elements (7x4!)
>
> mediatek,gce-client-reg:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> maxItems: 1
> description: The register of display function block to be set by gce.
> There are 4 arguments in this property, gce node, subsys id, offset and
> register size. The subsys id is defined in the gce header of each chips
> include/dt-bindings/gce/<chip>-gce.h, mapping to the register of display
> function block.
> items:
> minItems: 28
> maxItems: 28
> items: <----- this block doesn't seem to get checked :\
> - description: phandle of GCE
> - description: GCE subsys id
> - description: register offset
> - description: register size
This is what we would like to have but it requires exception in
dtschema. Thus:
>
>
> ### Example 2: Don't care about constraining the number of arguments
>
> mediatek,gce-client-reg:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> maxItems: 1
> description: The register of display function block to be set by gce.
> There are 4 arguments in this property, gce node, subsys id, offset and
> register size. The subsys id is defined in the gce header of each chips
> include/dt-bindings/gce/<chip>-gce.h, mapping to the register of display
> function block.
use this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-16 11:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221227081011.6426-1-nancy.lin@mediatek.com>
2023-02-02 9:38 ` [PATCH v29 0/7] Add MediaTek SoC DRM (vdosys1) support for mt8195 AngeloGioacchino Del Regno
[not found] ` <20221227081011.6426-4-nancy.lin@mediatek.com>
2023-02-17 16:47 ` [PATCH v29 3/7] drm/mediatek: add ovl_adaptor support for MT8195 Guillaume Ranquet
[not found] ` <20221227081011.6426-5-nancy.lin@mediatek.com>
2023-02-17 16:51 ` [PATCH v29 4/7] drm/mediatek: add dma dev get function Guillaume Ranquet
[not found] ` <20221227081011.6426-2-nancy.lin@mediatek.com>
2023-03-15 3:45 ` [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195 Nancy Lin (林欣螢)
2023-03-15 7:16 ` Krzysztof Kozlowski
2023-03-16 6:19 ` Nancy Lin (林欣螢)
2023-03-16 6:31 ` Krzysztof Kozlowski
2023-03-16 9:53 ` AngeloGioacchino Del Regno
2023-03-16 11:36 ` Krzysztof Kozlowski [this message]
2023-03-17 7:55 ` Nancy Lin (林欣螢)
2023-03-17 9:03 ` Krzysztof Kozlowski
2023-03-17 9:37 ` AngeloGioacchino Del Regno
2023-03-17 9:52 ` Nancy Lin (林欣螢)
2023-03-17 9:58 ` AngeloGioacchino Del Regno
2023-03-21 5:33 ` Nancy Lin (林欣螢)
2023-03-21 9:54 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ebf187d-972e-4228-d8a0-8c0ce02f642d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Nancy.Lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Singo.Chang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).