From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E8BC433FE for ; Mon, 14 Nov 2022 07:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236011AbiKNHsW (ORCPT ); Mon, 14 Nov 2022 02:48:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235249AbiKNHsV (ORCPT ); Mon, 14 Nov 2022 02:48:21 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FE7110C1 for ; Sun, 13 Nov 2022 23:48:20 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id c1so17935215lfi.7 for ; Sun, 13 Nov 2022 23:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RtaXBhnGo8MVscIrQnKGheYkcw3Kx7+UsbUghToyCVI=; b=SMH/wDR0ipSJQ9BUzSRMG2RWykZI8v94NQ6rQnIPL3+Oq+ZKPi/veswxkIv+yEMztD 2QmI0HH5GldekYzi2aGpmm2oQ8bYqWvWukggo1oah2jteXry9sKr9hhszaCUNhe7JaZB wtQ2IWfLRze8qnIqqOUGV270budQ2QuruVB/5jdcg93GlDmIcmNOQ93VZ2dwFWHN/cNM JLIE+7LyCVT068CkPRhtyAPK3R1eNs1lvDXpLB6AOz3Qp4VaXNsJRRW7UsnXmx6847Yu TDymNZOPJZcegB76FHBGkSFkdBDkb9j47VZng4bShYGV0+c1jYTr0NOza+VNBooBqfle LnBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RtaXBhnGo8MVscIrQnKGheYkcw3Kx7+UsbUghToyCVI=; b=R2b5zEWTpEZl/F/nSLtHLtudNVT8KSxCbW2TUCOykNn+xsx0y4EEpfH3WkcJoe5Xtm A34MCkh2IC+8H4af9QHj3nCxfUsEt9qcdTKcmW9noLlodGuJkLB2L864hk8LSrtvNDKz uCdUR7Dqi7KzEPOarVH8F2go554H3EYVwjxSfN3XN6LPvyYpoAbc5TXPjzyw9H+PjhD4 e/2GkNfJtbT81qd58kRtQYZKN7flj4BgiLExam68W3Z176119FLZ5HJNBtkQocK2SNXA G9Q6yp6MOgR2gyBCECN+tHi+RsyTu+LErdOgBRveYudcj2enywF7P3DB8xqodeVey1cc DnFw== X-Gm-Message-State: ANoB5pmRWhbNY9f4YJ3MDqI8Ts5UjNfe3GN4RIa54MWQGCtKNKs6DT89 VzrOYsfekggH7gQHS/abPitauQ== X-Google-Smtp-Source: AA0mqf4L855tMQ/hmtg1Tuny5MoKVDR9pzpMX2tlC4Cl8NJCd/Q5ZQSx1O0gm5QI6BjibY6zuXXH2w== X-Received: by 2002:a05:6512:6d5:b0:4a9:6659:40d5 with SMTP id u21-20020a05651206d500b004a9665940d5mr4232367lff.516.1668412098837; Sun, 13 Nov 2022 23:48:18 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id k20-20020a2eb754000000b0026b2094f6fcsm1899097ljo.73.2022.11.13.23.48.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Nov 2022 23:48:18 -0800 (PST) Message-ID: <0ee5db9e-d80c-947d-73d6-6214e9299b23@linaro.org> Date: Mon, 14 Nov 2022 08:48:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 00/10] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 Content-Language: en-US To: Srinivas Kandagatla , Banajit Goswami , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Lai , Srinivasa Rao Mandadapu References: <20221111113547.100442-1-krzysztof.kozlowski@linaro.org> <06da072c-8cf0-8181-3c32-4592fe41f9c2@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <06da072c-8cf0-8181-3c32-4592fe41f9c2@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/11/2022 17:15, Srinivas Kandagatla wrote: > > > On 11/11/2022 11:35, Krzysztof Kozlowski wrote: >> Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought >> some changes to APR/GPR services bindings. These bindings are part of >> qcom,apr.yaml: >> >> apr-or-gpr-device-node <- qcom,apr.yaml >> apr-gpr-service@[0-9] <- qcom,apr.yaml >> service-specific-components <- /schemas/sound/qcom,q6*.yaml >> >> The schema for services (apr-gpr-service@[0-9]) already grows considerably and >> is still quite not specific. It allows several incorrect combinations, like >> adding a clock-controller to a APM device. Restricting it would complicate the >> schema even more. Bringing new support for sound on Qualcomm SM8450 and >> SC8280XP SoC would grow it as well. > > Why would this grow? All the dsp services are static and they will not > change per SoC unless there is a total firmware change in DSP. They grow now with SM8450 which requires changes there. Otherwise DTS does not pass with current bindings. The bindings before my fixing in 2022 were really incomplete. Now they are complete, but: 1. Not for SM8450 - this will bring new things, 2. Very unspecific as they allow multiple invalid configurations. > >> >> Refactor the bindings before extending them for Qualcomm SM8450 SoC. > > I dont understand this bit, what is SoC audio support to do with DSP > bindings. DSP bindings should be totally independent of this. APR/GPR bindings are for SoC audio, so while adding SoC audio the first are affected. If you went through the commits here, you would notice the changes. Best regards, Krzysztof