From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D169AECAAD5 for ; Mon, 5 Sep 2022 09:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236320AbiIEJyS (ORCPT ); Mon, 5 Sep 2022 05:54:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236193AbiIEJyS (ORCPT ); Mon, 5 Sep 2022 05:54:18 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BAF640BD4 for ; Mon, 5 Sep 2022 02:54:16 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id bx38so8640786ljb.10 for ; Mon, 05 Sep 2022 02:54:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=r+dy657YMkCJ/gfS/fhRH4XzHfRep4eVxD4DnOZEHT8=; b=lWot3i8SLnSrIlJAp4JCB91xVjCTgfMa4zcCUiu2aEHGY94lSVKDwAjQYQVz9biqB7 elRS4sIPdxnSy7dNQlmHc9J17++uC0tq4051lArAvOtX7dspfO9rY//k0MRb3wC+J37b pTuH2zZP6eyvIIklmXCozIFMEXPWfli6036TbijXSF4x3OPgixy7LuiX+RugbqGokh+0 oq3lHOML5Gbc2Gjedkdz7NslxP/SQJjY4yNRAOxe9+a+nIMe8wxvUJnlrlDg7NFx+N0T Cm5eLitJVM7ee2S/KBNn5sMz2oEm5xUf9NXaHauwB5squpnnPddXOaBT9WDwo5GfRfoa 2zRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=r+dy657YMkCJ/gfS/fhRH4XzHfRep4eVxD4DnOZEHT8=; b=HbjUN7ZfxIzDh5G/jLXar0an684zLLbSNb+MG+qgnlqzCw1pUOEcP+QIytH7a1NAwN RzpkxAgR1w7UOIB7z5vVmkPoBd7WUAj3QHaLJmA8eK8itIie+cNIPZGvn4GJ4ijPVjAX L7vFBtTcqDyR9nCb1osPj326/rr5ItgQ1hBWM0/+O4vStL74UoXzqnuRnm6OOl4TARlU fSodLq5Pslvvn8jJE/zYZlx4yyatERRdG8HuW5EpBUQxNXthLHgovj5hWA/5ixIJmVAU Aidinbl3bmF9r+PH6KGPiQCt44+ZoDMz/uBb+EwoenUjItDU1OWfk+uNKR8sVGb01Cy9 dUQA== X-Gm-Message-State: ACgBeo205/9iicg1gLtqzZY8OIr6hNMk8YQotnIxqYxagTzoeg9llXwF mcrS5hkaNDBzYcaXP+nf346T4A== X-Google-Smtp-Source: AA6agR7/HEG/A+ngmRd9nq7AHcU1Im92QOkITw927mfLYdhJ2XKYIjA7ht3DAUJ0Iw6mHd+PD5UHDg== X-Received: by 2002:a2e:9084:0:b0:268:f7cd:f753 with SMTP id l4-20020a2e9084000000b00268f7cdf753mr4184365ljg.297.1662371654891; Mon, 05 Sep 2022 02:54:14 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id f4-20020a05651c02c400b00261d66b22a3sm1347863ljo.29.2022.09.05.02.54.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 02:54:14 -0700 (PDT) Message-ID: <0ee691a3-d22e-b685-9d5c-f974ac3afe19@linaro.org> Date: Mon, 5 Sep 2022 11:54:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 3/3] dt-bindings: memory-controllers: gpmc-child: Add binding for wait-pin-polarity Content-Language: en-US To: Roger Quadros , "Niedermayr, BENEDIKT" , "devicetree@vger.kernel.org" , "linux-omap@vger.kernel.org" Cc: "tony@atomide.com" , "robh+dt@kernel.org" References: <20220905071717.1500568-1-benedikt.niedermayr@siemens.com> <20220905071717.1500568-4-benedikt.niedermayr@siemens.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/09/2022 11:21, Roger Quadros wrote: > > > On 05/09/2022 12:14, Niedermayr, BENEDIKT wrote: >> On Mon, 2022-09-05 at 11:56 +0300, Roger Quadros wrote: >>> Hi Benedikt, >>> >>> On 05/09/2022 10:17, B. Niedermayr wrote: >>>> From: Benedikt Niedermayr >>>> >>>> Add a new dt-binding for the wait-pin-polarity property >>>> >>>> Signed-off-by: Benedikt Niedermayr >>>> >>>> --- >>>> .../bindings/memory-controllers/ti,gpmc-child.yaml | 7 >>>> +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/memory- >>>> controllers/ti,gpmc-child.yaml >>>> b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc- >>>> child.yaml >>>> index 6e3995bb1630..7c721206f10b 100644 >>>> --- a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc- >>>> child.yaml >>>> +++ b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc- >>>> child.yaml >>>> @@ -230,6 +230,13 @@ properties: >>>> Wait-pin used by client. Must be less than "gpmc,num- >>>> waitpins". >>>> $ref: /schemas/types.yaml#/definitions/uint32 >>>> >>>> + gpmc,wait-pin-polarity: >>>> + description: | >>>> + Wait-pin polarity used by the clien. It relates to the pin >>>> defined >>> >>> did you mean "client?" >>> Can you please specify what value is for Active Low vs Active High? >> >> Yes, that makes sense. And yes I meant "client". My typo..... >>> >>>> + with "gpmc,wait-pin". >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> >>> Why can't type be boolean? >> >> Of course we can use the boolean there. In that case I should give the >> property a more meaningful name e.g. wait-pin-active-high or wait-pin- >> active-low. >> Since the default behavour of this pin is Active High, >> a bool property "gpmc,wait-pin-active-low" would make more sense for >> backwards compatibility. >> If the property is missing, than the polarity stays on Active High like >> before. >> > > OK, in that case you don't have to clarify the polarity in description. I don't understand (and it is not explained in commit msg), why do you need such property instead of using standard GPIO flags. The driver should use standard GPIO descriptor and standard bindings. If it cannot, this has to be explained. Best regards, Krzysztof