devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Boyd <sboyd@codeaurora.org>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH] of: Document exactly what of_find_node_by_name() puts
Date: Fri, 10 Nov 2017 18:12:44 -0800	[thread overview]
Message-ID: <0ef4b415-801c-cb58-5de1-01bcfba1c778@infradead.org> (raw)
In-Reply-To: <20171111014536.3592-1-sboyd@codeaurora.org>

On 11/10/2017 05:45 PM, Stephen Boyd wrote:
> It isn't clear if this function of_node_put()s the 'from'
> argument, or the node it finds in the search. Clearly indicate
> which variable is touched.
> 
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>  drivers/of/base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 63897531cd75..602c5d65734a 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);>   *	@from:	The node to start searching from or NULL, the node

    *	@from:	The node to start searching from or %NULL; the node

>   *		you pass will not be searched, only the next one
>   *		will; typically, you pass what the previous call

    *		will. Typically, you pass what the previous call

> - *		returned. of_node_put() will be called on it
> + *		returned. of_node_put() will be called on @from.
>   *	@name:	The name string to match against
>   *
>   *	Returns a node pointer with refcount incremented, use
> 


-- 
~Randy

  reply	other threads:[~2017-11-11  2:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-11  1:45 [PATCH] of: Document exactly what of_find_node_by_name() puts Stephen Boyd
2017-11-11  2:12 ` Randy Dunlap [this message]
     [not found]   ` <0ef4b415-801c-cb58-5de1-01bcfba1c778-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-11-17  2:44     ` Stephen Boyd
     [not found]       ` <20171117024404.GV11955-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-17 14:08         ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ef4b415-801c-cb58-5de1-01bcfba1c778@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).