From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92F37480940; Wed, 1 Jul 2026 13:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782912643; cv=none; b=ZHj6DD51P2FCL7E0jXzeCqb3K76fqkZUlWV9vQ24fnSwxsQBfy2iAW/0EANSiyEVf73Cr9eUCeW8xW1zRmWVDvHUlgBpKFnKRY8mqyV5Bz+py0BNztQ0ocpdmYq+Vbtl21L20jbj3y96OrM2aE/nu/umf75kCu1tIf2FCJWMXJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782912643; c=relaxed/simple; bh=ACKFcX9N7dIaG+Xp9egCsw2F8EhMUQOQv371cR+wt7M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KTA04l2NNiN2bUq9SuyPdxgykZ+MO9ena7gp3ASNvbD4U7JnJO4R6ahQjicrCe3Alt/+FaFbiCHR4+b6KN/X3nabaHbRT9riSUEKMWo5bCpKWymJ8ir1bhh9FNsXJsKAA5nmdnblKvZsWBFMNNrYsQJ4kFtqf3IPszuvk9DKuCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=je9UZWT+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="je9UZWT+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 128DC1F000E9; Wed, 1 Jul 2026 13:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782912642; bh=A5ZmUhI4lGBrijj+WNtqGtqeoK5QeoNNW0ruug9fc60=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=je9UZWT+wuT+sTNUvVgqw3NOS4v+DMNpfirm04gvG57bmytGksEKU3th/tPZwfU94 6Cj4IRuaEYe1HzeSNtxJ6cPuTO/D5I8T0aitOjZN6XsbcfCVdJqfcG5ZMvVpC2QfE+ OWDRge7BWt4ZC09PudmO9upREu3p9rg14O0qt7BWszynUI6OqMlmNdESlTifxjMSxo NUsolddCbDzqQmgLE2lU3sh8bvBsLFClwAmrBGshjKRdDgxE+MUFxh6ra6XF6lyhC9 NYdY4tZS4CLRSbV30BimOIwMtKBrC92NBTuoPsJE5QfuODxCBVaFVA3OmNEZtTYWIA gsNPreUi4hjFA== Message-ID: <0f05e07a-57ab-4ae6-8274-c9c496ca60c2@kernel.org> Date: Wed, 1 Jul 2026 15:30:31 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] dt-bindings: arm: coresight-tnoc: Add standalone qcom,coresight-agtnoc compatible To: Konrad Dybcio , Jie Gan Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260701-fix-tracenoc-probe-issue-v4-0-aefab449a470@oss.qualcomm.com> <20260701-fix-tracenoc-probe-issue-v4-1-aefab449a470@oss.qualcomm.com> <20260701-stirring-piculet-of-vastness-a361e5@quoll> <4117c406-0d75-4eb1-842e-1d346b7fbf99@oss.qualcomm.com> <9aa63427-ba41-436d-ab19-a533082d336a@kernel.org> <62ac6887-1551-490b-b42b-2661d7152734@oss.qualcomm.com> <7838f7c3-0f38-4e93-a9c1-88f387e78ca9@oss.qualcomm.com> <12709ff6-bb42-4d3b-9f9d-e327cd8d89cb@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <12709ff6-bb42-4d3b-9f9d-e327cd8d89cb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01/07/2026 15:09, Konrad Dybcio wrote: > On 7/1/26 2:54 PM, Jie Gan wrote: >> >> >> On 7/1/2026 7:02 PM, Konrad Dybcio wrote: >>> On 7/1/26 9:31 AM, Jie Gan wrote: >>>> >>>> >>>> On 7/1/2026 3:26 PM, Krzysztof Kozlowski wrote: >>>>> On 01/07/2026 09:16, Jie Gan wrote: >>>>>> >>>>>> >>>>>> On 7/1/2026 2:57 PM, Krzysztof Kozlowski wrote: >>>>>>> On Wed, Jul 01, 2026 at 09:53:41AM +0800, Jie Gan wrote: >>>>>>>> The TNOC compatible previously only allowed the two-string AMBA form >>>>>>>> "qcom,coresight-tnoc", "arm,primecell", which forces the device onto the >>>>>>>> AMBA bus. >>>>>>>> >>>>>>>> Convert the compatible to a oneOf and add a standalone >>>>>>>> "qcom,coresight-agtnoc" compatible alongside the existing AMBA form. The >>>>>>>> standalone string carries no "arm,primecell" entry, so the device is >>>>>>>> created on the platform bus instead of the AMBA bus. >>> >>> [...] >>> >>>>>> AMBA primecell identification. The purpose of the new compatible is to >>>>>> clearly distinguish this platform-specific case from the standard >>>>>> AMBA-based implementation. Or shall I re-use the existing compatible >>>>>> "qcom,coresight-tnoc" as platform standalone compatible? >>>>>> >>>>>> We already have a similar pattern for the interconnect TraceNoC device, >>>>>> which uses the platform-specific compatible string qcom,coresight-itnoc. >>>>> I do not see there a fake, duplicated compatible for the same device. >>>>> Can you elaborate how is that relevant? >>>> >>>> Will fix it by removing AMBA related description. >>>> >>>> Shall I update the clock name from apb_pclk to apb as a platform device? >>> >>> Why? >> >> For the previous platform devices, we got comments to add the clock-name with "apb" instead of "apb_pclk". >> >> Please check the qcom,coresight-ctcu.yaml and qcom,coresight-itnoc.yaml > > Well, if you need to break the bindings already, might as well on > the grounds of choosing a saner ("clock names shouldn't include _clk") > name.. Not sure if Krzysztof will like it I miss the rationale for doing the change, why exactly this binding should have clocks corrected. Best regards, Krzysztof