From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31666C4332F for ; Mon, 10 Oct 2022 11:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231512AbiJJL1Q (ORCPT ); Mon, 10 Oct 2022 07:27:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbiJJL1P (ORCPT ); Mon, 10 Oct 2022 07:27:15 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95CCF5E576 for ; Mon, 10 Oct 2022 04:27:13 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id mg6so6921733qvb.10 for ; Mon, 10 Oct 2022 04:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=odSCtf43g66m4iDOcahuiv+23dWqctEIwhRpyIp7LRM=; b=vVwRl2+cxrmVghzaCBVUULCU9KLvC31/LWln8VhhDZMNw3L7RaI4QOyk/CNZfvEiDk K3SFX0lHUdIfSRxiuNZ86uDcoVfWW32Uxsu0V0R5+v0zHNOpIPJXcp/IVX8j0vhwDSYj sFrinDihgKoIbwWecHFGqf29GNIWLZ4TlnhErhjurg4wyRB1PLPmEbvHC+mlMaRy/+Vr zXBQnBUhwNOe+pZlc3BaH9eeEf5Ggf0U6mTyTMcdd/d0beIo8t+ZXo1b8OAJRmw6zkCX VzfoZWRMy5rmuvN5xjlP4Uxk4CSheZyGUVFEoRtvNED0rJ9FjEEynQzJOmsBYF58PLn+ NO3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=odSCtf43g66m4iDOcahuiv+23dWqctEIwhRpyIp7LRM=; b=g5IiDcAQU2+HN1P9YUtG8bH2vyOCpW9k9gv2EJwUme9jpNK80Mh+qhLUluzxiFE1ny jv0N6U173CJ/FqD58xEH6T/930IdwgKbyxZ049zrXfCQaK7gmzljgyr1tWkmE6k9OwVS /l43pBWZ/YCnjkNdcpWGE3FvHYOOXZM/dA8qukxRtd4BCnExgJHjWReVPfx1Z8erdezt 9EpgWA1sA3QkmE7WTnL/3nVUi2HxxbFrgJ/eKfFWJpuSjnSfFPibARIJZcKTDeBk7j0a 0G9zjP/jTB9ZSN96RDq9UmTuK3yAx26oPl9SPWfzbTrRrWFOWGfiMSy90dXqfcw2Swxg y/ag== X-Gm-Message-State: ACrzQf0KhmOd+yHZJ116e2wrG0T+zyDVByEWE/LX6yFxeJr0wbV0555p cwyTn41CDCXD498l8gJ+WiX4Gg== X-Google-Smtp-Source: AMsMyM4yb53ZqK0THwHxH5mjARAZ1MjhYrO0IFD3HwvWL7rGl1jjhLngIhfmBWjjPyclz+YTHKodiA== X-Received: by 2002:a05:6214:766:b0:4b3:e83b:6e8a with SMTP id f6-20020a056214076600b004b3e83b6e8amr7403207qvz.53.1665401232727; Mon, 10 Oct 2022 04:27:12 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id de14-20020a05620a370e00b006e07228ed53sm5969368qkb.18.2022.10.10.04.27.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 04:27:11 -0700 (PDT) Message-ID: <0f078a85-056a-c11e-377b-27764a34485d@linaro.org> Date: Mon, 10 Oct 2022 07:24:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 06/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795 Content-Language: en-US To: Yassine Oudjana , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Andy Teng , AngeloGioacchino Del Regno Cc: Yassine Oudjana , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221007125904.55371-1-y.oudjana@protonmail.com> <20221007125904.55371-7-y.oudjana@protonmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221007125904.55371-7-y.oudjana@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/10/2022 08:59, Yassine Oudjana wrote: > From: Yassine Oudjana > > Combine MT6795 pin controller document into MT6779 one. In the > process, replace the current interrupts property description with > the one from the MT6795 document since it makes more sense. Also > amend property descriptions and examples with more detailed > information that was available in the MT6795 document, and replace > the current pinmux node name patterns with ones from it since they > are more common across mediatek pin controller bindings. > > Signed-off-by: Yassine Oudjana > --- > .../pinctrl/mediatek,mt6779-pinctrl.yaml | 94 ++++++-- > .../pinctrl/mediatek,pinctrl-mt6795.yaml | 227 ------------------ > 2 files changed, 77 insertions(+), 244 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > index a2141eb0854e..cada3530dd0a 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > @@ -8,6 +8,7 @@ title: Mediatek MT6779 Pin Controller > > maintainers: > - Andy Teng > + - AngeloGioacchino Del Regno > - Sean Wang > > description: > @@ -18,6 +19,7 @@ properties: > compatible: > enum: > - mediatek,mt6779-pinctrl > + - mediatek,mt6795-pinctrl > - mediatek,mt6797-pinctrl > > reg: > @@ -43,9 +45,10 @@ properties: > interrupt-controller: true > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > description: | > - Specifies the summary IRQ. > + The interrupt outputs to sysirq. I am not sure if description is relevant now for all variants... what is the sysirq? You have two interrupts so both go to one sysirq? > > "#interrupt-cells": > const: 2 > @@ -81,6 +84,30 @@ allOf: > - const: iocfg_lt > - const: iocfg_tl > - const: eint > + > + interrupts: > + items: > + - description: EINT interrupt > + > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt6795-pinctrl > + then: > + properties: > + reg: > + minItems: 2 What's the maxItems? You declared reg and reg-names in top-level properties as accepting anything, therefore you cannot have loose constraints here. > + > + reg-names: > + items: > + - const: base > + - const: eint > + > + interrupts: > + items: > + - description: EINT interrupt > + - description: EINT event_b interrupt Blank line > - if: > properties: > compatible: > @@ -111,32 +138,50 @@ allOf: > - "#interrupt-cells" > > patternProperties: > - '-[0-9]*$': > + '-pins$': > type: object > additionalProperties: false > > patternProperties: > - '-pins*$': > + '^pins': > type: object > description: | > A pinctrl node should contain at least one subnodes representing the > pinctrl groups available on the machine. Each subnode will list the > pins it needs, and how they should be configured, with regard to muxer > - configuration, pullups, drive strength, input enable/disable and input schmitt. > - $ref: "/schemas/pinctrl/pincfg-node.yaml" > + configuration, pullups, drive strength, input enable/disable and > + input schmitt. > + $ref: "pinmux-node.yaml" Drop quotes Why this one is not pincfg-node anymore? All your properties are not valid then? You mix here so many changes it is a bit difficult to understand the concept. > > properties: > pinmux: > description: > - integer array, represents gpio pin number and mux setting. > - Supported pin number and mux varies for different SoCs, and are defined > - as macros in boot/dts/-pinfunc.h directly. > + Integer array, represents gpio pin number and mux setting. > + Supported pin number and mux varies for different SoCs, and are > + defined as macros in dt-bindings/pinctrl/-pinfunc.h > + directly. > > bias-disable: true > > - bias-pull-up: true > - > - bias-pull-down: true > + bias-pull-up: > + oneOf: > + - type: boolean > + - enum: [100, 101, 102, 103] Missing ref > + description: Pull up PUPD/R0/R1 type define value. > + description: | > + For normal pull up type, it is not necessary to specify R1R0 > + values; When pull up type is PUPD/R0/R1, adding R1R0 defines > + will set different resistance values. > + > + bias-pull-down: > + oneOf: > + - type: boolean > + - enum: [100, 101, 102, 103] Missing ref > + description: Pull down PUPD/R0/R1 type define value. > + description: | > + For normal pull down type, it is not necessary to specify R1R0 > + values; When pull down type is PUPD/R0/R1, adding R1R0 defines > + will set different resistance values. > > input-enable: true > > @@ -151,7 +196,7 @@ patternProperties: > input-schmitt-disable: true > > drive-strength: > - enum: [2, 4, 8, 12, 16] > + enum: [2, 4, 6, 8, 10, 12, 14, 16] Now you are missing ref - you do not have a type now, because you removed pincfg-node. Split the merging of different pinctrl bindings and reorganization. The drive strengths are also not valid for the other variant... > > slew-rate: > enum: [0, 1] > @@ -218,8 +263,9 @@ examples: > #interrupt-cells = <2>; > interrupts = ; > > - mmc0_pins_default: mmc0-0 { > - cmd-dat-pins { > + /* GPIOs 167-174, 176-178 set as multifunction MSDC0 */ > + mmc0_pins_default: mmc0-pins { > + pins-cmd-dat { > pinmux = , > , > , > @@ -232,15 +278,29 @@ examples: > input-enable; > mediatek,pull-up-adv = <1>; > }; > - clk-pins { > + pins-clk { > pinmux = ; > mediatek,pull-down-adv = <2>; > }; > - rst-pins { > + pins-rst { > pinmux = ; > mediatek,pull-up-adv = <0>; > }; Best regards, Krzysztof