From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: chiranjeevi.rapolu@intel.com, luca@z3ntu.xyz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi,
mchehab@kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6.1] media: dt-bindings: Add OV5670
Date: Sun, 29 Jan 2023 13:31:01 +0100 [thread overview]
Message-ID: <0f1fb9df-65e7-d779-e725-84ddd8c5bb1e@linaro.org> (raw)
In-Reply-To: <20230129121132.uamuvywdsuah5ivn@uno.localdomain>
On 29/01/2023 13:11, Jacopo Mondi wrote:
> On Sun, Jan 29, 2023 at 12:40:03PM +0100, Krzysztof Kozlowski wrote:
>> On 28/01/2023 12:27, Jacopo Mondi wrote:
>>> Add the bindings documentation for Omnivision OV5670 image sensor.
>>>
>>> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>>> ---
>>> v6->6.1
>>> - Use additionalProperties: false for endpoint properties from
>>> video-interfaces.yaml
>>> - List 'remote-endpoint' among the accepted endpoint properties
>>> now that we use additionalProperties: false
>>
>> b4 diff '20230128112736.8000-1-jacopo.mondi@ideasonboard.com'
>> Could not create fake-am range for lower series v1
>>
>> Can you send patches in a way it does not break out workflows? Why
>> making our review process more difficult?
>
> Because it's a nit on a 10 patches series with no other changes
> requested ?
>
> What is difficult exactly ?
I wrote above what's difficult.
>
> I see several patches in linux-media being sent inline to a previous
> version for small fixes if the only required changed is a nit like
> this one.
If you sent it as separate v7 would be fine, but:
1. Threading is wrong - it's buried in other patch.
2. Version is wrong - you did there changes, not nits. There are no
point versions...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-29 12:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230126165909.121302-1-jacopo.mondi@ideasonboard.com>
2023-01-26 16:59 ` [PATCH v6 1/9] media: dt-bindings: Add OV5670 Jacopo Mondi
2023-01-27 14:19 ` Krzysztof Kozlowski
2023-01-27 18:14 ` Jacopo Mondi
2023-01-27 19:58 ` Krzysztof Kozlowski
2023-01-27 20:38 ` Sakari Ailus
2023-01-27 20:44 ` Krzysztof Kozlowski
2023-01-28 9:58 ` Jacopo Mondi
2023-01-28 10:07 ` Sakari Ailus
2023-01-28 11:03 ` Jacopo Mondi
2023-01-29 11:36 ` Krzysztof Kozlowski
2023-01-28 11:27 ` [PATCH v6.1] " Jacopo Mondi
2023-01-29 11:40 ` Krzysztof Kozlowski
2023-01-29 12:11 ` Jacopo Mondi
2023-01-29 12:31 ` Krzysztof Kozlowski [this message]
2023-01-30 15:58 ` Rob Herring
2023-01-30 16:11 ` Jacopo Mondi
2023-01-29 11:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f1fb9df-65e7-d779-e725-84ddd8c5bb1e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chiranjeevi.rapolu@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).