From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Frank Wunderlich <linux@fw-web.de>,
linux-mediatek@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: Aw: Re: [RFC] arm64: dts: use size of reserved partition for bl2
Date: Mon, 3 Apr 2023 16:04:42 +0200 [thread overview]
Message-ID: <0f43fa98-4fe6-bc9c-ed8d-be7cec0dda42@collabora.com> (raw)
In-Reply-To: <trinity-f48dda5c-6787-4732-978a-a409bbb0a74d-1680530175673@3c-app-gmx-bap35>
Il 03/04/23 15:56, Frank Wunderlich ha scritto:
>> Gesendet: Montag, 03. April 2023 um 14:43 Uhr
>> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
>> Il 03/04/23 12:58, Frank Wunderlich ha scritto:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> To store uncompressed bl2 more space is required than partition is
>>> actually defined.
>>>
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>
>> If this doesn't get changed anymore, I'm fine with it... but a question arises:
>> did you send patches to add your BPI-r3 board(s) to upstream u-boot?
>
> currently i use the rfb dts for r3 in uboot: arch/arm/dts/mt7986a-sd-rfb.dts
>
> this file in upstream uboot has no partitions defined
>
> https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/mt7986a-sd-rfb.dts#L144
>
> but i added them there too and i wrote content by offsets to main device (not to partitions).
>
> https://github.com/frank-w/u-boot/blob/2023-04-bpi/arch/arm/dts/mt7986a-sd-rfb.dts#L154
>
> so yes basicly it needs to be send there too, maybe as additional dts.
>
I strongly encourage you to send this change to u-boot as well as changing the
kernel devicetree... and when you do, you can add a reference to the list and/or
commit @ u-boot on the commit that you'll send here for the kernel... but there's
another question...
...what happens if you run the kernel on a device with an older partition layout?
Does anything break?
I don't think that anything does, since this is read-only anyway, but just to be
sure... :-)
Besides, you have to fix the commit description, but you knew that already.
P.S.: When you post a RFC, giving it the right commit title helps sometimes! :-P
Regards,
Angelo
next prev parent reply other threads:[~2023-04-03 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 10:58 [RFC] arm64: dts: use size of reserved partition for bl2 Frank Wunderlich
2023-04-03 12:43 ` AngeloGioacchino Del Regno
2023-04-03 13:56 ` Aw: " Frank Wunderlich
2023-04-03 14:04 ` AngeloGioacchino Del Regno [this message]
2023-04-03 14:54 ` Aw: " Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f43fa98-4fe6-bc9c-ed8d-be7cec0dda42@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).