From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Abel Vesa <abel.vesa@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v1 2/6] usb: typec: Add Parade PS8833 Type-C Retimer variant
Date: Tue, 1 Apr 2025 07:37:20 +0200 [thread overview]
Message-ID: <0f590400-d50b-4b1f-afb4-6d3ac112d426@linaro.org> (raw)
In-Reply-To: <20250331215720.19692-3-alex.vinarskis@gmail.com>
On 31/03/2025 23:53, Aleksandrs Vinarskis wrote:
> Appears to behave similarly to Parade PS8830. Found on some Qualcomm
> Snapdragon X1 devices, such as Asus Zenbook A14.
>
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---
> drivers/usb/typec/mux/ps883x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/mux/ps883x.c b/drivers/usb/typec/mux/ps883x.c
> index ad59babf7cce..095c36530904 100644
> --- a/drivers/usb/typec/mux/ps883x.c
> +++ b/drivers/usb/typec/mux/ps883x.c
> @@ -447,6 +447,7 @@ static void ps883x_retimer_remove(struct i2c_client *client)
>
> static const struct of_device_id ps883x_retimer_of_table[] = {
> { .compatible = "parade,ps8830" },
> + { .compatible = "parade,ps8833" },
Don't create unnecessary entries for compatible devices. Patch should be
dropped.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-01 5:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 21:53 [PATCH v1 0/6] X1E Asus Zenbook A14 support Aleksandrs Vinarskis
2025-03-31 21:53 ` [PATCH v1 1/6] arm64: dts: qcom: move pcie6a type change from X1P42100 to X1P42100-crd Aleksandrs Vinarskis
2025-04-01 10:19 ` Konrad Dybcio
2025-04-01 15:28 ` Aleksandrs Vinarskis
2025-03-31 21:53 ` [PATCH v1 2/6] usb: typec: Add Parade PS8833 Type-C Retimer variant Aleksandrs Vinarskis
2025-04-01 5:37 ` Krzysztof Kozlowski [this message]
2025-03-31 21:53 ` [PATCH v1 3/6] dt-bindings: usb: Add Parade PS8833 Type-C retimer variant Aleksandrs Vinarskis
2025-04-01 5:36 ` Krzysztof Kozlowski
2025-03-31 21:53 ` [PATCH v1 4/6] dt-bindings: arm: qcom: Add Asus Zenbook A14 Aleksandrs Vinarskis
2025-04-01 5:38 ` Krzysztof Kozlowski
2025-04-01 10:16 ` Aleksandrs Vinarskis
2025-04-01 10:21 ` Konrad Dybcio
2025-04-01 12:56 ` Krzysztof Kozlowski
2025-03-31 21:53 ` [PATCH v1 5/6] firmware: qcom: scm: Allow QSEECOM on " Aleksandrs Vinarskis
2025-03-31 21:53 ` [PATCH v1 6/6] arm64: dts: qcom: Add support for X1-based " Aleksandrs Vinarskis
2025-04-01 15:59 ` Konrad Dybcio
2025-04-01 18:05 ` Aleksandrs Vinarskis
2025-04-01 21:15 ` Konrad Dybcio
2025-04-01 21:50 ` Aleksandrs Vinarskis
2025-04-02 6:30 ` Maud Spierings
2025-04-02 8:36 ` Aleksandrs Vinarskis
2025-04-03 0:06 ` Aleksandrs Vinarskis
2025-04-01 0:52 ` [PATCH v1 0/6] X1E Asus Zenbook A14 support Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f590400-d50b-4b1f-afb4-6d3ac112d426@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=alex.vinarskis@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).