From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B9FC4321E for ; Thu, 10 Nov 2022 13:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229575AbiKJNbj (ORCPT ); Thu, 10 Nov 2022 08:31:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbiKJNbh (ORCPT ); Thu, 10 Nov 2022 08:31:37 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D86D3646F for ; Thu, 10 Nov 2022 05:31:34 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id a29so3215441lfj.9 for ; Thu, 10 Nov 2022 05:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ketLUUnsoyWouN0UzoicqQ1D0NB9EarJManqsfm6JHs=; b=EjoWG9qGZdA+cmM8l/whsRkqiI78AsL7dXW9Xf/o7LX+FJdxLRPybfO0gVPCemmzkr T7tSYRP1qpfy0gXEF3zbqegSztbMZkJI3GFEqLDUUG6XyO6OpU1m/IN4BB1GzVCUGyMW 0ZknYwKnEsBCIgNyHKpUozqwX1hkP5S1MLZqQSnJXQBZ+3XUw8p/23jeTCNDrJDAV9vX uRAd9gYF9CuwNmiK0jqqD/+jPYh7LrkU2jugQEitlXp0Bv+UHAD324Hlw+YKEgCUjGp8 OJI9n2AqdWTmoiZ5g1SnNl+mZTOxjMZ7t1OTFgUhtvzRIi5Ath2VcJsdPNYZdJ7h9vLC esuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ketLUUnsoyWouN0UzoicqQ1D0NB9EarJManqsfm6JHs=; b=bfS6Vcql8Wl3QIeF9kRexr63y+3uVtJS4wdDmrh/59LtWgExioAYsAa5l1LFuEgGMX Jj4ydHYx27W3TzvgkEaYS7BV0tKf2iba2d+SL9lv8Rs/oe2IZu8KHqHG0phCmBxiUOzb JboNJyR+OcZmd+Vi//NWwF6wG8UmXcTUyx1u+HIsS9MfB/MM0212Dz/GOm5SCCco6Ie7 TTp6GiOO2zo39YCu2yYgpthwv/yy9391KLgPABiy81npjhhRlQy4s4nsY5GFJzYwlzWq ElipzwoY25SuemCMSu15MRn72mG76G0WPOXC6GNo7z8f638aQ7xL4H94PCx4Rsje0nZL tBfQ== X-Gm-Message-State: ACrzQf3Gy+6M3TgC/Ha6G/byHWwda6SBnIEPTK08b+tTLBWTfYSsxKAr 1NuLsDgvl3WjnzFXqRiFCVKAMw== X-Google-Smtp-Source: AMsMyM7dOA2ttjDI/ntgk+yGw8ab+rV2SYqP0CO+1QoY+yr6MNKkHeIG5DVm5U7jcfrHOI0lFfjHyA== X-Received: by 2002:a05:6512:1108:b0:4a2:504f:b3f with SMTP id l8-20020a056512110800b004a2504f0b3fmr21697510lfg.169.1668087093172; Thu, 10 Nov 2022 05:31:33 -0800 (PST) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id a21-20020ac25e75000000b004991437990esm2752373lfr.11.2022.11.10.05.31.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 05:31:32 -0800 (PST) Message-ID: <0f7afb71-dc60-59f4-0708-ab54a0f6f4af@linaro.org> Date: Thu, 10 Nov 2022 16:31:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 8/8] arm64: dts: qcom: sm8350-hdk: enable PCIe devices Content-Language: en-GB To: Johan Hovold Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20221110103345.729018-1-dmitry.baryshkov@linaro.org> <20221110103345.729018-9-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/11/2022 13:51, Johan Hovold wrote: > On Thu, Nov 10, 2022 at 01:33:45PM +0300, Dmitry Baryshkov wrote: >> Enable PCIe0 and PCIe1 hosts found on SM8350 HDK board. >> >> Signed-off-by: Dmitry Baryshkov >> --- >> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts >> index 0fcf5bd88fc7..58a9dc7705a5 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts >> @@ -222,6 +222,22 @@ &mpss { >> firmware-name = "qcom/sm8350/modem.mbn"; >> }; >> >> +&pcie0 { >> + status = "okay"; >> +}; >> + >> +&pcie0_phy { >> + status = "okay"; >> +}; > > Looks like the required regulators are missing from the PHY nodes. Ack, nice catch! > > Johan -- With best wishes Dmitry