Re: [PATCH v6 1/5] dt-bindings: mmc: Add dll-presets values for HS400 and HS200 modes

Krzysztof Kozlowski
2025-12-15T12:11:16Z

On 15/12/2025 13:06, Krzysztof Kozlowski wrote:
> On 15/12/2025 13:00, Ram Prakash Gupta wrote:
>> From: Sachin Gupta <quic_sachgupt@quicinc.com>
>>
>> Document the 'dll-presets' property for MMC device tree bindings.
>> The 'dll-presets' property defines the DLL configurations for HS400
>> and HS200 modes.
>>
>> QC SoCs can have 0 to 4 SDHCI instances, and each one may need
>> different tuning.
>>
>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com>
>> Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> index 938be8228d66..a1a16e6e12ce 100644
>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> @@ -140,6 +140,11 @@ properties:
>> $ref: /schemas/types.yaml#/definitions/uint32
>> description: platform specific settings for DLL_CONFIG reg.
>>
>> + qcom,dll-presets:
>> + maxItems: 10
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> + description: platform specific settings for DLL registers.
>
>
> So look at your DTS - this is clearly incomplete now. So obvious. I
> don't understand why you were hiding the DTS change, you just make
> review more difficult.
>
> Anyway, your DTS says you replace some other DLL properties and nothing
> in the binding or commit msg explains that. Neither the reason nor the
> impact.
>

Plus it looks like you are adding some meaning to the entries, judging
by the DTS. DTS suggested something here is e.g. DLL_CONFIG, so that
meaning - including different modes - needs description in the schema in
items.

Best regards,
Krzysztof