From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C868C433F5 for ; Thu, 31 Mar 2022 21:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241747AbiCaVU3 (ORCPT ); Thu, 31 Mar 2022 17:20:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239385AbiCaVU2 (ORCPT ); Thu, 31 Mar 2022 17:20:28 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3BAC2FE5A for ; Thu, 31 Mar 2022 14:18:39 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id a17so746859edm.9 for ; Thu, 31 Mar 2022 14:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=f4Kho3eU3u1mB4X3IpvBq0DquFHheRamfPe/L5a/eBY=; b=msdDdCEbk6eHuShNVAEyMExjilWXLfTG3ohE6btxEm8VdCRwGcikX/DoPPjr2MsNiw sGlTcCiOkVby/5MK4WFVf6Pqc/0JgI5hFV33vrCgy4qPEPCuOKfBsB9tjVSMNDS6qGUc aMVgGosUkiHTxnwy8w+ya+lHJ3YTe2AXq7ra6huWV9+stmOI7KMdjBBz3NhrF1iYQLEx XIZOlhiELfzsXxLG8xFYcqXBiztMpLtT51zsLHPfm2t2HzlizT5hwU+ra5F1vl10BTj+ WcuW9Lo2guFgpkkkgWtVHS/zpsDXyEasdhsWiiclVt9YPQhcD2pVLjbEMXYmTgK6kqV/ PAzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=f4Kho3eU3u1mB4X3IpvBq0DquFHheRamfPe/L5a/eBY=; b=hAr8rCtwjp9xHfBJieFbvPalmZpwtMBAIpdyxUJ597X8CGkF5i+B/7NfUjj7UatgeA eufy4ixPBO6XFVmQaaQjaGX8Z8YquCG8HPrzqjvxfB6qxe+T8unm6uCofX0abn2Zk2Ac F8y8IJJ/o/RXpc2YOHG+Ajq/NsosOsUdRJ3maQBAs8+kiElr+X/Wo7XqmMX4W5+7zvWE lf76QAu8vVIFZsIn0ZpqXVKXAgOFoULAVvuhMf03Li7u90Hi7yS0/SHOY6H9f1+7FY0/ tuwHjp0FVTnYwPMI2S8YizRHKdSc0CQA0I+Fm2feJok+vGt5Fc7wIPmqmYNk+ZRQosAl d5lw== X-Gm-Message-State: AOAM533N8/nv9i8H9tVNun4QSjsi0eu+PUCcOMf/nYkwtOGSYKHrnGUE gbGNX8wodU24MK72t2WdhE5wdA== X-Google-Smtp-Source: ABdhPJynE3uUoyfjDRXiDeW+kZxF3rwxYjbIk9+aaaqDKtgg3nzL7cz77Dx0Dpv43a6xjRA7bSj5vQ== X-Received: by 2002:a05:6402:b63:b0:419:2d75:de88 with SMTP id cb3-20020a0564020b6300b004192d75de88mr18129005edb.389.1648761518069; Thu, 31 Mar 2022 14:18:38 -0700 (PDT) Received: from [192.168.0.168] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id b8-20020a170906728800b006e0351df2dcsm220586ejl.70.2022.03.31.14.18.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 14:18:37 -0700 (PDT) Message-ID: <0f8415ab-9eba-ac31-c645-7e543e0da39e@linaro.org> Date: Thu, 31 Mar 2022 23:18:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] regulator: dt-bindings: maxim,max8997: convert to dtschema Content-Language: en-US From: Krzysztof Kozlowski To: Geert Uytterhoeven , Rob Herring Cc: Liam Girdwood , Mark Brown , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20211001130249.80405-1-krzysztof.kozlowski@canonical.com> <64f48c50-c57a-667f-ac6e-9469348cf558@linaro.org> In-Reply-To: <64f48c50-c57a-667f-ac6e-9469348cf558@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/03/2022 22:11, Krzysztof Kozlowski wrote: > On 30/03/2022 12:44, Geert Uytterhoeven wrote: >> Hi Krzysztof, >> >> On Fri, Oct 1, 2021 at 3:18 PM Krzysztof Kozlowski >> wrote: >>> Convert the Maxim MAX8997 PMIC bindings to DT schema format. Extend the >>> examples with additional one copied from kernel's exynos4210-origen.dts. >>> Also the binding descriptions are copied from old file, so license >>> entire work under GPL-2.0. >>> >>> This also adds previously undocumented 32 kHz clock output modelled as >>> regulators. >>> >>> Signed-off-by: Krzysztof Kozlowski >> >> Thanks for your patch, which is now commit 1d2104f21618a4ce >> ("regulator: dt-bindings: maxim,max8997: convert to dtschema"). >> >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8997.yaml >> >>> +if: >>> + anyOf: >>> + - required: >>> + - max8997,pmic-buck1-uses-gpio-dvs >>> + - required: >>> + - max8997,pmic-buck2-uses-gpio-dvs >>> + - required: >>> + - max8997,pmic-buck5-uses-gpio-dvs >>> +then: >>> + properties: >>> + max8997,pmic-buck1-dvs-voltage: >>> + minItems: 8 >>> + maxItems: 8 >>> + max8997,pmic-buck2-dvs-voltage: >>> + minItems: 8 >>> + maxItems: 8 >>> + max8997,pmic-buck5-dvs-voltage: >>> + minItems: 8 >>> + maxItems: 8 >> >> The above doesn't seem to work as expected... >> > > Thanks for pointing this out. I am pretty sure I tested it and it worked > fine (as it is not an obvious code), so I wonder what changed... maybe I > was using slightly older dt-schema? I think I found the cause - not that long time ago, the dtschema started parsing arrays in a different way. It seems that "minItems" must be now under "items:" part for uint32-array. I think this was recent Rob's work. I sent a fix. Best regards, Krzysztof