From: "Nuno Sá" <noname.nuno@gmail.com>
To: "David Lechner" <dlechner@baylibre.com>,
"Pop Ioan Daniel" <pop.ioan-daniel@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Sergiu Cuciurean" <sergiu.cuciurean@analog.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Tobias Sperling" <tobias.sperling@softing.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
"Thomas Bonnefille" <thomas.bonnefille@bootlin.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/6] iio: adc: adi-axi-adc: add axi_adc_oversampling_ratio_set
Date: Mon, 26 May 2025 10:53:43 +0100 [thread overview]
Message-ID: <0fb2756ce0e34be56df40187370a28d7a2a3f321.camel@gmail.com> (raw)
In-Reply-To: <556bb250-d7c6-48aa-8773-26799265f782@baylibre.com>
On Mon, 2025-05-19 at 10:15 -0500, David Lechner wrote:
> On 5/19/25 9:02 AM, Pop Ioan Daniel wrote:
> > Add support for setting decimation rate.
> >
> > Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
> > ---
>
> With the bit below fixed:
>
> Reviewed-by: David Lechner <dlechner@baylibre.com>
>
> ...
> > @@ -381,7 +397,8 @@ static int axi_adc_ad485x_data_size_set(struct
> > iio_backend *back,
> > }
> >
> > static int axi_adc_ad485x_oversampling_ratio_set(struct iio_backend *back,
> > - unsigned int ratio)
> > + unsigned int chan,
> > + unsigned int ratio)
>
> I think this change belongs in the previous patch. Most importantly because
> it could cause a compile error during a git bisect, but also because that
> is where it logically belongs.
I was wondering about this. Definitely needs to be in the previous one...
>
> > {
> > struct adi_axi_adc_state *st = iio_backend_get_priv(back);
> >
next prev parent reply other threads:[~2025-05-26 9:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 14:02 [PATCH v4 0/6] Add support for AD7405/ADUM770x Pop Ioan Daniel
2025-05-19 14:02 ` [PATCH v4 1/6] iio: adc: ad4851: ad4851_set_oversampling_ratio parameters update Pop Ioan Daniel
2025-05-19 15:15 ` David Lechner
2025-05-19 14:02 ` [PATCH v4 2/6] iio: backend: update iio_backend_oversampling_ratio_set Pop Ioan Daniel
2025-05-19 15:15 ` David Lechner
2025-05-26 9:54 ` Nuno Sá
2025-05-19 14:02 ` [PATCH v4 3/6] iio: adc: adi-axi-adc: add axi_adc_oversampling_ratio_set Pop Ioan Daniel
2025-05-19 15:15 ` David Lechner
2025-05-26 9:53 ` Nuno Sá [this message]
2025-05-26 9:54 ` Nuno Sá
2025-05-19 14:02 ` [PATCH v4 4/6] dt-bindings: iio: adc: add ad7405 Pop Ioan Daniel
2025-05-19 15:16 ` David Lechner
2025-05-20 6:41 ` Krzysztof Kozlowski
2025-05-19 14:02 ` [PATCH v4 5/6] dt-bindings: iio: adc: adi-axi-adc: add ad7405 example Pop Ioan Daniel
2025-05-19 15:19 ` David Lechner
2025-05-20 6:39 ` Krzysztof Kozlowski
2025-05-19 14:02 ` [PATCH v4 6/6] iio: adc: ad7405: add ad7405 driver Pop Ioan Daniel
2025-05-19 15:18 ` David Lechner
2025-05-25 11:03 ` Jonathan Cameron
2025-05-26 10:00 ` Nuno Sá
2025-05-19 15:22 ` [PATCH v4 0/6] Add support for AD7405/ADUM770x David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fb2756ce0e34be56df40187370a28d7a2a3f321.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=alisadariana@gmail.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dragos.bogdan@analog.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=pop.ioan-daniel@analog.com \
--cc=robh@kernel.org \
--cc=sergiu.cuciurean@analog.com \
--cc=thomas.bonnefille@bootlin.com \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).