devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: nick.hawkins@hpe.com, christophe.jaillet@wanadoo.fr,
	simon.horman@corigine.com, andrew@lunn.ch, verdun@hpe.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] net: hpe: Add GXP UMAC MDIO
Date: Wed, 2 Aug 2023 15:42:38 -0700	[thread overview]
Message-ID: <0fb34d56-7333-1551-b19e-fa3e19dcab58@infradead.org> (raw)
In-Reply-To: <20230802201824.3683-3-nick.hawkins@hpe.com>

Hi Nick,

On 8/2/23 13:18, nick.hawkins@hpe.com wrote:
> diff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig
> index 9ff2e6f22f3f..58e054bff786 100644
> --- a/drivers/net/mdio/Kconfig
> +++ b/drivers/net/mdio/Kconfig
> @@ -115,6 +115,19 @@ config MDIO_GPIO
>  	  To compile this driver as a module, choose M here: the module
>  	  will be called mdio-gpio.
>  
> +config GXP_UMAC_MDIO
> +	tristate "GXP UMAC mdio support"
> +	depends on ARCH_HPE || COMPILE_TEST
> +	depends on OF_MDIO && HAS_IOMEM
> +	depends on MDIO_DEVRES
> +        help

Indent line above with one tab only.

> +	  Say y here to support the GXP UMAC MDIO bus. The
> +	  MDIO(mdio0) interface from the primary MAC (umac0)

Consistent spacing:
	  MDIO (mdio0)

> +	  is used for external PHY status and configuration.
> +	  The MDIO(mdio1) interface from the secondary MAC

	      MDIO (mdio1)

> +	  (umac1) is routed to the SGMII/100Base-X IP blocks
> +	  on the two SERDES interface connections.

thanks.
-- 
~Randy

  parent reply	other threads:[~2023-08-02 22:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 20:18 [PATCH v2 0/5] ARM: Add GXP UMAC Support nick.hawkins
2023-08-02 20:18 ` [PATCH v2 1/5] dt-bindings: net: Add HPE GXP UMAC MDIO nick.hawkins
2023-08-02 20:18 ` [PATCH v2 2/5] net: hpe: Add " nick.hawkins
2023-08-02 22:39   ` Andrew Lunn
2023-08-16  0:55     ` Hawkins, Nick
2023-08-16  1:29       ` Andrew Lunn
2023-08-02 22:42   ` Randy Dunlap [this message]
2023-08-03 11:39   ` Simon Horman
2023-08-02 20:18 ` [PATCH v2 3/5] dt-bindings: net: Add HPE GXP UMAC nick.hawkins
2023-08-02 22:45   ` Andrew Lunn
2023-08-03 15:52   ` Conor Dooley
2023-08-16 16:26     ` Hawkins, Nick
2023-08-17  8:55       ` Conor Dooley
2023-08-02 20:18 ` [PATCH v2 4/5] net: hpe: Add GXP UMAC Driver nick.hawkins
2023-08-02 23:20   ` Andrew Lunn
2023-08-04 20:55     ` Hawkins, Nick
2023-08-05  6:45       ` Andrew Lunn
2023-08-08 20:39         ` Hawkins, Nick
2023-08-08 20:54           ` Andrew Lunn
2023-08-09 23:55             ` Hawkins, Nick
2023-08-10  1:54               ` Andrew Lunn
2023-08-02 20:18 ` [PATCH v2 5/5] MAINTAINERS: HPE: Add GXP UMAC Networking Files nick.hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fb34d56-7333-1551-b19e-fa3e19dcab58@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=andrew@lunn.ch \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nick.hawkins@hpe.com \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=simon.horman@corigine.com \
    --cc=verdun@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).