From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E67447E0E9; Wed, 7 Aug 2024 14:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042297; cv=none; b=mdxeImqKg4xzfrUYvDo0u80Z00ZO8ox/0q1Q9AxuRVSfDL8uApuR/Pzfs6r3+zMO2JzA6VLqRU0PCRp3E/44r6QgUMQHnfymUaaX/PQHDhVSemNmyjjI269O7cUbmc1jERroFtQ9hoav9GeBC9QjLyrb/XBt4VzSuMj7z2YVBug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042297; c=relaxed/simple; bh=XObzYOPHhby3ggLwzGEaQzICqe4oj78DHpF5ya8vOCg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dh2l2ZMfvhoHx56kBHpdfnyW5f15zuVXPgsdGGAs108JYPYxAY4mCtHx5FAbfbHRb0n3MkIGoDhQdjVTkyP4hKbiq8FR/II9kLQisBZHxeo2YsqoUX6PO0fSaGAZ9SqadO2R9BCjhaibh9vQkRfBCZ/tpGA4y38Kpdl+b5wPjDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JDoWj/o3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JDoWj/o3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 988B5C32781; Wed, 7 Aug 2024 14:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723042296; bh=XObzYOPHhby3ggLwzGEaQzICqe4oj78DHpF5ya8vOCg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JDoWj/o3qbZAwXN8osA7o/fQR5rR2a9sf1glg85R5aDIHg3UcenfyND5ai2Qq09ds ASl7C5d2WRpFXDiGUCrwQSUyoPiFIQVP2YlJ1Whxfe8KyyoONMOOKbzz5rERB7JI7r wY92XhGA1DrYK3GiCzjOVAfH5SXsYcG/QG/dIFXVs09lASk9fk7wWDuyI7J2cv60Z4 w2pTnfKEDwV85KCSgFc6wzIf/wQM/i/tEcLVnD6jJ5uqVoNiaSCc9Rh2udTEWZBsoO xvJBSjOWwaId4b7ifJVGwtfxmSzaM9jHc4B3hShYyV0aX2MDJ13pRHUsUKIDdmo/v3 V+2RzEXdLSdLQ== Message-ID: <0fb55319-0bae-4bb0-bce6-ebdbdd68f765@kernel.org> Date: Wed, 7 Aug 2024 16:51:29 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm8550: camss: Add CAMSS block definition To: Bryan O'Donoghue , Depeng Shao , andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240807123333.2056518-1-quic_depengs@quicinc.com> <1c0ff0fa-73d3-400f-a58d-15fb9b0574d1@kernel.org> <85cc52aa-4593-49f5-9438-1ee3f09d2d71@quicinc.com> <336e5679-f04e-47aa-9655-df88fde9de21@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <336e5679-f04e-47aa-9655-df88fde9de21@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/08/2024 16:17, Bryan O'Donoghue wrote: > On 07/08/2024 13:53, Depeng Shao wrote: >> Hi Krzysztof, >> >> On 8/7/2024 8:43 PM, Krzysztof Kozlowski wrote: >>> On 07/08/2024 14:39, Krzysztof Kozlowski wrote: >>>> On 07/08/2024 14:33, Depeng Shao wrote: >>>>> Add CAMSS block definition for sm8550. >>>>> >>>>> This drop contains definitions for the following components on sm8550: >>>> >>>> 1. Subject: there is no prefix camss. There is no such file, directory >>>> or module. >>>> >> >> Thanks for the comment, will remove this. >> >>>> 2. You already sent this, so this should be v2 or v3 or vX. Provide >>>> changelog under ---. >>>> >>>> If there is going to be resend, please fix above. >>>> >> >> Sure, I thought it might be a new series, so I didn't add v*, will add >> v1, and v2 change log in new version series. >> >>>> 3. If this was tested on aim300, I am surprised this being not enabled >>>> on aim300. >>> >> >> It was tested long times ago, but the patches wasn't sent out for >> reviewing early due to the team's internal schedule. >> >>> One more thing, bindings were not accepted, thus this patch should not >>> go in. There were no new bindings, so I assume patchset is using >>> rejected ones. >>> >>> It's fine to send it to get some comments, although would be nice to >>> mention to maintainer that this cannot be picked up as is. :( >>> >> >> Sure, I will resend the dtsi patch until the bindings are accepted, send >> this patches because you posted the comments in other series. >> >> https://lore.kernel.org/all/0324e8e8-2ad4-4ce6-9616-3038b8e02ff9@quicinc.com/ >> >> Thanks, >> Depeng >> >> > > Recommend > > 1. Send out your yaml and dts in one series > > 2. Driver series can be posted in parallel The binding should go with the driver. Also usually discussion about driver brings comments, thus changes, to the bindings. Sorry, DTSI and DTS should wait till bindings got accepted to media subsystem. Best regards, Krzysztof