From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610
Date: Fri, 7 Jul 2023 08:26:51 +0200 [thread overview]
Message-ID: <0fd87e8f-7d09-549f-1170-3bcebbc572f6@linaro.org> (raw)
In-Reply-To: <9d9245fb-463f-c967-46e5-cfc0ac832792@arm.com>
On 06/07/2023 19:49, Robin Murphy wrote:
> On 2023-07-06 14:54, Krzysztof Kozlowski wrote:
>> On 05/07/2023 08:48, Krzysztof Kozlowski wrote:
>>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
>>> These are simple defines so they could be used in DTS but they will not
>>> have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
>>>
>>> Correct the interrupt flags, assuming the author of the code wanted same
>>> logical behavior behind the name "ACTIVE_xxx", this is:
>>> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>>
>> This should be HIGH in both cases. I will send a v2.
>
> Also the titles say "audio-codec" but they're all touching SDIO WiFi
> modules ;)
Thanks. Too much of copy-pasta.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-07-07 6:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 6:48 [RFT PATCH 1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610 Krzysztof Kozlowski
2023-07-05 6:48 ` [RFT PATCH 2/3] arm64: dts: rockchip: correct audio-codec interrupt flag in Rock Pi 4B Krzysztof Kozlowski
2023-07-06 11:31 ` Christopher Obbard
2023-07-05 6:48 ` [RFT PATCH 3/3] arm64: dts: rockchip: correct audio-codec interrupt flag in Box Demo Krzysztof Kozlowski
2023-07-06 13:54 ` [RFT PATCH 1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610 Krzysztof Kozlowski
2023-07-06 17:49 ` Robin Murphy
2023-07-07 6:26 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fd87e8f-7d09-549f-1170-3bcebbc572f6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).