From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B75EB64D9 for ; Fri, 7 Jul 2023 06:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbjGGG05 (ORCPT ); Fri, 7 Jul 2023 02:26:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjGGG04 (ORCPT ); Fri, 7 Jul 2023 02:26:56 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 092FF1723 for ; Thu, 6 Jul 2023 23:26:55 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-98de21518fbso184289966b.0 for ; Thu, 06 Jul 2023 23:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688711213; x=1691303213; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0W3Gd8jBrQTVEqQoMXv1avQ4XCiWz9OzEFTfcGO5S9w=; b=MYBnj45u6lsvuU47y/JuHX0SOY1/oJw5yUoKG81Pu7RI1xlBhhgOR3wTdPJoj+VkJO 74I1YLJOZdWGawEVLQ/jrC7hUgrP7dUgqBBFE2nxAhk/zII5kNrgSv+VoQjLWJp1VZLS Tszfnj20a+NJT/gj45+t0DgPbhMiX7dD2j9hZSK3mKotd2HwGN6VID9M4UNetT/S7g6+ QMNlg0b+Fy6Zvdyb9ySaJSZrDi/NnHF8+T0pkeEI3AJVxgHbN6nMlLxInaXssakWqvK3 cCf1PFeLS79ezXP5vt6+itYDxLG6r1N+33kA8MR0YfG3eKQBvCzhQRYggxh3LiSg7II7 1chg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688711213; x=1691303213; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0W3Gd8jBrQTVEqQoMXv1avQ4XCiWz9OzEFTfcGO5S9w=; b=EgeW1GFTmRFaddbvQ4+TiJomlweQDAoURwbUQavrWKvHBOoqbDXDKA53+j78pF/ViP 3+71h/LKXCuVOh+sX5hUY6BuvjmuBvoX7xrjzf36ddA/M7xZFPUD719CMbzoAawpNvXF WRLniyBm6I/RFyNMdGwlanT1UjpfSDcL7S/RgW6wt2g+gLOKP+Jb4px35Nv10on1wSQ2 WPKoBzUfPM/WHuAo+1U+SS9/PR2mBmCMFRN5oK53kc0UhhijJZCrYWhf1o6Zi63NC+Rj L59SHzf+/LUAFMLRyMIrowVR4/o9fO47o+H+Lw/JX+rlsTr0Y67nPVPaflAfslTj7tmp gc1w== X-Gm-Message-State: ABy/qLZXKpYpK3KCCSXxir3vwYrQQmYJmbWQ3kBL9khkbkuwqZ3AxPvO 0PWwg83yTyIf8cSxzctk7OsKVu5Wwar7As0TamMYHw== X-Google-Smtp-Source: APBJJlGyXXAFlZKcUiBo8uH2mXTvF+2xcpddNfdWn8QuWvicVEB5eBFG1KaGmK8LsJfFTahNxI5cRg== X-Received: by 2002:a17:906:224d:b0:977:e87c:e633 with SMTP id 13-20020a170906224d00b00977e87ce633mr2949201ejr.23.1688711213433; Thu, 06 Jul 2023 23:26:53 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id ov24-20020a170906fc1800b0099364d9f0e6sm1727055ejb.117.2023.07.06.23.26.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 23:26:52 -0700 (PDT) Message-ID: <0fd87e8f-7d09-549f-1170-3bcebbc572f6@linaro.org> Date: Fri, 7 Jul 2023 08:26:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFT PATCH 1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610 Content-Language: en-US To: Robin Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> <941ead9e-9e46-b5cb-0a8b-345df6606484@linaro.org> <9d9245fb-463f-c967-46e5-cfc0ac832792@arm.com> From: Krzysztof Kozlowski In-Reply-To: <9d9245fb-463f-c967-46e5-cfc0ac832792@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/07/2023 19:49, Robin Murphy wrote: > On 2023-07-06 14:54, Krzysztof Kozlowski wrote: >> On 05/07/2023 08:48, Krzysztof Kozlowski wrote: >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. >>> These are simple defines so they could be used in DTS but they will not >>> have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. >>> >>> Correct the interrupt flags, assuming the author of the code wanted same >>> logical behavior behind the name "ACTIVE_xxx", this is: >>> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW >> >> This should be HIGH in both cases. I will send a v2. > > Also the titles say "audio-codec" but they're all touching SDIO WiFi > modules ;) Thanks. Too much of copy-pasta. Best regards, Krzysztof