From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Abdel Alkuor <alkuor@gmail.com>,
heikki.krogerus@linux.intel.com,
krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
ryan.eleceng@gmail.com, Abdel Alkuor <abdelalkuor@geotab.com>
Subject: Re: [PATCH v6 01/14] dt-bindings: usb: tps6598x: Add tps25750
Date: Sat, 23 Sep 2023 13:49:22 +0200 [thread overview]
Message-ID: <0fe357a3-c2c7-f642-30ba-a068a9c04e66@linaro.org> (raw)
In-Reply-To: <20230923073959.86660-2-alkuor@gmail.com>
On 23/09/2023 09:39, Abdel Alkuor wrote:
> From: Abdel Alkuor <abdelalkuor@geotab.com>
>
> TPS25750 is USB TypeC PD controller which is a subset of TPS6598x.
>
> Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
> ---
> Changes in v6:
> - Use reg property for patch address
> Changes in v5:
> - Add tps25750 bindings
>
> .../devicetree/bindings/usb/ti,tps6598x.yaml | 80 ++++++++++++++++++-
> 1 file changed, 78 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> index 5497a60cddbc..da299a2bb19e 100644
> --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> @@ -20,8 +20,7 @@ properties:
> enum:
> - ti,tps6598x
> - apple,cd321x
> - reg:
> - maxItems: 1
reg must be defined in top-level.
https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L57
> + - ti,tps25750
>
> wakeup-source: true
>
> @@ -32,10 +31,55 @@ properties:
> items:
> - const: irq
>
> + firmware-name:
> + description: |
> + Should contain the name of the default patch binary
> + file located on the firmware search path which is
> + used to switch the controller into APP mode.
> + This is used when tps25750 doesn't have an EEPROM
> + connected to it.
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,tps25750
> + then:
> + properties:
> + reg:
> + maxItems: 2
> +
> + reg-names:
> + description: |
> + The first reg is PD device address and the second
> + reg is I2C slave address field in PBMs input data
> + which is used as the device address when writing the
> + patch for TPS25750.
> + The patch address can be any value except 0x00, 0x20,
> + 0x21, 0x22, and 0x23
Entire description is not suitable here, but should be used as
description of items in reg: (instead of maxItems).
> + items:
> + - const: main
> + - const: patch-address
> +
> + connector:
> + required:
> + - data-role
> +
> + required:
> + - connector
> + - reg-names
> + else:
> + properties:
> + reg:
> + maxItems: 1
> +
> +
Only one blank line.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-23 11:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 7:39 [PATCH v6 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 01/14] dt-bindings: usb: tps6598x: Add tps25750 Abdel Alkuor
2023-09-23 11:49 ` Krzysztof Kozlowski [this message]
2023-09-23 7:39 ` [PATCH v6 02/14] USB: typec: Add cmd timeout and response delay Abdel Alkuor
2023-09-27 7:00 ` Heikki Krogerus
2023-09-27 7:18 ` Heikki Krogerus
2023-09-27 7:47 ` Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 03/14] USB: typec: Add patch mode to tps6598x Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 04/14] USB: typec: Load TPS25750 patch bundle Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 05/14] USB: typec: Check for EEPROM present Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 06/14] USB: typec: Clear dead battery flag Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 07/14] USB: typec: Apply patch again after power resume Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 08/14] USB: typec: Add interrupt support for TPS25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 09/14] USB: typec: Refactor tps6598x port registration Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 10/14] USB: typec: Add port registration for tps25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 11/14] USB: typec: Enable sleep mode " Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 12/14] USB: typec: Add trace for tps25750 irq Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 13/14] USB: typec: Add power status trace for tps25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 14/14] USB: typec: Add " Abdel Alkuor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe357a3-c2c7-f642-30ba-a068a9c04e66@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abdelalkuor@geotab.com \
--cc=alkuor@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.eleceng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).