* [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
@ 2022-09-15 7:23 Bonnie Lo
2022-09-17 16:57 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Bonnie Lo @ 2022-09-15 7:23 UTC (permalink / raw)
To: joel
Cc: patrickw3, garnermic, Delphine_Chiu, Bonnie_Lo, Bonnie Lo,
Arnd Bergmann, Olof Johansson, soc, Rob Herring,
Krzysztof Kozlowski, Andrew Jeffery, linux-arm-kernel, devicetree,
linux-kernel, linux-aspeed
From: Bonnie Lo <Bonnie_Lo@wiwynn.com>
Add linux device tree entry related to
greatlakes specific devices connected to BMC SoC.
Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
---
arch/arm/boot/dts/Makefile | 1 +
.../dts/aspeed-bmc-facebook-greatlakes.dts | 248 ++++++++++++++++++
2 files changed, 249 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 05d8aef6e5d2..40fa906ab17f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1580,6 +1580,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
aspeed-bmc-asrock-e3c246d4i.dtb \
aspeed-bmc-asrock-romed8hm3.dtb \
aspeed-bmc-bytedance-g220a.dtb \
+ aspeed-bmc-facebook-greatlakes.dtb \
aspeed-bmc-facebook-bletchley.dtb \
aspeed-bmc-facebook-cloudripper.dtb \
aspeed-bmc-facebook-cmm.dtb \
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
new file mode 100644
index 000000000000..f011cc4d370f
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
@@ -0,0 +1,248 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2022 Facebook Inc.
+
+/dts-v1/;
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/i2c/i2c.h>
+#include <dt-bindings/leds/leds-pca955x.h>
+
+/ {
+ model = "AST2600 EVB";
+ compatible = "aspeed,ast2600";
+
+ aliases {
+ serial4 = &uart5;
+ };
+
+ chosen {
+ stdout-path = &uart5;
+ bootargs = "console=ttyS4,57600n8 root=/dev/ram rw vmalloc=384M";
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ reg = <0x80000000 0x80000000>;
+ };
+
+ iio-hwmon {
+ compatible = "iio-hwmon";
+ io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+ <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+ <&adc1 0>, <&adc1 2>, <&adc1 3>, <&adc1 4>,
+ <&adc1 5>, <&adc1 6>;
+ };
+};
+
+&uart1 {
+ status = "okay";
+};
+
+&uart2 {
+ status = "okay";
+};
+
+&uart3 {
+ status = "okay";
+};
+
+&uart4 {
+ status = "okay";
+};
+
+&uart5 {
+ status = "okay";
+};
+
+&wdt1 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wdtrst1_default>;
+ aspeed,reset-type = "soc";
+ aspeed,external-signal;
+ aspeed,ext-push-pull;
+ aspeed,ext-active-high;
+ aspeed,ext-pulse-duration = <256>;
+};
+
+&mac3 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_rmii4_default>;
+ no-hw-checksum;
+ use-ncsi;
+ mlx,multi-host;
+ ncsi-ctrl,start-redo-probe;
+ ncsi-ctrl,no-channel-monitor;
+ ncsi-package = <1>;
+ ncsi-channel = <1>;
+ ncsi-rexmit = <1>;
+ ncsi-timeout = <2>;
+};
+
+&rtc {
+ status = "okay";
+};
+
+&fmc {
+ status = "okay";
+ flash@0 {
+ status = "okay";
+ m25p,fast-read;
+ label = "bmc";
+ spi-rx-bus-width = <4>;
+ spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout-64.dtsi"
+ };
+ flash@1 {
+ status = "okay";
+ m25p,fast-read;
+ label = "bmc2";
+ spi-rx-bus-width = <4>;
+ spi-max-frequency = <50000000>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+ multi-master;
+ ipmb0@10 {
+ compatible = "ipmb-dev";
+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+ i2c-protocol;
+ };
+};
+
+&i2c1 {
+ status = "okay";
+ multi-master;
+ ipmb1@10 {
+ compatible = "ipmb-dev";
+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+ i2c-protocol;
+ };
+};
+
+&i2c2 {
+ status = "okay";
+ multi-master;
+ ipmb2@10 {
+ compatible = "ipmb-dev";
+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+ i2c-protocol;
+ };
+};
+
+&i2c3 {
+ status = "okay";
+ multi-master;
+ ipmb3@10 {
+ compatible = "ipmb-dev";
+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+ i2c-protocol;
+ };
+};
+
+&i2c4 {
+ status = "okay";
+};
+
+&i2c5 {
+ status = "okay";
+};
+
+&i2c6 {
+ status = "okay";
+};
+
+&i2c7 {
+ status = "okay";
+};
+
+&i2c8 {
+ status = "okay";
+ tmp421@1f {
+ compatible = "ti,tmp421";
+ reg = <0x1f>;
+ };
+ // NIC EEPROM
+ eeprom@50 {
+ compatible = "st,24c32";
+ reg = <0x50>;
+ };
+};
+
+&i2c9 {
+ status = "okay";
+ multi-master;
+ ipmb9@10 {
+ compatible = "ipmb-dev";
+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+ i2c-protocol;
+ };
+};
+
+&i2c10 {
+ status = "okay";
+};
+
+&i2c11 {
+ status = "okay";
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+};
+
+&i2c12 {
+ status = "okay";
+ lm75@4f {
+ compatible = "lm75";
+ reg = <0x4f>;
+ };
+};
+
+&i2c13 {
+ status = "okay";
+};
+
+&adc0 {
+ ref_voltage = <2500>;
+ status = "okay";
+ pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+ &pinctrl_adc2_default &pinctrl_adc3_default
+ &pinctrl_adc4_default &pinctrl_adc5_default
+ &pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+ ref_voltage = <2500>;
+ status = "okay";
+ pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc10_default
+ &pinctrl_adc11_default &pinctrl_adc12_default
+ &pinctrl_adc13_default &pinctrl_adc14_default>;
+};
+
+
+&ehci0 {
+ status = "okay";
+};
+
+&ehci1 {
+ status = "okay";
+};
+
+&uhci {
+ status = "okay";
+};
+
+&gpio0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_gpiu1_default &pinctrl_gpiu7_default>;
+};
+
+
--
2.17.1
WIWYNN PROPRIETARY This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
2022-09-15 7:23 [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Bonnie Lo
@ 2022-09-17 16:57 ` Krzysztof Kozlowski
2022-09-20 7:45 ` Bonnie Lo/WYHQ/Wiwynn
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-17 16:57 UTC (permalink / raw)
To: Bonnie Lo, joel
Cc: patrickw3, garnermic, Delphine_Chiu, Arnd Bergmann,
Olof Johansson, soc, Rob Herring, Krzysztof Kozlowski,
Andrew Jeffery, linux-arm-kernel, devicetree, linux-kernel,
linux-aspeed
On 15/09/2022 08:23, Bonnie Lo wrote:
> From: Bonnie Lo <Bonnie_Lo@wiwynn.com>
Use subject prefixes matching the subsystem (git log --oneline -- ...).
>
> Add linux device tree entry related to
> greatlakes specific devices connected to BMC SoC.
Please wrap commit message according to Linux coding style / submission
process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
>
> Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> .../dts/aspeed-bmc-facebook-greatlakes.dts | 248 ++++++++++++++++++
Missing documentation of board compatible (bindings) as first patch.
> 2 files changed, 249 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 05d8aef6e5d2..40fa906ab17f 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1580,6 +1580,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> aspeed-bmc-asrock-e3c246d4i.dtb \
> aspeed-bmc-asrock-romed8hm3.dtb \
> aspeed-bmc-bytedance-g220a.dtb \
> + aspeed-bmc-facebook-greatlakes.dtb \
Wrong order.
> aspeed-bmc-facebook-bletchley.dtb \
> aspeed-bmc-facebook-cloudripper.dtb \
> aspeed-bmc-facebook-cmm.dtb \
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> new file mode 100644
> index 000000000000..f011cc4d370f
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> @@ -0,0 +1,248 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2022 Facebook Inc.
> +
> +/dts-v1/;
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +#include <dt-bindings/i2c/i2c.h>
> +#include <dt-bindings/leds/leds-pca955x.h>
> +
> +/ {
> + model = "AST2600 EVB";
Wrong name.
> + compatible = "aspeed,ast2600";
Missing board compatible.
> +
> + aliases {
> + serial4 = &uart5;
> + };
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,57600n8 root=/dev/ram rw vmalloc=384M";
Bootargs usually do not belong to mainline DTS.
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x80000000>;
> + };
> +
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> + <&adc1 0>, <&adc1 2>, <&adc1 3>, <&adc1 4>,
> + <&adc1 5>, <&adc1 6>;
> + };
> +};
> +
> +&uart1 {
> + status = "okay";
> +};
> +
> +&uart2 {
> + status = "okay";
> +};
> +
> +&uart3 {
> + status = "okay";
> +};
> +
> +&uart4 {
> + status = "okay";
> +};
> +
> +&uart5 {
> + status = "okay";
> +};
> +
> +&wdt1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_wdtrst1_default>;
> + aspeed,reset-type = "soc";
> + aspeed,external-signal;
> + aspeed,ext-push-pull;
> + aspeed,ext-active-high;
> + aspeed,ext-pulse-duration = <256>;
> +};
> +
> +&mac3 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii4_default>;
> + no-hw-checksum;
> + use-ncsi;
> + mlx,multi-host;
> + ncsi-ctrl,start-redo-probe;
> + ncsi-ctrl,no-channel-monitor;
> + ncsi-package = <1>;
> + ncsi-channel = <1>;
> + ncsi-rexmit = <1>;
> + ncsi-timeout = <2>;
> +};
> +
> +&rtc {
> + status = "okay";
> +};
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + status = "okay";
> + m25p,fast-read;
> + label = "bmc";
> + spi-rx-bus-width = <4>;
> + spi-max-frequency = <50000000>;
> +#include "openbmc-flash-layout-64.dtsi"
> + };
> + flash@1 {
> + status = "okay";
> + m25p,fast-read;
> + label = "bmc2";
> + spi-rx-bus-width = <4>;
> + spi-max-frequency = <50000000>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> + multi-master;
> + ipmb0@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> +&i2c1 {
> + status = "okay";
> + multi-master;
> + ipmb1@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> +&i2c2 {
> + status = "okay";
> + multi-master;
> + ipmb2@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> +&i2c3 {
> + status = "okay";
> + multi-master;
> + ipmb3@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> +&i2c4 {
> + status = "okay";
> +};
> +
> +&i2c5 {
> + status = "okay";
> +};
> +
> +&i2c6 {
> + status = "okay";
> +};
> +
> +&i2c7 {
> + status = "okay";
> +};
> +
> +&i2c8 {
> + status = "okay";
> + tmp421@1f {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tmp421";
> + reg = <0x1f>;
> + };
> + // NIC EEPROM
> + eeprom@50 {
> + compatible = "st,24c32";
> + reg = <0x50>;
> + };
> +};
> +
> +&i2c9 {
> + status = "okay";
> + multi-master;
> + ipmb9@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> +&i2c10 {
> + status = "okay";
> +};
> +
> +&i2c11 {
> + status = "okay";
> + eeprom@51 {
> + compatible = "atmel,24c128";
> + reg = <0x51>;
> + };
> + eeprom@54 {
> + compatible = "atmel,24c128";
> + reg = <0x54>;
> + };
> +};
> +
> +&i2c12 {
> + status = "okay";
> + lm75@4f {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "lm75";
> + reg = <0x4f>;
> + };
> +};
> +
(...)
> +
> +&gpio0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpiu1_default &pinctrl_gpiu7_default>;
> +};
> +
> +
> --
> 2.17.1
>
> WIWYNN PROPRIETARY This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.
This means we cannot take this patch. Proprietary and/or confidential
patches cannot be merged.
Please license the patch as you wrote in SPDX header.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
2022-09-17 16:57 ` Krzysztof Kozlowski
@ 2022-09-20 7:45 ` Bonnie Lo/WYHQ/Wiwynn
2022-09-20 8:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Bonnie Lo/WYHQ/Wiwynn @ 2022-09-20 7:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, joel@jms.id.au
Cc: patrickw3@fb.com, garnermic@fb.com, Delphine Chiu/WYHQ/Wiwynn,
Arnd Bergmann, Olof Johansson, soc@kernel.org, Rob Herring,
Krzysztof Kozlowski, Andrew Jeffery,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org
Hi Krzysztof,
I revise the device tree as following and resend the mail.
It create a new mail thread " [PATCH] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC".
Kindly to correct me, if there is any problem.
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>
> >
> > Add linux device tree entry related to greatlakes specific devices
> > connected to BMC SoC.
>
> Please wrap commit message according to Linux coding style / submission
> process:
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
> ootlin.com%2Flinux%2Fv5.18-rc4%2Fsource%2FDocumentation%2Fprocess%2
> Fsubmitting-patches.rst%23L586&data=05%7C01%7CBonnie_Lo%40wiw
> ynn.com%7C1dee8dcb540a49522fb608da98cdba6f%7Cda6e0628fc834caf9dd
> 273061cbab167%7C0%7C0%7C637990306620286314%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6Mn0%3D%7C3000%7C%7C%7C&sdata=mC2E3dJbuYgXklS%2Fw8s2w%2
> BKH%2BZ3CsZSndFTgPBjyvpw%3D&reserved=0
>
I have add " ARM: dts: aspeed: greatlakes:".
> >
> > Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
> > ---
> > arch/arm/boot/dts/Makefile | 1 +
> > .../dts/aspeed-bmc-facebook-greatlakes.dts | 248
> ++++++++++++++++++
>
> Missing documentation of board compatible (bindings) as first patch.
>
> > 2 files changed, 249 insertions(+)
> > create mode 100644
> > arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 05d8aef6e5d2..40fa906ab17f 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1580,6 +1580,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> > aspeed-bmc-asrock-e3c246d4i.dtb \
> > aspeed-bmc-asrock-romed8hm3.dtb \
> > aspeed-bmc-bytedance-g220a.dtb \
> > + aspeed-bmc-facebook-greatlakes.dtb \
>
> Wrong order.
I have reordered it.
>
> > aspeed-bmc-facebook-bletchley.dtb \
> > aspeed-bmc-facebook-cloudripper.dtb \
> > aspeed-bmc-facebook-cmm.dtb \
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> > b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> > new file mode 100644
> > index 000000000000..f011cc4d370f
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> > @@ -0,0 +1,248 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2022
> > +Facebook Inc.
> > +
> > +/dts-v1/;
> > +#include "aspeed-g6.dtsi"
> > +#include <dt-bindings/gpio/aspeed-gpio.h> #include
> > +<dt-bindings/i2c/i2c.h> #include <dt-bindings/leds/leds-pca955x.h>
> > +
> > +/ {
> > + model = "AST2600 EVB";
>
> Wrong name.
I have revies the model name " Facebook Greatlakes BMC ".
>
> > + compatible = "aspeed,ast2600";
>
> Missing board compatible.
>
I add board compatible " facebook,greatlakes-bmc"
> > +
> > + aliases {
> > + serial4 = &uart5;
> > + };
> > +
> > + chosen {
> > + stdout-path = &uart5;
> > + bootargs = "console=ttyS4,57600n8 root=/dev/ram rw
> > + vmalloc=384M";
>
> Bootargs usually do not belong to mainline DTS.
Removed.
>
> > + };
> > +
> > + memory@80000000 {
> > + device_type = "memory";
> > + reg = <0x80000000 0x80000000>;
> > + };
> > +
> > + iio-hwmon {
> > + compatible = "iio-hwmon";
> > + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>,
> <&adc0 3>,
> > + <&adc0 4>, <&adc0 5>, <&adc0 6>,
> <&adc0 7>,
> > + <&adc1 0>, <&adc1 2>, <&adc1 3>,
> <&adc1 4>,
> > + <&adc1 5>, <&adc1 6>;
> > + };
> > +};
> > +
> > +&uart1 {
> > + status = "okay";
> > +};
> > +
> > +&uart2 {
> > + status = "okay";
> > +};
> > +
> > +&uart3 {
> > + status = "okay";
> > +};
> > +
> > +&uart4 {
> > + status = "okay";
> > +};
> > +
> > +&uart5 {
> > + status = "okay";
> > +};
> > +
> > +&wdt1 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_wdtrst1_default>;
> > + aspeed,reset-type = "soc";
> > + aspeed,external-signal;
> > + aspeed,ext-push-pull;
> > + aspeed,ext-active-high;
> > + aspeed,ext-pulse-duration = <256>; };
> > +
> > +&mac3 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_rmii4_default>;
> > + no-hw-checksum;
> > + use-ncsi;
> > + mlx,multi-host;
> > + ncsi-ctrl,start-redo-probe;
> > + ncsi-ctrl,no-channel-monitor;
> > + ncsi-package = <1>;
> > + ncsi-channel = <1>;
> > + ncsi-rexmit = <1>;
> > + ncsi-timeout = <2>;
> > +};
> > +
> > +&rtc {
> > + status = "okay";
> > +};
> > +
> > +&fmc {
> > + status = "okay";
> > + flash@0 {
> > + status = "okay";
> > + m25p,fast-read;
> > + label = "bmc";
> > + spi-rx-bus-width = <4>;
> > + spi-max-frequency = <50000000>; #include
> > +"openbmc-flash-layout-64.dtsi"
> > + };
> > + flash@1 {
> > + status = "okay";
> > + m25p,fast-read;
> > + label = "bmc2";
> > + spi-rx-bus-width = <4>;
> > + spi-max-frequency = <50000000>;
> > + };
> > +};
> > +
> > +&i2c0 {
> > + status = "okay";
> > + multi-master;
> > + ipmb0@10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > +&i2c1 {
> > + status = "okay";
> > + multi-master;
> > + ipmb1@10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > +&i2c2 {
> > + status = "okay";
> > + multi-master;
> > + ipmb2@10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > +&i2c3 {
> > + status = "okay";
> > + multi-master;
> > + ipmb3@10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > +&i2c4 {
> > + status = "okay";
> > +};
> > +
> > +&i2c5 {
> > + status = "okay";
> > +};
> > +
> > +&i2c6 {
> > + status = "okay";
> > +};
> > +
> > +&i2c7 {
> > + status = "okay";
> > +};
> > +
> > +&i2c8 {
> > + status = "okay";
> > + tmp421@1f {
>
> Node names should be generic.
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevicet
> ree-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-basi
> cs.html%23generic-names-recommendation&data=05%7C01%7CBonnie
> _Lo%40wiwynn.com%7C1dee8dcb540a49522fb608da98cdba6f%7Cda6e0628f
> c834caf9dd273061cbab167%7C0%7C0%7C637990306620286314%7CUnknow
> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AjWYGYl6zCyNq5Yd
> 6VOui9P40Kdz3boxK1LSNSy%2Bcmw%3D&reserved=0
>
Revise as "temperature-sensor".
> > + compatible = "ti,tmp421";
> > + reg = <0x1f>;
> > + };
> > + // NIC EEPROM
> > + eeprom@50 {
> > + compatible = "st,24c32";
> > + reg = <0x50>;
> > + };
> > +};
> > +
> > +&i2c9 {
> > + status = "okay";
> > + multi-master;
> > + ipmb9@10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > +&i2c10 {
> > + status = "okay";
> > +};
> > +
> > +&i2c11 {
> > + status = "okay";
> > + eeprom@51 {
> > + compatible = "atmel,24c128";
> > + reg = <0x51>;
> > + };
> > + eeprom@54 {
> > + compatible = "atmel,24c128";
> > + reg = <0x54>;
> > + };
> > +};
> > +
> > +&i2c12 {
> > + status = "okay";
> > + lm75@4f {
>
> Node names should be generic.
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevicet
> ree-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-basi
> cs.html%23generic-names-recommendation&data=05%7C01%7CBonnie
> _Lo%40wiwynn.com%7C1dee8dcb540a49522fb608da98cdba6f%7Cda6e0628f
> c834caf9dd273061cbab167%7C0%7C0%7C637990306620286314%7CUnknow
> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AjWYGYl6zCyNq5Yd
> 6VOui9P40Kdz3boxK1LSNSy%2Bcmw%3D&reserved=0
>
Revise as "temperature-sensor".
> > + compatible = "lm75";
> > + reg = <0x4f>;
> > + };
> > +};
> > +
>
> (...)
>
> > +
> > +&gpio0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpiu1_default &pinctrl_gpiu7_default>;
> > +};
> > +
> > +
> > --
> > 2.17.1
> >
> > WIWYNN PROPRIETARY This email (and any attachments) contains
> proprietary or confidential information and is for the sole use of its intended
> recipient. Any unauthorized review, use, copying or distribution of this email
> or the content of this email is strictly prohibited. If you are not the intended
> recipient, please notify the sender and delete this email immediately.
>
> This means we cannot take this patch. Proprietary and/or confidential
> patches cannot be merged.
>
> Please license the patch as you wrote in SPDX header.
>
> Best regards,
> Krzysztof
WIWYNN PROPRIETARY
This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
2022-09-20 7:45 ` Bonnie Lo/WYHQ/Wiwynn
@ 2022-09-20 8:24 ` Krzysztof Kozlowski
2022-10-05 8:43 ` Delphine_CC_Chiu/WYHQ/Wiwynn
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-20 8:24 UTC (permalink / raw)
To: Bonnie Lo/WYHQ/Wiwynn, joel@jms.id.au
Cc: patrickw3@fb.com, garnermic@fb.com, Delphine Chiu/WYHQ/Wiwynn,
Arnd Bergmann, Olof Johansson, soc@kernel.org, Rob Herring,
Krzysztof Kozlowski, Andrew Jeffery,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org
On 20/09/2022 09:45, Bonnie Lo/WYHQ/Wiwynn wrote:
> Hi Krzysztof,
>
> I revise the device tree as following and resend the mail.
> It create a new mail thread " [PATCH] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC".
> Kindly to correct me, if there is any problem.
>
>> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>>
>>>
>>> Add linux device tree entry related to greatlakes specific devices
>>> connected to BMC SoC.
>>
>> Please wrap commit message according to Linux coding style / submission
>> process:
>> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
>> ootlin.com%2Flinux%2Fv5.18-rc4%2Fsource%2FDocumentation%2Fprocess%2
>> Fsubmitting-patches.rst%23L586&data=05%7C01%7CBonnie_Lo%40wiw
>> ynn.com%7C1dee8dcb540a49522fb608da98cdba6f%7Cda6e0628fc834caf9dd
>> 273061cbab167%7C0%7C0%7C637990306620286314%7CUnknown%7CTWFp
>> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
>> 6Mn0%3D%7C3000%7C%7C%7C&sdata=mC2E3dJbuYgXklS%2Fw8s2w%2
>> BKH%2BZ3CsZSndFTgPBjyvpw%3D&reserved=0
>>
>
> I have add " ARM: dts: aspeed: greatlakes:".
>
>>>
>>> Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
>>> ---
>>> arch/arm/boot/dts/Makefile | 1 +
>>> .../dts/aspeed-bmc-facebook-greatlakes.dts | 248
>> ++++++++++++++++++
>>
>> Missing documentation of board compatible (bindings) as first patch.
Why did you ignore it?
>>
>>> 2 files changed, 249 insertions(+)
>>> create mode 100644
>>> arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 05d8aef6e5d2..40fa906ab17f 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -1580,6 +1580,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>>> aspeed-bmc-asrock-e3c246d4i.dtb \
>>> aspeed-bmc-asrock-romed8hm3.dtb \
>>> aspeed-bmc-bytedance-g220a.dtb \
>>> + aspeed-bmc-facebook-greatlakes.dtb \
>>
>> Wrong order.
>
> I have reordered it.
>
>>
>>> aspeed-bmc-facebook-bletchley.dtb \
>>> aspeed-bmc-facebook-cloudripper.dtb \
>>> aspeed-bmc-facebook-cmm.dtb \
>>> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
>>> b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
>>> new file mode 100644
>>> index 000000000000..f011cc4d370f
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
>>> @@ -0,0 +1,248 @@
>>> +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2022
>>> +Facebook Inc.
>>> +
>>> +/dts-v1/;
>>> +#include "aspeed-g6.dtsi"
>>> +#include <dt-bindings/gpio/aspeed-gpio.h> #include
>>> +<dt-bindings/i2c/i2c.h> #include <dt-bindings/leds/leds-pca955x.h>
>>> +
>>> +/ {
>>> + model = "AST2600 EVB";
>>
>> Wrong name.
>
> I have revies the model name " Facebook Greatlakes BMC ".
>
>>
>>> + compatible = "aspeed,ast2600";
>>
>> Missing board compatible.
>>
>
> I add board compatible " facebook,greatlakes-bmc"
And what is the output of the checkpatch?
>
>>> +
>>> + aliases {
>>> + serial4 = &uart5;
>>> + };
>>> +
>>> + chosen {
>>> + stdout-path = &uart5;
>>> + bootargs = "console=ttyS4,57600n8 root=/dev/ram rw
>>> + vmalloc=384M";
>>
>> Bootargs usually do not belong to mainline DTS.
>
> Removed.
I still saw bootargs.
(...)
>>>
>>> WIWYNN PROPRIETARY This email (and any attachments) contains
>> proprietary or confidential information and is for the sole use of its intended
>> recipient. Any unauthorized review, use, copying or distribution of this email
>> or the content of this email is strictly prohibited. If you are not the intended
>> recipient, please notify the sender and delete this email immediately.
>>
>> This means we cannot take this patch. Proprietary and/or confidential
>> patches cannot be merged.
>>
>> Please license the patch as you wrote in SPDX header.
>>
>> Best regards,
>> Krzysztof
> WIWYNN PROPRIETARY
> This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.
Your company is still adding proprietary license. Since I am not
intended recipient, I will remove your messages.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
2022-09-20 8:24 ` Krzysztof Kozlowski
@ 2022-10-05 8:43 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2022-10-05 15:02 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Delphine_CC_Chiu/WYHQ/Wiwynn @ 2022-10-05 8:43 UTC (permalink / raw)
To: Krzysztof Kozlowski, joel@jms.id.au
Cc: patrickw3@fb.com, garnermic@fb.com, Delphine Chiu/WYHQ/Wiwynn,
Arnd Bergmann, Olof Johansson, soc@kernel.org, Rob Herring,
Krzysztof Kozlowski, Andrew Jeffery,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Bonnie Lo/WYHQ/Wiwynn
> On 20/09/2022 09:45, Bonnie Lo/WYHQ/Wiwynn wrote:
> > Hi Krzysztof,
> >
> > I revise the device tree as following and resend the mail.
> > It create a new mail thread " [PATCH] ARM: dts: aspeed: greatlakes: Add
> Facebook greatlakes (AST2600) BMC".
> > Kindly to correct me, if there is any problem.
> >
> >> Use subject prefixes matching the subsystem (git log --oneline -- ...).
> >>
> >>>
> >>> Add linux device tree entry related to greatlakes specific devices
> >>> connected to BMC SoC.
> >>
> >> Please wrap commit message according to Linux coding style /
> >> submission
> >> process:
> >> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Feli
> >>
> xir.b%2F&data=05%7C01%7CBonnie_Lo%40wiwynn.com%7Ca2eecb3c2d
> ff4eff
> >>
> 361b08da9ae190fd%7Cda6e0628fc834caf9dd273061cbab167%7C0%7C0%7C6
> 379925
> >>
> 90848633103%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI
> joiV2luM
> >>
> zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MJn
> u2iv19
> >> dvbcMH7SJSExKOFV18dUtGRFSKO6Au2tFg%3D&reserved=0
> >>
> ootlin.com%2Flinux%2Fv5.18-rc4%2Fsource%2FDocumentation%2Fprocess%2
> >>
> Fsubmitting-patches.rst%23L586&data=05%7C01%7CBonnie_Lo%40wiw
> >>
> ynn.com%7C1dee8dcb540a49522fb608da98cdba6f%7Cda6e0628fc834caf9dd
> >>
> 273061cbab167%7C0%7C0%7C637990306620286314%7CUnknown%7CTWFp
> >>
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> >>
> 6Mn0%3D%7C3000%7C%7C%7C&sdata=mC2E3dJbuYgXklS%2Fw8s2w%2
> >> BKH%2BZ3CsZSndFTgPBjyvpw%3D&reserved=0
> >>
> >
> > I have add " ARM: dts: aspeed: greatlakes:".
> >
> >>>
> >>> Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
> >>> ---
> >>> arch/arm/boot/dts/Makefile | 1 +
> >>> .../dts/aspeed-bmc-facebook-greatlakes.dts | 248
> >> ++++++++++++++++++
> >>
> >> Missing documentation of board compatible (bindings) as first patch.
>
> Why did you ignore it?
We need to look at this more. There might be something under the Documentation tree.
Could you guide us an example for adding the document?
>
> >>
> >>> 2 files changed, 249 insertions(+)
> >>> create mode 100644
> >>> arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> >>>
> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >>> index 05d8aef6e5d2..40fa906ab17f 100644
> >>> --- a/arch/arm/boot/dts/Makefile
> >>> +++ b/arch/arm/boot/dts/Makefile
> >>> @@ -1580,6 +1580,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> >>> aspeed-bmc-asrock-e3c246d4i.dtb \
> >>> aspeed-bmc-asrock-romed8hm3.dtb \
> >>> aspeed-bmc-bytedance-g220a.dtb \
> >>> + aspeed-bmc-facebook-greatlakes.dtb \
> >>
> >> Wrong order.
> >
> > I have reordered it.
> >
> >>
> >>> aspeed-bmc-facebook-bletchley.dtb \
> >>> aspeed-bmc-facebook-cloudripper.dtb \
> >>> aspeed-bmc-facebook-cmm.dtb \ diff --git
> >>> a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> >>> b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> >>> new file mode 100644
> >>> index 000000000000..f011cc4d370f
> >>> --- /dev/null
> >>> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
> >>> @@ -0,0 +1,248 @@
> >>> +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2022
> >>> +Facebook Inc.
> >>> +
> >>> +/dts-v1/;
> >>> +#include "aspeed-g6.dtsi"
> >>> +#include <dt-bindings/gpio/aspeed-gpio.h> #include
> >>> +<dt-bindings/i2c/i2c.h> #include <dt-bindings/leds/leds-pca955x.h>
> >>> +
> >>> +/ {
> >>> + model = "AST2600 EVB";
> >>
> >> Wrong name.
> >
> > I have revies the model name " Facebook Greatlakes BMC ".
> >
> >>
> >>> + compatible = "aspeed,ast2600";
> >>
> >> Missing board compatible.
> >>
> >
> > I add board compatible " facebook,greatlakes-bmc"
>
> And what is the output of the checkpatch?
>
> >
> >>> +
> >>> + aliases {
> >>> + serial4 = &uart5;
> >>> + };
> >>> +
> >>> + chosen {
> >>> + stdout-path = &uart5;
> >>> + bootargs = "console=ttyS4,57600n8 root=/dev/ram
> rw
> >>> + vmalloc=384M";
> >>
> >> Bootargs usually do not belong to mainline DTS.
> >
> > Removed.
>
> I still saw bootargs.
>
> (...)
>
> >>>
> >>> WIWYNN PROPRIETARY This email (and any attachments) contains
> >> proprietary or confidential information and is for the sole use of
> >> its intended recipient. Any unauthorized review, use, copying or
> >> distribution of this email or the content of this email is strictly
> >> prohibited. If you are not the intended recipient, please notify the sender
> and delete this email immediately.
> >>
> >> This means we cannot take this patch. Proprietary and/or confidential
> >> patches cannot be merged.
> >>
> >> Please license the patch as you wrote in SPDX header.
> >>
> >> Best regards,
> >> Krzysztof
> > WIWYNN PROPRIETARY
> > This email (and any attachments) contains proprietary or confidential
> information and is for the sole use of its intended recipient. Any
> unauthorized review, use, copying or distribution of this email or the
> content of this email is strictly prohibited. If you are not the intended
> recipient, please notify the sender and delete this email immediately.
>
> Your company is still adding proprietary license. Since I am not intended
> recipient, I will remove your messages.
>
> Best regards,
> Krzysztof
WIWYNN PROPRIETARY
This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
2022-10-05 8:43 ` Delphine_CC_Chiu/WYHQ/Wiwynn
@ 2022-10-05 15:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-05 15:02 UTC (permalink / raw)
To: Delphine_CC_Chiu/WYHQ/Wiwynn, joel@jms.id.au
Cc: patrickw3@fb.com, garnermic@fb.com, Delphine Chiu/WYHQ/Wiwynn,
Arnd Bergmann, Olof Johansson, soc@kernel.org, Rob Herring,
Krzysztof Kozlowski, Andrew Jeffery,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Bonnie Lo/WYHQ/Wiwynn
On 05/10/2022 10:43, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
>> On 20/09/2022 09:45, Bonnie Lo/WYHQ/Wiwynn wrote:
>>> Hi Krzysztof,
>>>
>>> I revise the device tree as following and resend the mail.
>>> It create a new mail thread " [PATCH] ARM: dts: aspeed: greatlakes: Add
>> Facebook greatlakes (AST2600) BMC".
>>> Kindly to correct me, if there is any problem.
>>>
>>>> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>>>>
>>>>>
>>>>> Add linux device tree entry related to greatlakes specific devices
>>>>> connected to BMC SoC.
>>>>
>>>> Please wrap commit message according to Linux coding style /
>>>> submission
>>>> process:
>>>> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Feli
>>>>
>> xir.b%2F&data=05%7C01%7CBonnie_Lo%40wiwynn.com%7Ca2eecb3c2d
>> ff4eff
>>>>
>> 361b08da9ae190fd%7Cda6e0628fc834caf9dd273061cbab167%7C0%7C0%7C6
>> 379925
>>>>
>> 90848633103%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI
>> joiV2luM
>>>>
>> zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MJn
>> u2iv19
>>>> dvbcMH7SJSExKOFV18dUtGRFSKO6Au2tFg%3D&reserved=0
>>>>
>> ootlin.com%2Flinux%2Fv5.18-rc4%2Fsource%2FDocumentation%2Fprocess%2
>>>>
>> Fsubmitting-patches.rst%23L586&data=05%7C01%7CBonnie_Lo%40wiw
>>>>
>> ynn.com%7C1dee8dcb540a49522fb608da98cdba6f%7Cda6e0628fc834caf9dd
>>>>
>> 273061cbab167%7C0%7C0%7C637990306620286314%7CUnknown%7CTWFp
>>>>
>> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
>>>>
>> 6Mn0%3D%7C3000%7C%7C%7C&sdata=mC2E3dJbuYgXklS%2Fw8s2w%2
>>>> BKH%2BZ3CsZSndFTgPBjyvpw%3D&reserved=0
>>>>
>>>
>>> I have add " ARM: dts: aspeed: greatlakes:".
>>>
>>>>>
>>>>> Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
>>>>> ---
>>>>> arch/arm/boot/dts/Makefile | 1 +
>>>>> .../dts/aspeed-bmc-facebook-greatlakes.dts | 248
>>>> ++++++++++++++++++
>>>>
>>>> Missing documentation of board compatible (bindings) as first patch.
>>
>> Why did you ignore it?
>
> We need to look at this more. There might be something under the Documentation tree.
> Could you guide us an example for adding the document?
https://lore.kernel.org/all/?q=s%3A%22dt-bindings%3A+arm%3A%22
Fix your email server so it won't add footers making open-source
collaboration not possible. You said that this email "contains
proprietary or confidential information", therefore it is not suitable
for open-source discussions.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-05 15:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15 7:23 [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Bonnie Lo
2022-09-17 16:57 ` Krzysztof Kozlowski
2022-09-20 7:45 ` Bonnie Lo/WYHQ/Wiwynn
2022-09-20 8:24 ` Krzysztof Kozlowski
2022-10-05 8:43 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2022-10-05 15:02 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).